[AAP-41917] fix: default EDA_MODE to production (#1236)

env EDA_MODE was not set. All settings from
production/development/testing are imported.
This fix sets EDA_MODE to production by default to avoid conflict
settings from different modes. Different mode can still be set by the
env var.

Also directly call toggle_feature_flags function from DAB.

[AAP-41917](https://issues.redhat.com/browse/AAP-41917)

For testing pick a setting and set to different value in
/etc/eda/settings.yaml under production/development/testing sections and
prove the value is selected according to explicitly set EDA_MODE. When
EDA_MODE is not set, the value under production is selected.

Author: bzwei

src/aap_eda/settings/default.py

@@ -11,17 +11,24 @@
 #  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 #  See the License for the specific language governing permissions and
 #  limitations under the License.
+import os
+
 from ansible_base.lib.dynamic_config import (
     export,
     factory,
     load_dab_settings,
     load_envvars,
     load_standard_settings_files,
+    toggle_feature_flags,
 )
 
 from .post_load import post_loading
 
-EDA_SETTINGS_FILE = "/etc/eda/settings.yaml"
+EDA_SETTINGS_FILE = os.environ.get(
+    "EDA_SETTINGS_FILE", "/etc/eda/settings.yaml"
+)
+
+os.environ["EDA_MODE"] = os.environ.get("EDA_MODE", "production")
 
 DYNACONF = factory(
     __name__,
@@ -31,12 +38,27 @@
     settings_files=["defaults.py"],
 )
 
-DYNACONF.load_file(EDA_SETTINGS_FILE)
+# Insert the custom file in the list of standard settings so DAB loads it
+# without requiring mode based sections.
+DYNACONF.set(
+    "ANSIBLE_STANDARD_SETTINGS_FILES", f"@insert 3 {EDA_SETTINGS_FILE}"
+)
+
 load_standard_settings_files(
     DYNACONF
 )  # /etc/ansible-automation-platform/*.yaml
 load_envvars(DYNACONF)  # load envvars prefixed with EDA_
 DYNACONF.load_file("core.py")  # load internal non-overwritable settings
 post_loading(DYNACONF)
 load_dab_settings(DYNACONF)
+
+# toggle feature flags, considering flags coming from
+# /etc/ansible-automation-platform/*.yaml
+# and envvars like `EDA_FEATURE_FOO_ENABLED=true
+DYNACONF.update(
+    toggle_feature_flags(DYNACONF),
+    loader_identifier="settings:toggle_feature_flags",
+    merge=True,
+)
+
 export(__name__, DYNACONF)  # export back to django.conf.settings

src/aap_eda/settings/post_load.py

@@ -11,11 +11,10 @@
 #  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 #  See the License for the specific language governing permissions and
 #  limitations under the License.
-from typing import Any, Optional, get_type_hints
+from typing import Optional, get_type_hints
 
 from django.core.exceptions import ImproperlyConfigured
 from dynaconf import Dynaconf
-from dynaconf.utils.functional import empty
 
 from aap_eda import utils
 from aap_eda.core.enums import RulebookProcessLogLevel
@@ -85,28 +84,6 @@ def _get_url_end_slash(settings: Dynaconf, name: str) -> str:
     return value
 
 
-def toggle_feature_flags(settings: Dynaconf) -> dict[str, Any]:
-    """Toggle FLAGS based on installer settings.
-
-    FLAGS is a django-flags formatted dictionary.
-        FLAGS={
-            "FEATURE_SOME_PLATFORM_FLAG_ENABLED": [
-                {"condition": "boolean", "value": False, "required": True},
-                {"condition": "before date", "value": "2022-06-01T12:00Z"},
-            ]
-        }
-    Installers will place `FEATURE_SOME_PLATFORM_FLAG_ENABLED=True/False` in
-    the settings file. This function will update the value in the index 0 in
-    FLAGS with the installer value.
-    """
-    data = {}
-    for feature_name, feature_content in settings.get("FLAGS", {}).items():
-        if (installer_value := settings.get(feature_name, empty)) is not empty:
-            feature_content[0]["value"] = installer_value
-            data[f"FLAGS__{feature_name}"] = feature_content
-    return data
-
-
 # Database
 # https://docs.djangoproject.com/en/4.1/ref/settings/#databases
 
@@ -433,12 +410,3 @@ def post_loading(loaded_settings: Dynaconf):
         if key not in loaded_settings or settings[key] != loaded_settings[key]
     }
     loaded_settings.update(data, loader_identifier="settings:post_loading")
-
-    # toggle feature flags, considering flags coming from
-    # /etc/ansible-automation-platform/*.yaml
-    # and envvars like `EDA_FEATURE_FOO_ENABLED=true
-    loaded_settings.update(
-        toggle_feature_flags(settings),
-        loader_identifier="settings:toggle_feature_flags",
-        merge=True,
-    )

tests/integration/api/test_feature_flags.py

@@ -1,10 +1,10 @@
 import pytest
+from ansible_base.lib.dynamic_config import toggle_feature_flags
 from django.conf import settings
 from django.test import override_settings
 from flags.state import flag_state
 from rest_framework import status
 
-from aap_eda.settings.post_load import toggle_feature_flags
 from tests.integration.constants import api_url_v1
 
 

tests/unit/data/demo_settings.yaml

@@ -0,0 +1 @@
+SECRET_KEY: "dev.key"

tests/unit/test_import_settings.py

@@ -0,0 +1,69 @@
+#  Copyright 2025 Red Hat, Inc.
+#
+#  Licensed under the Apache License, Version 2.0 (the "License");
+#  you may not use this file except in compliance with the License.
+#  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License.
+
+import importlib
+import os
+
+from django import conf
+
+from aap_eda.settings import default
+
+
+def test_eda_mode():
+    # pytest defaults
+    assert conf.settings.MODE == "development"
+    dev_sec_key = conf.settings.SECRET_KEY
+    sec_env_var = os.getenv("EDA_SECRET_KEY")
+
+    # default to production mode (need to provide SECRET_KEY)
+    os.environ.pop("EDA_MODE")
+    os.environ["EDA_SECRET_KEY"] = "product"
+    importlib.reload(default)
+    importlib.reload(conf)
+    assert conf.settings.MODE == "production"
+    assert conf.settings.SECRET_KEY == "product"
+
+    # roll back to pytest defaults
+    os.environ["EDA_MODE"] = "development"
+    if sec_env_var:
+        os.environ["EDA_SECRET_KEY"] = sec_env_var
+    else:
+        os.environ.pop("EDA_SECRET_KEY")
+    importlib.reload(default)
+    importlib.reload(conf)
+    assert conf.settings.MODE == "development"
+    assert conf.settings.SECRET_KEY == dev_sec_key
+
+
+def test_import_from_yaml():
+    dev_sec_key = conf.settings.SECRET_KEY
+    sec_env_var = os.getenv("EDA_SECRET_KEY")
+    if sec_env_var:
+        os.environ.pop("EDA_SECRET_KEY")
+
+    file_path = os.path.abspath(__file__)
+    file_dir = os.path.dirname(file_path)
+    user_settings_file = os.path.join(file_dir, "data/demo_settings.yaml")
+    os.environ["EDA_SETTINGS_FILE"] = user_settings_file
+    importlib.reload(default)
+    importlib.reload(conf)
+    assert conf.settings.SECRET_KEY == "dev.key"
+
+    # roll back
+    os.environ.pop("EDA_SETTINGS_FILE", None)
+    if sec_env_var:
+        os.environ["EDA_SECRET_KEY"] = sec_env_var
+    importlib.reload(default)
+    importlib.reload(conf)
+    assert conf.settings.SECRET_KEY == dev_sec_key