refactor: get feature flags from features module (#1293)

<!-- Mandatory: Provide a clear, concise description of the changes and
their purpose -->
Get whether a feature flag is on or off as a constant from the new
features module.
It improves the code readability and slightly the performance as the
flags are now cached.

This work is to prepare the merging of the dispatcherd feature which is
guarded by a flag.

Author: bzwei

src/aap_eda/analytics/collector.py

@@ -16,13 +16,14 @@
 from datetime import datetime
 from typing import Optional
 
+from django.conf import settings
 from django.core.serializers.json import DjangoJSONEncoder
 from django.db import connection
-from flags.state import flag_enabled
 from insights_analytics_collector import Collector
 
 from aap_eda.analytics import analytics_collectors, package, utils
 from aap_eda.conf.settings import application_settings
+from aap_eda.settings import features
 
 
 class AnalyticsCollector(Collector):
@@ -35,10 +36,7 @@ def _package_class() -> package.Package:
         return package.Package
 
     def _is_shipping_configured(self) -> bool:
-        if (
-            not flag_enabled("FEATURE_EDA_ANALYTICS_ENABLED")
-            or not utils.get_insights_tracking_state()
-        ):
+        if not features.ANALYTICS or not utils.get_insights_tracking_state():
             self.logger.warning(
                 "Insights for Event Driven Ansible is not enabled."
             )
@@ -91,8 +89,8 @@ def _save_last_gather(self) -> None:
 def gather(collection_type="scheduled", since=None, until=None, logger=None):
     if not logger:
         logger = logging.getLogger("aap_eda.analytics")
-    if not flag_enabled("FEATURE_EDA_ANALYTICS_ENABLED"):
-        logger.info("FEATURE_EDA_ANALYTICS_ENABLED is set to False.")
+    if not features.ANALYTICS:
+        logger.info(f"{settings.ANALYTICS_FEATURE_FLAG_NAME} is set to False.")
         return
     collector = AnalyticsCollector(
         collector_module=analytics_collectors,

src/aap_eda/core/management/commands/create_initial_data.py

@@ -23,13 +23,13 @@
 from django.core.management import BaseCommand
 from django.db import transaction
 from django.db.models import Q
-from flags.state import flag_enabled
 
 from aap_eda.conf import settings_registry
 from aap_eda.core import enums, models
 from aap_eda.core.models.utils import get_default_organization
 from aap_eda.core.tasking import enable_redis_prefix
 from aap_eda.core.utils.credentials import inputs_to_store
+from aap_eda.settings import features
 
 NEW_HELP_TEXT = (
     "Red Hat Ansible Automation Platform base URL to authenticate with.",
@@ -1255,7 +1255,7 @@ def populate_credential_types(
     for credential_type_data in credential_types:
         # Analytics credential types are only available when it's enabled
         if (
-            not flag_enabled("FEATURE_EDA_ANALYTICS_ENABLED")
+            not features.ANALYTICS
             and credential_type_data.get("name")
             in enums.SINGLETON_CREDENTIAL_TYPES
         ):

src/aap_eda/core/management/commands/gather_analytics.py

@@ -16,10 +16,11 @@
 from datetime import timezone
 
 from dateutil import parser
+from django.conf import settings
 from django.core.management.base import BaseCommand, CommandParser
-from flags.state import flag_enabled
 
 from aap_eda.analytics import collector
+from aap_eda.settings import features
 
 
 class Command(BaseCommand):
@@ -71,8 +72,10 @@ def handle(self, *args, **options):
         opt_since = options.get("since")
         opt_until = options.get("until")
 
-        if not flag_enabled("FEATURE_EDA_ANALYTICS_ENABLED"):
-            self.logger.error("FEATURE_EDA_ANALYTICS_ENABLED is set to False.")
+        if not features.ANALYTICS:
+            self.logger.error(
+                f"{settings.ANALYTICS_FEATURE_FLAG_NAME} is set to False."
+            )
             return
 
         since = parser.parse(opt_since) if opt_since else None

src/aap_eda/core/management/commands/rqworker.py

@@ -17,7 +17,8 @@
 from django.conf import settings
 from django.core.management.base import BaseCommand, CommandParser
 from django_rq.management.commands import rqworker
-from flags.state import flag_enabled
+
+from aap_eda.settings import features
 
 
 class Command(BaseCommand):
@@ -33,7 +34,7 @@ def add_arguments(self, parser: CommandParser) -> None:
         return rqworker.Command.add_arguments(self, parser)
 
     def handle(self, *args, **options) -> None:
-        if flag_enabled(settings.DISPATCHERD_FEATURE_FLAG_NAME):
+        if features.DISPATCHERD:
             self.stderr.write(
                 self.style.ERROR(
                     "DISPATCHERD feature not implemented yet. "

src/aap_eda/core/management/commands/scheduler.py

@@ -77,9 +77,9 @@
 import rq_scheduler
 from django.conf import settings
 from django_rq.management.commands import rqscheduler
-from flags.state import flag_enabled
 
 from aap_eda.core import tasking
+from aap_eda.settings import features
 from aap_eda.utils.logging import startup_logging
 
 logger = logging.getLogger(__name__)
@@ -166,7 +166,7 @@ class Command(rqscheduler.Command):
     help = "Runs RQ scheduler with configured jobs."
 
     def handle(self, *args, **options) -> None:
-        if flag_enabled(settings.DISPATCHERD_FEATURE_FLAG_NAME):
+        if features.DISPATCHERD:
             self.stderr.write(
                 self.style.ERROR(
                     "This command is not supported when "

src/aap_eda/settings/core.py

@@ -17,9 +17,10 @@
 # Defines feature flags, and their conditions.
 # See https://cfpb.github.io/django-flags/
 DISPATCHERD_FEATURE_FLAG_NAME = "FEATURE_DISPATCHERD_ENABLED"
+ANALYTICS_FEATURE_FLAG_NAME = "FEATURE_EDA_ANALYTICS_ENABLED"
 
 FLAGS = {
-    "FEATURE_EDA_ANALYTICS_ENABLED": [
+    ANALYTICS_FEATURE_FLAG_NAME: [
         {
             "condition": "boolean",
             "value": False,

src/aap_eda/settings/features.py

@@ -0,0 +1,46 @@
+#  Copyright 2025 Red Hat, Inc.
+#
+#  Licensed under the Apache License, Version 2.0 (the "License");
+#  you may not use this file except in compliance with the License.
+#  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License.
+
+from functools import cache
+from typing import Any, Dict
+
+from django.conf import settings
+from flags.state import flag_enabled
+
+# Type hints for module attributes
+DISPATCHERD: bool
+ANALYTICS: bool
+
+# Mapping of feature names to their corresponding setting names
+_FEATURE_FLAGS: Dict[str, str] = {
+    "DISPATCHERD": "DISPATCHERD_FEATURE_FLAG_NAME",
+    "ANALYTICS": "ANALYTICS_FEATURE_FLAG_NAME",
+}
+
+
+@cache
+def _get_feature(name: str) -> bool:
+    """Get the current value of a feature flag."""
+    return flag_enabled(name)
+
+
+def __getattr__(name: str) -> Any:
+    """Dynamically provide access to feature flags as module attributes."""
+    try:
+        setting_name = _FEATURE_FLAGS[name]
+        return _get_feature(getattr(settings, setting_name))
+    except KeyError:
+        raise AttributeError(
+            f"module {__name__} has no attribute {name}"
+        ) from None

src/aap_eda/tasks/analytics.py

@@ -16,10 +16,10 @@
 
 import django_rq
 from ansible_base.lib.utils.db import advisory_lock
-from flags.state import flag_enabled
 
 from aap_eda.analytics import collector, utils
 from aap_eda.core import tasking
+from aap_eda.settings import features
 
 logger = logging.getLogger(__name__)
 
@@ -36,7 +36,7 @@
 def schedule_gather_analytics(
     queue_name: str = ANALYTICS_TASKS_QUEUE, cancel: bool = False
 ) -> None:
-    if not flag_enabled("FEATURE_EDA_ANALYTICS_ENABLED"):
+    if not features.ANALYTICS:
         return
     interval = utils.get_analytics_interval()
     logger.info(f"Schedule analytics to run in {interval} seconds")

tests/integration/analytics/test_collector.py

@@ -18,7 +18,6 @@
 
 import pytest
 from django.db import connection
-from django.test import override_settings
 
 from aap_eda.analytics.collector import AnalyticsCollector, gather
 
@@ -42,12 +41,11 @@ def collector():
     return collector
 
 
-@patch("aap_eda.analytics.collector.flag_enabled")
+@patch("aap_eda.analytics.collector.features.ANALYTICS", True)
 @patch("aap_eda.analytics.collector.AnalyticsCollector")
-def test_gather_when_enabled(mock_collector_cls, mock_flag_enabled):
+def test_gather_when_enabled(mock_collector_cls):
     """Test gather function when FEATURE_EDA_ANALYTICS_ENABLED
     is set to True"""
-    mock_flag_enabled.return_value = True
     mock_collector_cls.return_value = MagicMock()
     mock_logger = MagicMock()
 
@@ -58,7 +56,6 @@ def test_gather_when_enabled(mock_collector_cls, mock_flag_enabled):
         logger=mock_logger,
     )
 
-    mock_flag_enabled.assert_called_once_with("FEATURE_EDA_ANALYTICS_ENABLED")
     mock_collector_cls.assert_called_once_with(
         collector_module=ANY,
         collection_type="manual",
@@ -67,27 +64,19 @@ def test_gather_when_enabled(mock_collector_cls, mock_flag_enabled):
     assert result is not None
 
 
-@patch("aap_eda.analytics.collector.flag_enabled")
-def test_gather_when_disabled(mock_flag_enabled):
+@patch("aap_eda.analytics.collector.features.ANALYTICS", False)
+def test_gather_when_disabled():
     """Test gather function when FEATURE_EDA_ANALYTICS_ENABLED
     is set to False"""
-    mock_flag_enabled.return_value = False
     mock_logger = MagicMock()
-
     result = gather(logger=mock_logger)
-
-    mock_logger.info.assert_called_once_with(
-        "FEATURE_EDA_ANALYTICS_ENABLED is set to False."
-    )
     assert result is None
 
 
 @pytest.mark.django_db
-@patch("aap_eda.analytics.collector.flag_enabled")
+@patch("aap_eda.analytics.collector.features.ANALYTICS", True)
 @patch("aap_eda.analytics.collector.AnalyticsCollector")
-def test_gather_uses_default_logger(mock_collector_cls, mock_flag_enabled):
-    mock_flag_enabled.return_value = True
-
+def test_gather_uses_default_logger(mock_collector_cls):
     with patch(
         "aap_eda.analytics.collector.logging.getLogger"
     ) as mock_get_logger:
@@ -119,20 +108,15 @@ def test_shipping_disabled_logs_warning(
     with patch(
         "aap_eda.analytics.utils.get_insights_tracking_state",
         return_value=insights_tracking_state,
+    ), patch(
+        "aap_eda.analytics.collector.features.ANALYTICS", feature_flag_state
     ):
-        with override_settings(
-            FLAGS={
-                "FEATURE_EDA_ANALYTICS_ENABLED": [
-                    ("boolean", feature_flag_state)
-                ]
-            }
-        ):
-            assert collector._is_shipping_configured() is expected
-
-            if not expected:
-                collector.logger.warning.assert_called_once_with(
-                    "Insights for Event Driven Ansible is not enabled."
-                )
+        assert collector._is_shipping_configured() is expected
+
+        if not expected:
+            collector.logger.warning.assert_called_once_with(
+                "Insights for Event Driven Ansible is not enabled."
+            )
 
 
 @pytest.mark.django_db

tests/integration/analytics/test_gather_analytics.py

@@ -17,6 +17,7 @@
 from unittest import mock
 
 import pytest
+from django.conf import settings
 from django.core.management import call_command
 from django.test import override_settings
 
@@ -35,9 +36,12 @@
 )
 @pytest.mark.django_db
 @override_settings(
-    FLAGS={"FEATURE_EDA_ANALYTICS_ENABLED": [("boolean", True)]},
     AUTOMATION_AUTH_METHOD="user-pass",
 )
+@mock.patch(
+    "aap_eda.core.management.commands.gather_analytics.features.ANALYTICS",
+    True,
+)
 def test_gather_analytics_invalid_settings(
     analytics_settings,
     caplog_factory,
@@ -124,14 +128,15 @@ def test_gather_analytics_invalid_settings(
     ],
 )
 @pytest.mark.django_db
-@override_settings(
-    FLAGS={"FEATURE_EDA_ANALYTICS_ENABLED": [("boolean", True)]}
-)
 @mock.patch(
     "aap_eda.core.management.commands.gather_analytics.collector.gather"
 )
+@mock.patch(
+    "aap_eda.core.management.commands.gather_analytics.features.ANALYTICS",
+    True,
+)
 def test_gather_analytics_command(
-    mock_gather, analytics_settings, caplog_factory, args, log_level, expected
+    analytics_settings, caplog_factory, args, log_level, expected
 ):
     with mock.patch(
         "aap_eda.analytics.collector.application_settings",
@@ -161,7 +166,7 @@ def test_gather_analytics_command(
     "feature_flag_state, expected",
     [
         (True, "Either --ship or --dry-run needs to be set."),
-        (False, "FEATURE_EDA_ANALYTICS_ENABLED is set to False."),
+        (False, f"{settings.ANALYTICS_FEATURE_FLAG_NAME} is set to False."),
     ],
 )
 def test_gather_analytics_command_by_ff_state(
@@ -170,20 +175,15 @@ def test_gather_analytics_command_by_ff_state(
     with mock.patch(
         "aap_eda.analytics.collector.application_settings",
         new=analytics_settings,
+    ), mock.patch(
+        "aap_eda.core.management.commands.gather_analytics.features.ANALYTICS",
+        feature_flag_state,
     ):
         analytics_settings.INSIGHTS_TRACKING_STATE = True
         out = StringIO()
         logger = logging.getLogger("aap_eda.analytics")
         eda_log = caplog_factory(logger)
-        with override_settings(
-            FLAGS={
-                "FEATURE_EDA_ANALYTICS_ENABLED": [
-                    ("boolean", feature_flag_state)
-                ]
-            }
-        ):
-            command = "gather_analytics"
-            call_command(command, stdout=out)
+        call_command("gather_analytics", stdout=out)
 
         assert any(
             record.levelname == "ERROR" and record.message == expected