Skip to content

Commit 9346d36

Browse files
Revert "ci: make CI github workflow reusable (#1339)" (#1341)
The approach of #1339 is not enough for what we need to do. We need to support auth and private sources in forks and mirrors, so it means, we need to alter the workflow itself, not only the call to the workflow. Also it has a problem, because now the workflow is called, there is a task that is failing in main because it has no acccess to some org variables ([example](https://github.com/ansible/eda-server/actions/runs/15472565707/job/43560431636#step:12:24)) I did not noticed this problem because it is only executed on main. This PR reverts the change and restore the previous configuration. It will need too to revert the status checks required in the repo configuration after merge. After this rollback I will create a new PR with a different approach: Instead of making the whole workflow reusable I will extract some jobs into reusable actions, this allow us to compose different workflows by reusable pieces and customize steps, like configuring ssh/tokens for private sources and so on. This PR will have also in consideration the variables that are required for some steps.
1 parent e91d392 commit 9346d36

File tree

2 files changed

+5
-16
lines changed

2 files changed

+5
-16
lines changed

.github/workflows/ci.yaml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
1-
# Reusable GitHub Actions workflow for CI
2-
# intended to be called by other workflows
3-
41
name: CI
52

63
env:
74
POETRY_NO_INTERACTION: 1
85

96
on:
10-
workflow_call:
7+
push:
8+
branches: [ 'main' ]
9+
pull_request:
10+
merge_group:
11+
branches: [ 'main' ]
1112

1213
concurrency:
1314
group: ${{ github.head_ref || github.run_id }}

.github/workflows/run-ci.yml

Lines changed: 0 additions & 12 deletions
This file was deleted.

0 commit comments

Comments
 (0)