fix: when doing credential test inputs and metadata are mandatory (#1384)

When doing external sms credential test we need both inputs and
metadata.

There is no UI field related to this unlike other ValidationErrors We
return a 400 when either of them is missing

https://issues.redhat.com/browse/AAP-51130

When the test is run through the UI it adheres by the schema and ensures
that all required fields are identified in red and only once the user
has provided all the parameters is the test run. When the same test is
run via scripts or collection these checks are not performed so there is
a chance they might pass in an empty dictionary this PR basically
proectes the backend from these cases.

<img width="1089" height="490" alt="Screenshot 2025-08-20 at 9 49 19 PM"
src="https://github.com/user-attachments/assets/f7696ee1-b3a4-427c-8e32-27037a5e9f04"
/>

Author: mkanoor

src/aap_eda/core/validators.py

@@ -598,6 +598,11 @@ def check_if_refspec_valid(refspec: str) -> str:
 def check_credential_test_data(
     credential_type: models.CredentialType, inputs: dict, metadata: dict
 ):
+    if not inputs or not metadata:
+        raise serializers.ValidationError(
+            "In test mode both inputs and metadata have to be provided"
+        )
+
     errors = validate_inputs(
         credential_type, credential_type.inputs, inputs, "fields"
     )

tests/integration/api/test_credential_type.py

@@ -911,6 +911,31 @@ def test_create_credential_type_with_duplicates(
             True,
             None,
         ),
+        (
+            {
+                "url": "https://www.example.com",
+                "api_version": "v2",
+                "token": "token123",
+            },
+            None,
+            status.HTTP_400_BAD_REQUEST,
+            True,
+            None,
+        ),
+        (
+            None,
+            {"secret_path": "secret/foo", "secret_key": "bar"},
+            status.HTTP_400_BAD_REQUEST,
+            True,
+            None,
+        ),
+        (
+            None,
+            None,
+            status.HTTP_400_BAD_REQUEST,
+            True,
+            None,
+        ),
     ],
 )
 def test_credential_type_test(
@@ -927,10 +952,11 @@ def test_credential_type_test(
         name=enums.DefaultCredentialType.HASHICORP_LOOKUP
     )
 
-    data_in = {
-        "inputs": inputs,
-        "metadata": metadata,
-    }
+    data_in = {}
+    if inputs:
+        data_in["inputs"] = inputs
+    if metadata:
+        data_in["metadata"] = metadata
     if credential_type_id:
         url = f"{api_url_v1}/credential-types/{credential_type_id}/test/"
     else:

tests/integration/api/test_eda_credential.py

@@ -1459,14 +1459,19 @@ def test_create_external_credential_type(
             status.HTTP_400_BAD_REQUEST,
             True,
         ),
+        (
+            None,
+            status.HTTP_400_BAD_REQUEST,
+            True,
+        ),
     ],
 )
 @pytest.mark.django_db
 def test_create_external_credential_test(
     admin_client: APIClient,
     default_organization: models.Organization,
     preseed_credential_types,
-    metadata: dict,
+    metadata: Optional[dict],
     status_code: int,
     raise_exception: bool,
 ):
@@ -1496,9 +1501,12 @@ def test_create_external_credential_test(
             "aap_eda.api.views.eda_credential.run_plugin",
             side_effect=Exception("kaboom"),
         ):
+            data = {}
+            if metadata:
+                data["metadata"] = metadata
             response = admin_client.post(
                 f"{api_url_v1}/eda-credentials/{obj['id']}/test/",
-                data={"metadata": metadata},
+                data=data,
             )
             assert response.status_code == status_code
     else: