fix: change default org to be immutable (#872)

Author: Dostonbek1

src/aap_eda/api/serializers/organization.py

@@ -13,7 +13,9 @@
 #  limitations under the License.
 
 from ansible_base.lib.serializers.common import NamedCommonModelSerializer
+from django.conf import settings
 
+from aap_eda.api import exceptions as api_exc
 from aap_eda.core.models import Organization
 
 from .fields.ansible_resource import AnsibleResourceFieldSerializer
@@ -37,6 +39,17 @@ class Meta:
             "modified_by",
         ]
 
+    def validate(self, data):
+        # when creating a new org, self.instance is empty
+        if (
+            self.instance
+            and self.instance.name == settings.DEFAULT_ORGANIZATION_NAME
+        ):
+            raise api_exc.Conflict(
+                "The default organization cannot be modified."
+            )
+        return data
+
 
 class OrganizationRefSerializer(NamedCommonModelSerializer):
     class Meta:

tests/integration/api/test_organization.py

@@ -136,18 +136,35 @@ def test_retrieve_organization_not_exist(admin_client: APIClient):
 
 
 @pytest.mark.django_db
-def test_partial_update_organization(
-    default_organization: models.Organization,
-    admin_client: APIClient,
+def test_partial_update_organization_success(
+    new_organization: models.Organization,
+    superuser_client: APIClient,
 ):
     new_data = {"name": "new-name", "description": "New Description"}
-    response = admin_client.patch(
-        f"{api_url_v1}/organizations/{default_organization.id}/", data=new_data
+    response = superuser_client.patch(
+        f"{api_url_v1}/organizations/{new_organization.id}/", data=new_data
     )
     assert response.status_code == status.HTTP_200_OK
 
-    default_organization.refresh_from_db()
-    assert_organization_data(response.data, default_organization)
+    new_organization.refresh_from_db()
+    assert_organization_data(response.data, new_organization)
+
+
+@pytest.mark.django_db
+def test_partial_update_default_organization_exception(
+    default_organization: models.Organization,
+    superuser_client: APIClient,
+):
+    new_data = {"name": "new-name", "description": "New Description"}
+    response = superuser_client.patch(
+        f"{api_url_v1}/organizations/{default_organization.id}/", data=new_data
+    )
+    assert response.status_code == status.HTTP_409_CONFLICT
+    assert (
+        response.data["detail"]
+        == "The default organization cannot be modified."
+    )
+    assert models.Organization.objects.get(id=default_organization.id)
 
 
 @pytest.mark.django_db

tests/integration/dab_rbac/conftest.py

@@ -47,6 +47,9 @@ def get_model_name(self, model):
     def get_fixture_object(self, request, name):
         if name == "rulebook_process":
             name = "activation_instance"
+        # default org is immutable
+        elif name == "organization":
+            return request.getfixturevalue("new_organization")
         return request.getfixturevalue(f"default_{name}")
 
     def get_post_data(self, model_obj):