fix: ensure rulebook_queue_name is not sanitized outside dispatcherd flag (#1351)

We have found a bug where the installers set a rulebook queue_name
longer than 63 chars, a limit imposed for pg_notify (dispatcherd feature
flag). This was set at the initialization of settings, where we can not
check yet the status of the flag.
This PR ensure the queue name is not sanitized for pg_notify when the
feature flag is not enabled.

[Jira: AAP-48235](https://issues.redhat.com/browse/AAP-48235)

Signed-off-by: Alex <[email protected]>

Author: Alex-Izquierdo

src/aap_eda/core/management/commands/rqworker.py

@@ -22,6 +22,7 @@
 from django.core.management.base import BaseCommand, CommandParser
 from django_rq.management.commands import rqworker
 
+from aap_eda import utils
 from aap_eda.settings import features
 
 logger = logging.getLogger(__name__)
@@ -55,8 +56,27 @@ def _handle_dispatcherd(self, *args, **options) -> None:
 
         # Use rqworker expected args to determine worker type
         if "ActivationWorker" in options["worker_class"]:
+            # dispatcherd worker settings can not be initialized as settings
+            # because the queue name sanitization must happen
+            # after the settings are loaded, we can not check the feature flag
+            # before the settings are loaded.
+            dispatcher_worker_settings = {
+                **settings.DISPATCHERD_DEFAULT_SETTINGS,
+                "brokers": {
+                    "pg_notify": {
+                        **settings.DISPATCHERD_DEFAULT_SETTINGS["brokers"][
+                            "pg_notify"
+                        ],
+                        "channels": [
+                            utils.sanitize_postgres_identifier(
+                                settings.RULEBOOK_QUEUE_NAME,
+                            )
+                        ],
+                    },
+                },
+            }
             dispatcherd_setup(
-                settings.DISPATCHERD_ACTIVATION_WORKER_SETTINGS,
+                dispatcher_worker_settings,
             )
 
         elif "DefaultWorker" in options["worker_class"]:

src/aap_eda/settings/post_load.py

@@ -530,22 +530,6 @@ def post_loading(loaded_settings: Dynaconf):
         },
     }
 
-    settings.DISPATCHERD_ACTIVATION_WORKER_SETTINGS = {
-        **settings.DISPATCHERD_DEFAULT_SETTINGS,
-        "brokers": {
-            "pg_notify": {
-                **settings.DISPATCHERD_DEFAULT_SETTINGS["brokers"][
-                    "pg_notify"
-                ],
-                "channels": [
-                    utils.sanitize_postgres_identifier(
-                        settings.RULEBOOK_QUEUE_NAME,
-                    )
-                ],
-            },
-        },
-    }
-
     data = {
         key: settings[key]
         for key in settings