chore: reduce e2e feature coverage to improve resiliency (#2443)

- remove diagnostic testing with ansible-lint missing
- remove diagnostic testing with validation disabled

If needed these tests should be implemented as unit.

Author: ssbarnea

.github/workflows/ci.yaml

@@ -336,7 +336,7 @@ jobs:
         if: contains(matrix.name, 'test') && steps.ready_to_test.outputs.ready_to_test == 'true'
         run: task mcp:test ${{ matrix.env.TASKFILE_ARGS }} && task mcp:test ${{ matrix.env.TASKFILE_ARGS }} --status
 
-      - name: task e2e
+      - name: task e2e (vscode-test)
         # https://github.com/ansible/vscode-ansible/issues/1451
         if: ${{ !cancelled() && contains(matrix.name, 'test') && steps.ready_to_test.outputs.ready_to_test == 'true' }}
         run: |
@@ -346,7 +346,7 @@ jobs:
         #  || { task flush && task e2e ${{ matrix.env.TASKFILE_ARGS }}; }
         #  task e2e ${{ matrix.env.TASKFILE_ARGS }} --status
 
-      - name: task ui
+      - name: task ui (extest)
         # https://github.com/ansible/vscode-ansible/issues/1451
         if: ${{ !cancelled() && contains(matrix.name, 'test') && !contains(matrix.name, 'wsl') && steps.ready_to_test.outputs.ready_to_test == 'true'}}
         run: |

test/e2e/diagnostics/ansibleWithoutEE.test.ts

@@ -76,70 +76,4 @@ describe("ansible-diag-no-ee", function () {
       ]);
     });
   });
-
-  describe("Diagnostic test with ansible-syntax-check", function () {
-    before(async function () {
-      await updateSettings("validation.lint.enabled", false);
-      await vscode.commands.executeCommand("workbench.action.closeAllEditors");
-      // Give language server time to process document close and settings change
-      await new Promise((resolve) => setTimeout(resolve, 2500));
-      clearActivationCache(); // Clear cache after editors closed
-    });
-
-    after(async function () {
-      await updateSettings("validation.lint.enabled", true); // Revert back the setting to default
-      await vscode.commands.executeCommand("workbench.action.closeAllEditors");
-      clearActivationCache(); // Clear cache after editors closed
-    });
-
-    it("should return no diagnostics", async function () {
-      await activate(docUri1);
-      await vscode.commands.executeCommand("workbench.action.files.save");
-      await waitForDiagnosisCompletion(); // Wait for the diagnostics to compute on this file
-
-      await testDiagnostics(docUri1, []);
-    });
-
-    it("should complain about invalid `hosts` key", async function () {
-      await activate(docUri2);
-      await vscode.commands.executeCommand("workbench.action.files.save");
-      await waitForDiagnosisCompletion(); // Wait for the diagnostics to compute on this file
-
-      await testDiagnostics(docUri2, [
-        {
-          severity: 0,
-          message: "Error processing keyword 'hosts': 'my_hosts' is undefined",
-          range: new vscode.Range(
-            new vscode.Position(0, 0),
-            new vscode.Position(0, integer.MAX_VALUE),
-          ),
-          source: "Ansible",
-        },
-      ]);
-    });
-  });
-
-  describe("no diagnostics", function () {
-    before(async function () {
-      await updateSettings("validation.enabled", false);
-      await vscode.commands.executeCommand("workbench.action.closeAllEditors");
-      // Give language server time to process document close and settings change
-      await new Promise((resolve) => setTimeout(resolve, 500));
-      clearActivationCache(); // Clear cache after editors closed
-    });
-
-    after(async function () {
-      await updateSettings("validation.enabled", true); // Revert back the setting to default
-      await vscode.commands.executeCommand("workbench.action.closeAllEditors");
-      clearActivationCache(); // Clear cache after editors closed
-    });
-
-    it("should return no diagnostics even when `hosts` key is missing", async function () {
-      await activate(docUri2);
-      await vscode.commands.executeCommand("workbench.action.files.save");
-      await waitForDiagnosisCompletion(); // Wait for the diagnostics to compute on this file
-
-      await testDiagnostics(docUri2, []);
-    });
-  });
 });