use tags instead of when condition to determine when to run tests.

removed ansible 1.7.2 environment.
idempotence tests now pass.
removed launchpad_ppa_webupd8_cache_valid_time variable

removed extra Tests section from README file.

Author: steenzout

README.md

@@ -10,6 +10,7 @@
 
 An [Ansible](http://www.ansible.com) role to setup the [webupd8](http://www.webupd8.org/) launchpad apt repository. 
 
+
 ## Tests
 
 | Family | Distribution | Version | Test Status |
@@ -20,20 +21,6 @@ An [Ansible](http://www.ansible.com) role to setup the [webupd8](http://www.webu
 | Debian | Ubuntu  | Trusty  | [![x86_64](http://img.shields.io/badge/x86_64-passed-006400.svg?style=flat)](#) |
 | Debian | Ubuntu  | Vivid   | [![x86_64](http://img.shields.io/badge/x86_64-passed-006400.svg?style=flat)](#) |
 
-## Tests
-
-| Family | Distribution | Version | Test Status |
-|:-:|:-:|:-:|:-:|
-| Debian | Debian  | Jessie  | [![x86](http://img.shields.io/badge/x86-n/a-cccccc.svg?style=flat)](#) [![x86_64](http://img.shields.io/badge/x86_64-n/a-cccccc.svg?style=flat)](#) |
-| Debian | Debian  | Wheezy  | [![x86](http://img.shields.io/badge/x86-n/a-cccccc.svg?style=flat)](#) [![x86_64](http://img.shields.io/badge/x86_64-n/a-cccccc.svg?style=flat)](#) |
-| Debian | Ubuntu  | Precise | [![x86](http://img.shields.io/badge/x86-n/a-cccccc.svg?style=flat)](#) [![x86_64](http://img.shields.io/badge/x86_64-passed-006400.svg?style=flat)](#)  |
-| Debian | Ubuntu  | Trusty  | [![x86](http://img.shields.io/badge/x86-n/a-cccccc.svg?style=flat)](#) [![x86_64](http://img.shields.io/badge/x86_64-n/a-cccccc.svg?style=flat)](#) |
-| Debian | Ubuntu  | Vivid   | [![x86](http://img.shields.io/badge/x86-n/a-cccccc.svg?style=flat)](#) [![x86_64](http://img.shields.io/badge/x86_64-n/a-cccccc.svg?style=flat)](#) |
-| RedHat | CentOS  | 6.4     | [![x86](http://img.shields.io/badge/x86-n/a-cccccc.svg?style=flat)](#) [![x86_64](http://img.shields.io/badge/x86_64-n/a-cccccc.svg?style=flat)](#) |
-| RedHat | CentOS  | 6.6     | [![x86](http://img.shields.io/badge/x86-n/a-cccccc.svg?style=flat)](#) [![x86_64](http://img.shields.io/badge/x86_64-n/a-cccccc.svg?style=flat)](#) |
-| RedHat | Centos  | 7       | [![x86](http://img.shields.io/badge/x86-n/a-cccccc.svg?style=flat)](#) [![x86_64](http://img.shields.io/badge/x86_64-n/a-cccccc.svg?style=flat)](#) |
-| RedHat | Fedora  | 20      | [![x86](http://img.shields.io/badge/x86-n/a-cccccc.svg?style=flat)](#) [![x86_64](http://img.shields.io/badge/x86_64-n/a-cccccc.svg?style=flat)](#) |
-| RedHat | Fedora  | 21      | [![x86](http://img.shields.io/badge/x86-n/a-cccccc.svg?style=flat)](#) [![x86_64](http://img.shields.io/badge/x86_64-n/a-cccccc.svg?style=flat)](#) |
 
 ## Requirements
 
@@ -45,16 +32,17 @@ An [Ansible](http://www.ansible.com) role to setup the [webupd8](http://www.webu
 |:-:|:--|
 | launchpad_ppa_webupd8_os_supported | fact set by this role to determine if the host OS is supported. |
 
+
 ## Role Variables
 
-| variable | description |
-|:-:|:--|
-| launchpad_ppa_webupd8_cache_valid_time | the amount of time in seconds the apt cache is valid. |
+None.
+
 
 ## Dependencies
 
 None.
 
+
 ## Playbooks
 
 Including an example of how to use your role
@@ -65,8 +53,12 @@ is always nice for users too:
       roles:
          - { role: ansiblebit.launchpad-ppa-webupd8, launchpad_ppa_webupd8_cache_valid_time: 3600 }
 
+
 ## Changelog
 
+- v3.9.4 : 9 Sep 2015
+    - idempotence tests now pass
+    - removed launchpad_ppa_webupd8_cache_valid_time variable
 - v3.9.2 : 9 Sep 2015
     - fixed tests
 - v3.9.0 : 9 Sep 2015
@@ -100,14 +92,17 @@ is always nice for users too:
 - v1.0.0 : 4 April 2015
     - initial release
 
+
 ## Links
 
 - [WebUpd8 team : Oracle Java (JDK) 7 / 8 / 9 Installer PPA](https://launchpad.net/~webupd8team/+archive/ubuntu/java)
 
+
 ## License
 
 BSD
 
+
 ## Author Information
 
 - [steenzout](http://github.com/steenzout)

defaults/main.yml

@@ -3,5 +3,3 @@
 #
 # defaults file
 #
-
-launchpad_ppa_webupd8_cache_valid_time: 3600

tasks/main.yml

@@ -18,11 +18,3 @@
   fail:
     msg: "The operating system ({{ ansible_os_family }}) of the target machine ({{ inventory_hostname }}) is not currently supported."
   when: launchpad_ppa_webupd8_os_supported is not defined
-
-
-## generic tasks
-
-- apt:
-    update_cache=yes
-    cache_valid_time={{ launchpad_ppa_webupd8_cache_valid_time }}
-  sudo: yes

tasks/os_distribution/debian.yml

@@ -14,14 +14,14 @@
 
 - name: ensure the webupd8 launchpad apt repository is present
   apt_repository:
-    repo="deb http://ppa.launchpad.net/webupd8team/java/ubuntu trusty main"
+    repo='deb http://ppa.launchpad.net/webupd8team/java/ubuntu trusty main'
     update_cache=yes
     state=present
   sudo: yes
 
 - name: ensure the webupd8 launchpad source apt repository is present
   apt_repository:
-    repo="deb-src http://ppa.launchpad.net/webupd8team/java/ubuntu trusty main"
+    repo='deb-src http://ppa.launchpad.net/webupd8team/java/ubuntu trusty main'
     update_cache=yes
     state=present
   sudo: yes

tasks/os_distribution/ubuntu.yml

@@ -7,7 +7,7 @@
 
 - name: ensure the webupd8 launchpad apt repository is present
   apt_repository:
-    repo=ppa:webupd8team/java
+    repo='ppa:webupd8team/java'
     update_cache=yes
     state=present
   sudo: yes

tests/test.yml

@@ -6,8 +6,7 @@
   gather_facts: yes
 
   roles:
-    - ansiblebit.launchpad-ppa-webupd8
+    - launchpad-ppa-webupd8
 
     - { role: tests,
-        when: idempotence is defined and idempotence }
-
+        tags: test }

tox.ini

@@ -1,7 +1,7 @@
 [tox]
 envlist =
 #    {py27}-{ansible193,ansible184,ansible172,ansible1610,ansible155,ansible145,ansible134,ansible123}
-    {py27}-{ansible193,ansible184,ansible172}
+    {py27}-{ansible193,ansible184}
 
 skipsdist = True