Removed all Error Handling in Controller Methods

Author: MohammadIqbalAD

src/main/java/com/answerdigital/answerking/controller/CategoryController.java

@@ -14,7 +14,6 @@
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.http.HttpStatus;
 import org.springframework.http.ResponseEntity;
-import org.springframework.validation.Errors;
 import org.springframework.validation.annotation.Validated;
 import org.springframework.web.bind.annotation.PathVariable;
 import org.springframework.web.bind.annotation.RequestBody;
@@ -50,10 +49,8 @@ public CategoryController(final CategoryService categoryService) {
                 content = { @Content(mediaType = "application/json", schema = @Schema(implementation = ErrorResponse.class)) })
     })
     @PostMapping
-    public ResponseEntity<Category> addCategory(@Valid @RequestBody final AddCategoryRequest categoryRequest,
-                                                final Errors errors) {
-        return new ResponseEntity<>(categoryService.addCategory(categoryRequest),
-                                                        errors.hasErrors() ? HttpStatus.BAD_REQUEST : HttpStatus.CREATED);
+    public ResponseEntity<Category> addCategory(@Valid @RequestBody final AddCategoryRequest categoryRequest) {
+        return new ResponseEntity<>(categoryService.addCategory(categoryRequest), HttpStatus.CREATED);
     }
 
     @Operation(summary = "Get all categories.")
@@ -112,10 +109,8 @@ public ResponseEntity<Category> removeProductFromCategory(@PathVariable @NotNull
     })
     @PutMapping("/{categoryId}")
     public ResponseEntity<Category> updateCategory(@Valid @RequestBody final UpdateCategoryRequest updateCategoryRequest,
-                                                   @PathVariable @NotNull final Long categoryId,
-                                                   final Errors errors) {
-        return new ResponseEntity<>(categoryService.updateCategory(updateCategoryRequest, categoryId),
-                                                    errors.hasErrors() ? HttpStatus.BAD_REQUEST : HttpStatus.OK);
+                                                   @PathVariable @NotNull final Long categoryId) {
+        return new ResponseEntity<>(categoryService.updateCategory(updateCategoryRequest, categoryId), HttpStatus.OK);
     }
 
     @Operation(summary = "Retire an existing category.")

src/main/java/com/answerdigital/answerking/controller/OrderController.java

@@ -7,7 +7,6 @@
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.http.HttpStatus;
 import org.springframework.http.ResponseEntity;
-import org.springframework.validation.Errors;
 import org.springframework.validation.annotation.Validated;
 import org.springframework.web.bind.annotation.GetMapping;
 import org.springframework.web.bind.annotation.PostMapping;
@@ -36,9 +35,8 @@ public OrderController(final OrderService orderService) {
     }
 
     @PostMapping
-    public ResponseEntity<Order> addOrder(@Valid @RequestBody final OrderRequest orderRequest, final Errors errors) {
-        return new ResponseEntity<>(orderService.addOrder(orderRequest),
-                                            errors.hasErrors() ? HttpStatus.BAD_REQUEST : HttpStatus.CREATED);
+    public ResponseEntity<Order> addOrder(@Valid @RequestBody final OrderRequest orderRequest) {
+        return new ResponseEntity<>(orderService.addOrder(orderRequest), HttpStatus.CREATED);
     }
 
     @GetMapping(path = "/{orderId}")

src/main/java/com/answerdigital/answerking/controller/ProductController.java

@@ -13,7 +13,6 @@
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.http.HttpStatus;
 import org.springframework.http.ResponseEntity;
-import org.springframework.validation.Errors;
 import org.springframework.validation.annotation.Validated;
 import org.springframework.web.bind.annotation.DeleteMapping;
 import org.springframework.web.bind.annotation.GetMapping;
@@ -70,9 +69,8 @@ public ResponseEntity<Product> getProductById(@Valid @PathVariable @NotNull fina
             content = { @Content(mediaType = "application/json", schema = @Schema(implementation = ErrorResponse.class)) })
     })
     @PostMapping
-    public ResponseEntity<Product> addProduct(@Valid @RequestBody final ProductRequest productRequest, final Errors errors) {
-        return new ResponseEntity<>(productService.addNewProduct(productRequest),
-                                            errors.hasErrors() ? HttpStatus.BAD_REQUEST : HttpStatus.CREATED);
+    public ResponseEntity<Product> addProduct(@Valid @RequestBody final ProductRequest productRequest) {
+        return new ResponseEntity<>(productService.addNewProduct(productRequest), HttpStatus.CREATED);
     }
 
     @Operation(summary = "Update an existing product.")
@@ -86,10 +84,8 @@ public ResponseEntity<Product> addProduct(@Valid @RequestBody final ProductReque
     })
     @PutMapping("/{id}")
     public ResponseEntity<Product> updateProduct(@PathVariable @NotNull final Long id,
-                                              @Valid @RequestBody final ProductRequest productRequest,
-                                              final Errors errors) {
-        return new ResponseEntity<>(productService.updateProduct(id, productRequest),
-                                            errors.hasErrors() ? HttpStatus.BAD_REQUEST : HttpStatus.OK);
+                                              @Valid @RequestBody final ProductRequest productRequest) {
+        return new ResponseEntity<>(productService.updateProduct(id, productRequest), HttpStatus.OK);
     }
 
     @Operation(summary = "Retire an existing product.")