Merge pull request #88 from AnswerConsulting/BENCH-205

Bench 205

Author: AndyFlintAnswerDigital

src/main/java/com/answerdigital/answerking/model/Category.java

@@ -1,6 +1,5 @@
 package com.answerdigital.answerking.model;
 
-import com.answerdigital.answerking.request.AddCategoryRequest;
 import com.fasterxml.jackson.annotation.JsonIgnore;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import lombok.AllArgsConstructor;
@@ -65,16 +64,6 @@ public class Category {
     @JsonIgnore
     private Set<Product> products = new HashSet<>();
 
-    public Category(final AddCategoryRequest categoryRequest) {
-        this.name = categoryRequest.name();
-        this.description = categoryRequest.description();
-        this.createdOn = ZonedDateTime.now(ZoneOffset.UTC)
-                                      .truncatedTo( ChronoUnit.SECONDS )
-                                      .format( DateTimeFormatter.ofPattern( "yyyy-MM-dd HH:mm::ss" ) );
-        this.lastUpdated = this.createdOn;
-        this.retired = false;
-    }
-
     public Category(final String name, final String description) {
         this.name = name;
         this.description = description;

src/main/java/com/answerdigital/answerking/model/Product.java

@@ -1,6 +1,5 @@
 package com.answerdigital.answerking.model;
 
-import com.answerdigital.answerking.request.ProductRequest;
 import com.fasterxml.jackson.annotation.JsonIgnore;
 import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
 import lombok.Builder;
@@ -57,13 +56,6 @@ public class Product {
     @JsonIgnore
     private Set<LineItem> lineItems = new HashSet<>();
 
-    public Product(final ProductRequest productRequest){
-        this.name = productRequest.name();
-        this.description = productRequest.description();
-        this.price = productRequest.price();
-        this.retired = false;
-    }
-
     public Product(final String name, final String description, final BigDecimal price, final boolean isRetired) {
         this.name = name;
         this.description = description;

src/test/java/com/answerdigital/answerking/controller/CategoryControllerTest.java

@@ -66,7 +66,7 @@ void removeProductFromCategoryTest() throws Exception {
     void addCategoryTest() throws Exception {
         ObjectMapper mapper = new ObjectMapper();
         final var addCategoryRequest =  new AddCategoryRequest("random name", "random description");
-        final var category = new Category(addCategoryRequest);
+        final var category = new Category("random name", "random description");
         final var categoryRequest = "{\"name\": \"random name\",\"description\": \"random description\"}";
         final String testDate = ZonedDateTime.now( ZoneId.of( "Etc/UTC" ) )
                                             .truncatedTo( ChronoUnit.SECONDS )