Skip to content

Commit 861aa1b

Browse files
Renamed to RequestModelsOrder & RequestModelsProduct
Renamed ProductRequest to RequestModelsProduct. Renamed OrderRequest to RequestModelsOrder.
1 parent f74aabe commit 861aa1b

File tree

11 files changed

+30
-30
lines changed

11 files changed

+30
-30
lines changed

src/main/java/com/answerdigital/answerking/controller/OrderController.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package com.answerdigital.answerking.controller;
22

33
import com.answerdigital.answerking.model.Order;
4-
import com.answerdigital.answerking.request.OrderRequest;
4+
import com.answerdigital.answerking.request.RequestModelsOrder;
55
import com.answerdigital.answerking.service.OrderService;
66
import io.swagger.v3.oas.annotations.tags.Tag;
77
import org.springframework.beans.factory.annotation.Autowired;
@@ -35,7 +35,7 @@ public OrderController(final OrderService orderService) {
3535
}
3636

3737
@PostMapping
38-
public ResponseEntity<Order> addOrder(@Valid @RequestBody final OrderRequest orderRequest) {
38+
public ResponseEntity<Order> addOrder(@Valid @RequestBody final RequestModelsOrder orderRequest) {
3939
return new ResponseEntity<>(orderService.addOrder(orderRequest), HttpStatus.CREATED);
4040
}
4141

@@ -46,7 +46,7 @@ public ResponseEntity<Order> getOrder(@PathVariable @NotNull final Long orderId)
4646

4747
@PutMapping("/{orderId}")
4848
public ResponseEntity<Order> updateOrder(@PathVariable @NotNull final Long orderId,
49-
@Valid @RequestBody final OrderRequest orderRequest) {
49+
@Valid @RequestBody final RequestModelsOrder orderRequest) {
5050
return new ResponseEntity<>(orderService.updateOrder(orderId, orderRequest), HttpStatus.OK);
5151
}
5252

src/main/java/com/answerdigital/answerking/controller/ProductController.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import com.answerdigital.answerking.exception.util.ErrorResponse;
44
import com.answerdigital.answerking.model.Product;
5-
import com.answerdigital.answerking.request.ProductRequest;
5+
import com.answerdigital.answerking.request.RequestModelsProduct;
66
import com.answerdigital.answerking.service.ProductService;
77
import io.swagger.v3.oas.annotations.Operation;
88
import io.swagger.v3.oas.annotations.media.Content;
@@ -71,7 +71,7 @@ public ResponseEntity<Product> getProductById(@Valid @PathVariable @NotNull fina
7171
schema = @Schema(implementation = ErrorResponse.class)) })
7272
})
7373
@PostMapping
74-
public ResponseEntity<Product> addProduct(@Valid @RequestBody final ProductRequest productRequest) {
74+
public ResponseEntity<Product> addProduct(@Valid @RequestBody final RequestModelsProduct productRequest) {
7575
return new ResponseEntity<>(productService.addNewProduct(productRequest), HttpStatus.CREATED);
7676
}
7777

@@ -88,7 +88,7 @@ public ResponseEntity<Product> addProduct(@Valid @RequestBody final ProductReque
8888
})
8989
@PutMapping("/{id}")
9090
public ResponseEntity<Product> updateProduct(@PathVariable @NotNull final Long id,
91-
@Valid @RequestBody final ProductRequest productRequest) {
91+
@Valid @RequestBody final RequestModelsProduct productRequest) {
9292
return new ResponseEntity<>(productService.updateProduct(id, productRequest), HttpStatus.OK);
9393
}
9494

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package com.answerdigital.answerking.mapper;
22

33
import com.answerdigital.answerking.model.Order;
4-
import com.answerdigital.answerking.request.OrderRequest;
4+
import com.answerdigital.answerking.request.RequestModelsOrder;
55
import org.mapstruct.Mapper;
66
import org.mapstruct.Mapping;
77
import org.mapstruct.MappingTarget;
@@ -12,7 +12,7 @@ public interface OrderMapper {
1212

1313
@Mapping(target = "orderStatus", constant = "IN_PROGRESS")
1414
@Mapping(target = "lineItems", expression = "java(Collections.EMPTY_SET)")
15-
Order addRequestToOrder(OrderRequest orderRequest);
15+
Order addRequestToOrder(RequestModelsOrder orderRequest);
1616

17-
Order updateOrderRequest(@MappingTarget Order order, OrderRequest orderRequest);
17+
Order updateOrderRequest(@MappingTarget Order order, RequestModelsOrder orderRequest);
1818
}
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
package com.answerdigital.answerking.mapper;
22

33
import com.answerdigital.answerking.model.Product;
4-
import com.answerdigital.answerking.request.ProductRequest;
4+
import com.answerdigital.answerking.request.RequestModelsProduct;
55
import org.mapstruct.Mapper;
66
import org.mapstruct.Mapping;
77
import org.mapstruct.MappingTarget;
88

99
@Mapper(componentModel = "spring")
1010
public interface ProductMapper {
1111
@Mapping(target = "retired", constant = "false")
12-
Product addRequestToProduct(ProductRequest productRequest);
12+
Product addRequestToProduct(RequestModelsProduct productRequest);
1313

14-
Product updateRequestToProduct(@MappingTarget Product product, ProductRequest productRequest);
14+
Product updateRequestToProduct(@MappingTarget Product product, RequestModelsProduct productRequest);
1515
}

src/main/java/com/answerdigital/answerking/model/Product.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.answerdigital.answerking.model;
22

3-
import com.answerdigital.answerking.request.ProductRequest;
3+
import com.answerdigital.answerking.request.RequestModelsProduct;
44
import com.fasterxml.jackson.annotation.JsonIgnore;
55
import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
66
import com.fasterxml.jackson.annotation.JsonProperty;
@@ -60,7 +60,7 @@ public class Product {
6060
@JsonIgnore
6161
private Set<LineItem> lineItems = new HashSet<>();
6262

63-
public Product(final ProductRequest productRequest){
63+
public Product(final RequestModelsProduct productRequest){
6464
this.name = productRequest.name();
6565
this.description = productRequest.description();
6666
this.price = productRequest.price();

src/main/java/com/answerdigital/answerking/request/OrderRequest.java renamed to src/main/java/com/answerdigital/answerking/request/RequestModelsOrder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22

33
import javax.validation.constraints.NotBlank;
44

5-
public record OrderRequest(@NotBlank String address) {
5+
public record RequestModelsOrder(@NotBlank String address) {
66
}

src/main/java/com/answerdigital/answerking/request/ProductRequest.java renamed to src/main/java/com/answerdigital/answerking/request/RequestModelsProduct.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import javax.validation.constraints.NotNull;
1010
import java.math.BigDecimal;
1111

12-
public record ProductRequest(
12+
public record RequestModelsProduct(
1313
@NotBlank
1414
@Pattern(regexp = "^[a-zA-Z\s-]*",
1515
message = "Product name must only contain letters, spaces and dashes")
@@ -25,6 +25,6 @@ public record ProductRequest(
2525
BigDecimal price
2626
) {
2727
@Builder
28-
public ProductRequest {
28+
public RequestModelsProduct {
2929
}
3030
}

src/main/java/com/answerdigital/answerking/service/OrderService.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import com.answerdigital.answerking.model.Product;
99
import com.answerdigital.answerking.model.Order;
1010
import com.answerdigital.answerking.repository.OrderRepository;
11-
import com.answerdigital.answerking.request.OrderRequest;
11+
import com.answerdigital.answerking.request.RequestModelsOrder;
1212
import org.mapstruct.factory.Mappers;
1313
import org.springframework.beans.factory.annotation.Autowired;
1414
import org.springframework.stereotype.Service;
@@ -32,7 +32,7 @@ public OrderService(final OrderRepository orderRepository, final ProductService
3232
this.productService = productService;
3333
}
3434

35-
public Order addOrder(final OrderRequest orderRequest) {
35+
public Order addOrder(final RequestModelsOrder orderRequest) {
3636
final Order newOrder = orderMapper.addRequestToOrder(orderRequest);
3737
return orderRepository.save(newOrder);
3838
}
@@ -48,7 +48,7 @@ public List<Order> findAll() {
4848
return this.orderRepository.findAll();
4949
}
5050

51-
public Order updateOrder(final Long orderId, final OrderRequest orderRequest) {
51+
public Order updateOrder(final Long orderId, final RequestModelsOrder orderRequest) {
5252
final Order orderToUpdate = findById(orderId);
5353
final Order updatedOrder = orderMapper.updateOrderRequest(orderToUpdate, orderRequest);
5454

src/main/java/com/answerdigital/answerking/service/ProductService.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import com.answerdigital.answerking.mapper.ProductMapper;
77
import com.answerdigital.answerking.model.Product;
88
import com.answerdigital.answerking.repository.ProductRepository;
9-
import com.answerdigital.answerking.request.ProductRequest;
9+
import com.answerdigital.answerking.request.RequestModelsProduct;
1010
import org.mapstruct.factory.Mappers;
1111
import org.springframework.beans.factory.annotation.Autowired;
1212
import org.springframework.stereotype.Service;
@@ -24,7 +24,7 @@ public ProductService(final ProductRepository productRepository) {
2424
this.productRepository = productRepository;
2525
}
2626

27-
public Product addNewProduct(final ProductRequest productRequest) {
27+
public Product addNewProduct(final RequestModelsProduct productRequest) {
2828
if (productRepository.existsByName(productRequest.name())) {
2929
throw new NameUnavailableException(String.format("A Product named '%s' already exists", productRequest.name()));
3030
}
@@ -42,7 +42,7 @@ public List<Product> findAll() {
4242
return productRepository.findAll();
4343
}
4444

45-
public Product updateProduct(final Long productId, final ProductRequest productRequest) {
45+
public Product updateProduct(final Long productId, final RequestModelsProduct productRequest) {
4646
productRepository.findById(productId)
4747
.orElseThrow(() -> new NotFoundException(String.format("Product with ID %d does not exist.", productId)));
4848

src/test/java/com/answerdigital/answerking/service/OrderServiceTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
import java.util.Optional;
1515
import java.util.Set;
1616

17-
import com.answerdigital.answerking.request.OrderRequest;
17+
import com.answerdigital.answerking.request.RequestModelsOrder;
1818
import org.junit.jupiter.api.Test;
1919
import org.junit.jupiter.api.extension.ExtendWith;
2020
import org.mockito.InjectMocks;
@@ -52,7 +52,7 @@ class OrderServiceTest {
5252
@Test
5353
void testAddOrderReturnsSavedOrder() {
5454
// Given
55-
OrderRequest orderRequest = new OrderRequest("42 Main St");
55+
RequestModelsOrder orderRequest = new RequestModelsOrder("42 Main St");
5656
Order expectedResult = Order.builder()
5757
.address("42 Main Street")
5858
.build();
@@ -136,7 +136,7 @@ void testFindAllReturnsListOfOrders() {
136136
void testUpdateOrder() {
137137
// Given
138138
Order originalOrder = new Order("14 Main St");
139-
OrderRequest updateOrderRequest = new OrderRequest("14 Green Street");
139+
RequestModelsOrder updateOrderRequest = new RequestModelsOrder("14 Green Street");
140140
Order expectedOrder = new Order("14 Green Street");
141141

142142
// When
@@ -156,7 +156,7 @@ void testUpdateOrder() {
156156
@Test
157157
void testUpdateOrderWhenOrderNotExistsThrowsNotFoundException() {
158158
// Given
159-
OrderRequest orderRequest = new OrderRequest("14 High St");
159+
RequestModelsOrder orderRequest = new RequestModelsOrder("14 High St");
160160

161161
// Then
162162
assertThrows(NotFoundException.class, () ->

0 commit comments

Comments
 (0)