BENCH-231 added final to TestBuilder constructor parameters

Author: AndyFlintAnswerDigital

src/test/java/com/answerdigital/answerking/builder/AddCategoryRequestTestBuilder.java

@@ -13,12 +13,12 @@ public AddCategoryRequestTestBuilder withDefaultValues() {
         return this;
     }
 
-    public AddCategoryRequestTestBuilder withName(String name) {
+    public AddCategoryRequestTestBuilder withName(final String name) {
         this.name = name;
         return this;
     }
 
-    public AddCategoryRequestTestBuilder withDescription(String description) {
+    public AddCategoryRequestTestBuilder withDescription(final String description) {
         this.description = description;
         return this;
     }

src/test/java/com/answerdigital/answerking/builder/CategoryTestBuilder.java

@@ -29,45 +29,43 @@ public CategoryTestBuilder withDefaultValues() {
         return this;
     }
 
-    public CategoryTestBuilder withId(Long id) {
+    public CategoryTestBuilder withId(final Long id) {
         this.id = id;
         return this;
     }
 
-    public CategoryTestBuilder withName(String name) {
+    public CategoryTestBuilder withName(final String name) {
         this.name = name;
         return this;
     }
 
-    public CategoryTestBuilder withDescription(String description) {
+    public CategoryTestBuilder withDescription(final String description) {
         this.description = description;
         return this;
     }
 
-    public CategoryTestBuilder withCreatedOn(String createdOn) {
+    public CategoryTestBuilder withCreatedOn(final String createdOn) {
         this.createdOn = createdOn;
         return this;
     }
 
-    public CategoryTestBuilder withLastUpdated(String lastUpdated) {
+    public CategoryTestBuilder withLastUpdated(final String lastUpdated) {
         this.lastUpdated = lastUpdated;
         return this;
     }
 
-    public CategoryTestBuilder withRetired(boolean retired) {
+    public CategoryTestBuilder withRetired(final boolean retired) {
         this.retired = retired;
         return this;
     }
 
-    public CategoryTestBuilder withProducts(Set<Product> products) {
+    public CategoryTestBuilder withProducts(final Set<Product> products) {
         this.products = products;
         return this;
     }
 
-    public CategoryTestBuilder withProduct(Product product) {
-        Set<Product> products = new HashSet<>();
+    public CategoryTestBuilder withProduct(final Product product) {
         products.add(product);
-        this.products = products;
         return this;
     }
 

src/test/java/com/answerdigital/answerking/builder/ProductTestBuilder.java

@@ -29,37 +29,37 @@ public ProductTestBuilder withDefaultValues() {
         return this;
     }
 
-    public ProductTestBuilder withId(Long id) {
+    public ProductTestBuilder withId(final Long id) {
         this.id = id;
         return this;
     }
 
-    public ProductTestBuilder withName(String name) {
+    public ProductTestBuilder withName(final String name) {
         this.name = name;
         return this;
     }
 
-    public ProductTestBuilder withDescription(String description) {
+    public ProductTestBuilder withDescription(final String description) {
         this.description = description;
         return this;
     }
 
-    public ProductTestBuilder withPrice(BigDecimal price) {
+    public ProductTestBuilder withPrice(final BigDecimal price) {
         this.price = price;
         return this;
     }
 
-    public ProductTestBuilder withRetired(boolean retired) {
+    public ProductTestBuilder withRetired(final boolean retired) {
         this.retired = retired;
         return this;
     }
 
-    public ProductTestBuilder withCategories(Set<Category> categories) {
+    public ProductTestBuilder withCategories(final Set<Category> categories) {
         this.categories = categories;
         return this;
     }
 
-    public ProductTestBuilder withLineItems(Set<LineItem> lineItems) {
+    public ProductTestBuilder withLineItems(final Set<LineItem> lineItems) {
         this.lineItems = lineItems;
         return this;
     }

src/test/java/com/answerdigital/answerking/builder/UpdateCategoryRequestTestBuilder.java

@@ -13,12 +13,12 @@ public UpdateCategoryRequestTestBuilder withDefaultValues() {
         return this;
     }
 
-    public UpdateCategoryRequestTestBuilder withName(String name) {
+    public UpdateCategoryRequestTestBuilder withName(final String name) {
         this.name = name;
         return this;
     }
 
-    public UpdateCategoryRequestTestBuilder withDescription(String description) {
+    public UpdateCategoryRequestTestBuilder withDescription(final String description) {
         this.description = description;
         return this;
     }