Skip to content

Commit a7f346f

Browse files
committed
BENCH-195 conflicts resolved
1 parent 15ab79b commit a7f346f

File tree

3 files changed

+15
-14
lines changed

3 files changed

+15
-14
lines changed

src/test/java/com/answerdigital/answerking/builder/AddCategoryRequestTestBuilder.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.answerdigital.answerking.builder;
22

3-
import com.answerdigital.answerking.request.AddCategoryRequest;
3+
import com.answerdigital.answerking.request.CategoryRequest;
44

55
public class AddCategoryRequestTestBuilder {
66

@@ -23,7 +23,7 @@ public AddCategoryRequestTestBuilder withDescription(final String description) {
2323
return this;
2424
}
2525

26-
public AddCategoryRequest build() {
27-
return new AddCategoryRequest(name, description);
26+
public CategoryRequest build() {
27+
return new CategoryRequest(name, description);
2828
}
2929
}

src/test/java/com/answerdigital/answerking/builder/UpdateCategoryRequestTestBuilder.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.answerdigital.answerking.builder;
22

3-
import com.answerdigital.answerking.request.UpdateCategoryRequest;
3+
import com.answerdigital.answerking.request.CategoryRequest;
44

55
public class UpdateCategoryRequestTestBuilder {
66

@@ -23,7 +23,7 @@ public UpdateCategoryRequestTestBuilder withDescription(final String description
2323
return this;
2424
}
2525

26-
public UpdateCategoryRequest build() {
27-
return new UpdateCategoryRequest(name, description);
26+
public CategoryRequest build() {
27+
return new CategoryRequest(name, description);
2828
}
2929
}

src/test/java/com/answerdigital/answerking/service/CategoryServiceTest.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
import com.answerdigital.answerking.model.Product;
1313
import com.answerdigital.answerking.repository.CategoryRepository;
1414
import com.answerdigital.answerking.request.CategoryRequest;
15-
1615
import com.answerdigital.answerking.response.CategoryResponse;
1716
import org.junit.jupiter.api.AfterEach;
1817
import org.junit.jupiter.api.BeforeEach;
@@ -21,10 +20,12 @@
2120
import org.mockito.Mock;
2221
import org.mockito.junit.jupiter.MockitoExtension;
2322

24-
import java.util.HashSet;
2523
import java.util.Optional;
2624

27-
import static org.junit.jupiter.api.Assertions.*;
25+
import static org.junit.jupiter.api.Assertions.assertAll;
26+
import static org.junit.jupiter.api.Assertions.assertEquals;
27+
import static org.junit.jupiter.api.Assertions.assertFalse;
28+
import static org.junit.jupiter.api.Assertions.assertThrows;
2829
import static org.mockito.ArgumentMatchers.anyLong;
2930
import static org.mockito.ArgumentMatchers.anyString;
3031
import static org.mockito.Mockito.any;
@@ -72,7 +73,7 @@ void tearDown() {
7273
@Test
7374
void testAddCategory() {
7475
// given
75-
final AddCategoryRequest addCategoryRequest = addCategoryRequestTestBuilder.withDefaultValues().build();
76+
final CategoryRequest addCategoryRequest = addCategoryRequestTestBuilder.withDefaultValues().build();
7677
final Category expectedResponse = categoryTestBuilder.withDefaultValues().build();
7778

7879
// when
@@ -93,7 +94,7 @@ void testAddCategory() {
9394
@Test
9495
void testAddCategoryThatAlreadyExists() {
9596
// given
96-
final AddCategoryRequest addCategoryRequest = addCategoryRequestTestBuilder.withDefaultValues().build();
97+
final CategoryRequest addCategoryRequest = addCategoryRequestTestBuilder.withDefaultValues().build();
9798

9899
// when
99100
doReturn(true).when(categoryRepository).existsByName(anyString());
@@ -109,7 +110,7 @@ void testAddCategoryThatAlreadyExists() {
109110
void testUpdateCategory() {
110111
// given
111112
final Category existingCategory = categoryTestBuilder.withDefaultValues().build();
112-
final UpdateCategoryRequest updateCategoryRequest = updateCategoryRequestTestBuilder.withDefaultValues().build();
113+
final CategoryRequest updateCategoryRequest = updateCategoryRequestTestBuilder.withDefaultValues().build();
113114
final Category expectedResponse = categoryTestBuilder
114115
.withDefaultValues()
115116
.withName(updateCategoryRequest.name())
@@ -133,7 +134,7 @@ void testUpdateCategory() {
133134
@Test
134135
void testUpdateCategoryThatDoesNotExist() {
135136
// given
136-
final UpdateCategoryRequest updateCategoryRequest = updateCategoryRequestTestBuilder.withDefaultValues().build();
137+
final CategoryRequest updateCategoryRequest = updateCategoryRequestTestBuilder.withDefaultValues().build();
137138

138139
// when
139140
doReturn(false).when(categoryRepository).existsByNameAndIdIsNot(anyString(), anyLong());
@@ -151,7 +152,7 @@ void testUpdateCategoryThatDoesNotExist() {
151152
void testUpdateCategoryNameToCategoryThatAlreadyExists() {
152153
// given
153154
final Category existingCategory = categoryTestBuilder.withDefaultValues().build();
154-
final UpdateCategoryRequest updateCategoryRequest = updateCategoryRequestTestBuilder.withDefaultValues().build();
155+
final CategoryRequest updateCategoryRequest = updateCategoryRequestTestBuilder.withDefaultValues().build();
155156

156157
// when
157158
doReturn(true).when(categoryRepository).existsByNameAndIdIsNot(anyString(), anyLong());

0 commit comments

Comments
 (0)