Skip to content

Commit e4bf7cd

Browse files
committed
BENCH-195 redundant constructors removed
1 parent c641ce7 commit e4bf7cd

File tree

2 files changed

+4
-19
lines changed

2 files changed

+4
-19
lines changed

src/main/java/com/answerdigital/answerking/model/Category.java

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
11
package com.answerdigital.answerking.model;
22

3-
import com.answerdigital.answerking.request.CategoryRequest;
43
import com.fasterxml.jackson.annotation.JsonIgnore;
54
import com.fasterxml.jackson.annotation.JsonProperty;
5+
import lombok.AccessLevel;
66
import lombok.AllArgsConstructor;
77
import lombok.Builder;
88
import lombok.Getter;
9-
import lombok.Setter;
109
import lombok.NoArgsConstructor;
11-
import lombok.AccessLevel;
10+
import lombok.Setter;
1211

1312
import javax.persistence.Entity;
1413
import javax.persistence.FetchType;
@@ -65,12 +64,6 @@ public class Category {
6564
@JsonIgnore
6665
private Set<Product> products = new HashSet<>();
6766

68-
public Category(final CategoryRequest categoryRequest) {
69-
this.name = categoryRequest.name();
70-
this.description = categoryRequest.description();
71-
this.retired = false;
72-
}
73-
7467
public Category(final String name, final String description) {
7568
this.name = name;
7669
this.description = description;

src/main/java/com/answerdigital/answerking/model/Product.java

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,14 @@
11
package com.answerdigital.answerking.model;
22

3-
import com.answerdigital.answerking.request.ProductRequest;
43
import com.fasterxml.jackson.annotation.JsonIgnore;
54
import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
65
import com.fasterxml.jackson.annotation.JsonProperty;
6+
import lombok.AccessLevel;
7+
import lombok.AllArgsConstructor;
78
import lombok.Builder;
89
import lombok.Getter;
910
import lombok.NoArgsConstructor;
1011
import lombok.Setter;
11-
import lombok.AccessLevel;
12-
import lombok.AllArgsConstructor;
1312

1413
import javax.persistence.CascadeType;
1514
import javax.persistence.Column;
@@ -60,13 +59,6 @@ public class Product {
6059
@JsonIgnore
6160
private Set<LineItem> lineItems = new HashSet<>();
6261

63-
public Product(final ProductRequest productRequest){
64-
this.name = productRequest.name();
65-
this.description = productRequest.description();
66-
this.price = productRequest.price();
67-
this.retired = false;
68-
}
69-
7062
public Product(final String name, final String description, final BigDecimal price, final boolean isRetired) {
7163
this.name = name;
7264
this.description = description;

0 commit comments

Comments
 (0)