BENCH-182 comments raised ahs been resolved

Author: AudriusPutys

src/main/java/com/answerdigital/answerking/response/SimpleCategoryResponse.java

@@ -1,6 +1,5 @@
 package com.answerdigital.answerking.response;
 
-import com.fasterxml.jackson.annotation.JsonProperty;
 import lombok.AllArgsConstructor;
 import lombok.Builder;
 import lombok.Data;
@@ -12,7 +11,6 @@
 @AllArgsConstructor
 public class SimpleCategoryResponse {
 
-    @JsonProperty(access = JsonProperty.Access.READ_ONLY)
     private Long id;
 
     private String name;

src/main/java/com/answerdigital/answerking/service/OrderService.java

@@ -46,8 +46,7 @@ public OrderService(final OrderRepository orderRepository, final ProductService
      */
     @Transactional
     public OrderResponse addOrder(final OrderRequest orderRequest) {
-        final Order order = new Order();
-        addLineItemsToOrder(order, orderRequest.lineItemRequests());
+        final Order order = addLineItemsToOrder(new Order(), orderRequest.lineItemRequests());
         return convertToResponse(orderRepository.save(order));
     }
 
@@ -80,17 +79,17 @@ public List<OrderResponse> findAll() {
     public OrderResponse updateOrder(final Long orderId, final OrderRequest orderRequest) {
         final Order order = getOrderById(orderId);
 
-        if(order.getOrderStatus().equals(OrderStatus.CANCELLED)) {
+        if (OrderStatus.CANCELLED.equals(order.getOrderStatus())) {
             throw new OrderCancelledException(
-                String.format("The order with ID %d has been cancelled, not possible to update", orderId)
+                    String.format("The order with ID %d has been cancelled, not possible to update", orderId)
             );
         }
 
         addLineItemsToOrder(order, orderRequest.lineItemRequests());
         return convertToResponse(orderRepository.save(order));
     }
 
-    private void addLineItemsToOrder(final Order order, final List<LineItemRequest> lineItemRequests) {
+    private Order addLineItemsToOrder(final Order order, final List<LineItemRequest> lineItemRequests) {
         // get line items id list
         final List<Long> lineItemProductIds = lineItemRequests.stream()
                 .map(LineItemRequest::productId)
@@ -105,6 +104,7 @@ private void addLineItemsToOrder(final Order order, final List<LineItemRequest>
 
         // add line items to the order.
         lineItems.forEach((k, v) -> order.addLineItem(new LineItem(order, k, v)));
+        return order;
     }
 
     private List<Product> getUnRetiredProductsListFromDatabase(final List<Long> productIdsList){