Merge pull request #78 from AnswerConsulting/BENCH-162

BENCH-162 UPDATED STATUS CODES TO ALIGN WITH OPEN API

Author: martintaylor1635

src/main/java/com/answerdigital/answerking/controller/CategoryController.java

@@ -45,7 +45,7 @@ public CategoryController(final CategoryService categoryService) {
     public ResponseEntity<Category> addCategory(@Valid @RequestBody final AddCategoryRequest categoryRequest,
                                                 final Errors errors) {
         return new ResponseEntity<>(categoryService.addCategory(categoryRequest),
-                                                        errors.hasErrors() ? HttpStatus.BAD_REQUEST : HttpStatus.OK);
+                                                        errors.hasErrors() ? HttpStatus.BAD_REQUEST : HttpStatus.CREATED);
     }
 
     @Operation(summary = "Get all categories.")

src/main/java/com/answerdigital/answerking/controller/ProductController.java

@@ -48,7 +48,7 @@ public ResponseEntity<Product> getProductById(@Valid @PathVariable @NotNull fina
     @PostMapping
     public ResponseEntity<Product> addProduct(@Valid @RequestBody final ProductRequest productRequest, final Errors errors) {
         return new ResponseEntity<>(productService.addNewProduct(productRequest),
-                                            errors.hasErrors() ? HttpStatus.BAD_REQUEST : HttpStatus.OK);
+                                            errors.hasErrors() ? HttpStatus.BAD_REQUEST : HttpStatus.CREATED);
     }
 
     @PutMapping("/{id}")

src/test/java/com/answerdigital/answerking/controller/CategoryControllerTest.java

@@ -68,7 +68,7 @@ void addCategoryTest() throws Exception {
         final var response = mvc.perform(post("/categories")
                         .content(categoryRequest)
                         .contentType(MediaType.APPLICATION_JSON))
-                        .andExpect(status().isOk())
+                        .andExpect(status().isCreated())
                         .andReturn()
                         .getResponse();
         final var resultJsonNode = mapper.readTree(response.getContentAsString());

src/test/java/com/answerdigital/answerking/controller/ProductControllerTest.java

@@ -136,7 +136,7 @@ void addProductWithValidObjectReturnsProductAndOkStatus() throws Exception {
                 .content(newProduct)
                 .contentType(MediaType.APPLICATION_JSON));
         //then
-        actualPerformResult.andExpect(status().isOk());
+        actualPerformResult.andExpect(status().isCreated());
         ObjectMapper mapper = new ObjectMapper();
         assertEquals(mapper.readTree(newProduct).get("name"), mapper.readTree(actualPerformResult.andReturn()
                 .getResponse().getContentAsString()).get("name"));