Skip to content

Commit 2bc8286

Browse files
authored
Simplify message block logic
Don't need a switch statement for these cases
1 parent 55e720a commit 2bc8286

File tree

1 file changed

+6
-14
lines changed

1 file changed

+6
-14
lines changed

index.js

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -23,20 +23,12 @@ function buildMessage(event) {
2323
messageBlock.accessory.alt_text = `${user.login} on GitHub`;
2424
messageBlock.text.text = `*<${user.html_url}|${user.login}>* `;
2525

26-
switch (event.action) {
27-
case 'member_added':
28-
case 'added':
29-
messageBlock.text.text += 'was added to ' + type;
30-
break;
31-
32-
case 'member_removed':
33-
case 'removed':
34-
if (user.login == event.sender.login) {
35-
messageBlock.text.text += 'removed themselves from ' + type;
36-
} else {
37-
messageBlock.text.text += 'was removed from ' + type;
38-
}
39-
break;
26+
if (event.action.includes('added')) {
27+
messageBlock.text.text += 'was added to ' + type;
28+
} else if (user.login == event.sender.login) {
29+
messageBlock.text.text += 'removed themselves from ' + type;
30+
} else {
31+
messageBlock.text.text += 'was removed from ' + type;
4032
}
4133

4234
if (user.login != event.sender.login) {

0 commit comments

Comments
 (0)