-
Notifications
You must be signed in to change notification settings - Fork 8
feat: migrate the builds system to stb #639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The towncrier template has been successfully rewritten with the default template. |
jorgepiloto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left some comments regarding Node.js and the build system versions.
| requires = [ | ||
| "sphinx-theme-builder @ https://github.com/pradyunsg/sphinx-theme-builder/archive/87214d0671c943992c05e3db01dca997e156e8d6.zip", | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for this particular commit? Why not pointing to the latest stable version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I initially encountered an infinite loop while testing with another package, possibly due to an oversight when adapting from PyData. I'll test the latest release again and make the necessary adjustments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this going to prevent us from releasing? I know PyPI doesn't like links to repositories as dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i updated to latest version, working with my tox env, (may be issue is only with nox env)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate more about this issue, @Revathyvenugopal162?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, STB can run the docs live using the command stb serve doc/source/ --open-browser. However, I encountered an issue where it was stuck in an infinite loop, preventing the browser from opening and running it properly. I referred to other themes and noticed they were using a specific commit. After testing with Tox, it worked fine, so the issue might be related to my environment or possibly the Nox environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i will open another PR to add docs-preview in tox env, but the issue persists when using Sphinx-Gallery with build_example = True, causing the docs to enter an infinite loop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR : #642
…-sphinx-theme into maint/change-builder
Co-authored-by: Roberto Pastor Muela <[email protected]>
jorgepiloto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super cool! Thanks, @Revathyvenugopal162.
fix #634