Skip to content

Conversation

@Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Mar 7, 2025

PR Description

1. Post CSS Hooks and Configuration Files:

  • Added PostCSS hooks in the configuration to integrate SCSS files smoothly.
  • Updated conf.py to link the newly created SCSS files instead of the CSS files, ensuring proper styling.

closes #640

Reason

Reason:

  • PostCSS allows for better automation, such as autoprefixing and minification of CSS, ensuring styles are processed consistently.

2. Converting All CSS to SCSS Files:

  • Converted CSS files to SCSS for better structure, organization, and maintainability.
  • SCSS allows the use of variables, mixins, and nesting, which improves code readability and reusability.

3. Renaming All References to CSS Files:

  • Renamed all references to CSS files in __init__.py to match the new SCSS structure.

4. Converting Pixels to REM:

  • Converted all pixel-based measurements to REM units for better scalability and responsiveness.
  • For example, 16px was converted to 1rem (assuming a 16px root font size).
Reason and benefits

Reason:

  • REM units are relative to the root element’s font size, which allows for more flexible and responsive scaling across different devices and user settings.

Benefits:

  • Ensures scalability and consistency throughout the design, especially in responsive layouts and improved accessibility.

Important

I didn’t convert the ast-variables.scss and pydata-theme-custom.scss files to SCSS format in this PR because they are large files that I would like to test separately. It's crucial to ensure no details are missed during the conversion, as these files contain most of the theme modifications. I will handle the conversion in a separate PR later.

@github-actions github-actions bot added the fix Pull requests related to resolving problems or errors label Mar 7, 2025
@github-actions github-actions bot added the ci Pipelines maintenance related label Mar 7, 2025
@github-actions github-actions bot added the css Requires or modifies cascading style sheets label Mar 10, 2025
@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review March 13, 2025 11:15
@Revathyvenugopal162 Revathyvenugopal162 requested a review from a team as a code owner March 13, 2025 11:15
@Revathyvenugopal162 Revathyvenugopal162 added the enhancement General improvements to existing features label Mar 13, 2025
@Revathyvenugopal162 Revathyvenugopal162 self-assigned this Mar 13, 2025
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, @Revathyvenugopal162. We should use SCSS variables but let's do that in a separate pull-request. Thanks!

@Revathyvenugopal162 Revathyvenugopal162 merged commit 3effe7b into main Mar 17, 2025
23 checks passed
@Revathyvenugopal162 Revathyvenugopal162 deleted the fix/add-scss branch March 17, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Pipelines maintenance related css Requires or modifies cascading style sheets enhancement General improvements to existing features fix Pull requests related to resolving problems or errors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate CSS Files to SCSS and Integrate PostCSS

4 participants