-
Notifications
You must be signed in to change notification settings - Fork 8
feat: migrate css to scss #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgepiloto
reviewed
Mar 7, 2025
jorgepiloto
reviewed
Mar 7, 2025
Co-authored-by: Jorge Martínez <[email protected]>
…theme into fix/add-scss
jorgepiloto
reviewed
Mar 11, 2025
jorgepiloto
reviewed
Mar 11, 2025
jorgepiloto
approved these changes
Mar 17, 2025
Member
jorgepiloto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this, @Revathyvenugopal162. We should use SCSS variables but let's do that in a separate pull-request. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci
Pipelines maintenance related
css
Requires or modifies cascading style sheets
enhancement
General improvements to existing features
fix
Pull requests related to resolving problems or errors
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
1. Post CSS Hooks and Configuration Files:
conf.pyto link the newly created SCSS files instead of the CSS files, ensuring proper styling.closes #640
Reason
Reason:
2. Converting All CSS to SCSS Files:
3. Renaming All References to CSS Files:
__init__.pyto match the new SCSS structure.4. Converting Pixels to REM:
16pxwas converted to1rem(assuming a 16px root font size).Reason and benefits
Reason:
Benefits:
Important
I didn’t convert the ast-variables.scss and pydata-theme-custom.scss files to SCSS format in this PR because they are large files that I would like to test separately. It's crucial to ensure no details are missed during the conversion, as these files contain most of the theme modifications. I will handle the conversion in a separate PR later.