test: Improve example_download tests

Author: AlejandroFernandezLuces

.gitignore

@@ -176,4 +176,5 @@ cython_debug/
 ._build
 
 doc/source/api
-.cov
+.cov
+not_a_dir

src/ansys/tools/common/example_download.py

@@ -99,12 +99,12 @@ def download_file(
         destination_path = Path(destination) if destination is not None else None
 
         # If destination is not a dir, create it
-        if destination_path is not None and not destination_path.is_dir():
+        if destination_path is not None and not destination_path.exists():
             destination_path.mkdir(parents=True, exist_ok=True)
 
-        # Check if it was able to create the dir
+        # Check if it was able to create the dir, very rare case
         if destination_path is not None and not destination_path.is_dir():
-            raise ValueError("Destination directory provided does not exist")
+            raise ValueError("Destination directory provided does not exist")  # pragma: no cover
 
         url = self._get_filepath_on_default_server(filename, directory)
         local_path = self._retrieve_data(url, filename, dest=destination, force=force)
@@ -125,7 +125,8 @@ def _add_file(self, file_path: str):
         file_path : str
             Local path of the downloaded example file.
         """
-        self._downloads_list.append(file_path)
+        if file_path not in self._downloads_list:
+            self._downloads_list.append(file_path)
 
     def _joinurl(self, base: str, directory: str) -> str:
         """Join multiple paths to a base URL.
@@ -185,10 +186,11 @@ def _retrieve_data(self, url: str, filename: str, dest: str = None, force: bool
         str
             The local path where the file was saved.
         """
+        local_path = ""
         if dest is None:
             dest = tempfile.gettempdir()  # Use system temp directory if no destination is provided
             local_path = Path(dest) / Path(filename).name
-        if not force and Path.is_file(local_path):
+        if not force and Path.is_file(Path(local_path)):
             return local_path
         try:
             local_path, _ = urllib.request.urlretrieve(url, filename=local_path)

tests/test_example_download.py

@@ -38,6 +38,11 @@ def test_download():
 
     assert Path.is_file(local_path)
 
+    # Check that file is cached
+    local_path2 = download_manager.download_file(filename, directory)
+
+    assert local_path2 == local_path
+
     download_manager.clear_download_cache()
 
     assert not Path.is_file(local_path)
@@ -68,11 +73,16 @@ def test_get_filepath():
 
     assert filepath == "https://github.com/ansys/example-data/raw/main/pymapdl/cfx_mapping/11_blades_mode_1_ND_0.csv"
 
+    filepath = download_manager._get_filepath_on_default_server(filename)
+
+    assert filepath == "https://github.com/ansys/example-data/raw/main/11_blades_mode_1_ND_0.csv"
+
 
 def test_destination_directory():
     """Test getting the destination directory for a downloaded file."""
     filename = "11_blades_mode_1_ND_0.csv"
     directory = "pymapdl/cfx_mapping"
 
-    # Get the destination directory
+    # Test directory gets created
     result = download_manager.download_file(filename, directory, destination="not_a_dir")
+    assert result is not None