Merge branch 'main' into maint/v0.6.0-changelog

AlejandroFernandezLuces · web-flow · commit ccbfcb6a2fb4 · 2024-12-12T12:36:07.000+01:00
diff --git a/.github/workflows/ci_cd.yml b/.github/workflows/ci_cd.yml
@@ -72,7 +72,7 @@ jobs:
     needs: [docs-style]
     steps:
     - name: Setup headless display
-      uses: pyvista/setup-headless-display-action@v2
+      uses: pyvista/setup-headless-display-action@v3
 
     - name: "Run Ansys documentation building action"
       uses: ansys/actions/doc-build@v8
@@ -105,8 +105,6 @@ jobs:
     needs: [ smoke-tests ]
     runs-on: ubuntu-latest
     steps:
-      - name: Install system dependencies
-        run: sudo apt install libegl1 libxcb-cursor0 libsm6 libxext6 libxcb-xinerama0 -y
       - name: Restore images cache
         uses: actions/cache@v4
         with:
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -29,12 +29,12 @@ repos:
 
 # this validates our github workflow files
 - repo: https://github.com/python-jsonschema/check-jsonschema
-  rev: 0.29.4
+  rev: 0.30.0
   hooks:
     - id: check-github-workflows
 
 - repo: https://github.com/astral-sh/ruff-pre-commit
-  rev: v0.8.0
+  rev: v0.8.2
   hooks:
     - id: ruff
       args: [--fix]
diff --git a/doc/changelog.d/197.dependencies.md b/doc/changelog.d/197.dependencies.md
@@ -0,0 +1 @@
+build(deps): bump ansys-fluent-core from 0.26.1 to 0.27.0 in the general-dependencies group
diff --git a/doc/changelog.d/198.dependencies.md b/doc/changelog.d/198.dependencies.md
@@ -0,0 +1 @@
+build(deps): bump pytest from 8.3.3 to 8.3.4 in the test-dependencies group
diff --git a/doc/changelog.d/199.dependencies.md b/doc/changelog.d/199.dependencies.md
@@ -0,0 +1 @@
+build(deps): bump sphinx-autoapi from 3.3.3 to 3.4.0 in the doc-dependencies group
diff --git a/doc/changelog.d/200.dependencies.md b/doc/changelog.d/200.dependencies.md
@@ -0,0 +1 @@
+build(deps): bump pyvista/setup-headless-display-action from 2 to 3
diff --git a/doc/changelog.d/201.maintenance.md b/doc/changelog.d/201.maintenance.md
@@ -0,0 +1 @@
+[pre-commit.ci] pre-commit autoupdate
diff --git a/doc/changelog.d/203.dependencies.md b/doc/changelog.d/203.dependencies.md
@@ -0,0 +1 @@
+build(deps): bump pyside6 from 6.8.0.2 to 6.8.1 in the general-dependencies group
diff --git a/doc/changelog.d/204.dependencies.md b/doc/changelog.d/204.dependencies.md
@@ -0,0 +1 @@
+build(deps): bump ansys-sphinx-theme from 1.2.2 to 1.2.3 in the doc-dependencies group
diff --git a/doc/changelog.d/205.maintenance.md b/doc/changelog.d/205.maintenance.md
@@ -0,0 +1 @@
+[pre-commit.ci] pre-commit autoupdate
diff --git a/doc/changelog.d/207.fixed.md b/doc/changelog.d/207.fixed.md
@@ -0,0 +1 @@
+fix: avoid passing twice same argument
diff --git a/doc/changelog.d/209.fixed.md b/doc/changelog.d/209.fixed.md
@@ -0,0 +1 @@
+fix: not checking if actors have datasets.
diff --git a/doc/changelog.d/212.fixed.md b/doc/changelog.d/212.fixed.md
@@ -0,0 +1 @@
+fix: Changelog links
diff --git a/pyproject.toml b/pyproject.toml
@@ -35,27 +35,25 @@ pyvistaqt = [
     "pyvistaqt >= 0.11.1,<1",
 ]
 tests = [
-    "pytest==8.3.3",
+    "pytest==8.3.4",
     "pytest-pyvista==0.1.9",
     "pytest-cov==6.0.0",
-    "pyside6==6.8.0.2",
-    "pyvistaqt==0.11.1,<1",
-    "pytest-qt"
+    "pyside6==6.8.1",
 ]
 
 doc = [
-    "ansys-sphinx-theme==1.2.2",
+    "ansys-sphinx-theme==1.2.3",
     "jupyter_sphinx==0.5.3",
     "jupytext==1.16.4",
     "nbsphinx==0.9.5",
     "numpydoc==1.8.0",
     "sphinx==8.1.3",
-    "sphinx-autoapi==3.3.3",
+    "sphinx-autoapi==3.4.0",
     "sphinx-copybutton==0.5.2",
     "sphinx_design==0.6.1",
     "sphinx-gallery==0.18.0",
     "sphinx-jinja==2.0.2",
-    "ansys-fluent-core==0.26.1",
+    "ansys-fluent-core==0.27.0",
 ]
 
 [project.urls]
@@ -116,8 +114,8 @@ filename = "CHANGELOG.md"
 start_string = "<!-- towncrier release notes start -->\n"
 underlines = ["", "", ""]
 template = "doc/changelog.d/changelog_template.jinja"
-title_format = "`{version} <https://github.com/ansys/ansys-tools-visualization-interface/releases/tag/v{version}>`_ - {project_date}"
-issue_format = "`#{issue} <https://github.com/ansys/ansys-tools-visualization-interface/pull/{issue}>`_"
+title_format = "`[{version}](https://github.com/ansys/ansys-tools-visualization-interface/releases/tag/v{version}) - {project_date}"
+issue_format = "`[#{issue}](https://github.com/ansys/ansys-tools-visualization-interface/pull/{issue})"
 
 [[tool.towncrier.type]]
 directory = "added"
diff --git a/src/ansys/tools/visualization_interface/backends/pyvista/pyvista_interface.py b/src/ansys/tools/visualization_interface/backends/pyvista/pyvista_interface.py
@@ -88,6 +88,8 @@ def __init__(
                         message = "PyVistaQt dependency is not installed. Install it with " + \
                                   "`pip install ansys-tools-visualization-interface[pyvistaqt]`."
                         logger.warning(message)
+                    # Avoiding having duplicated argument
+                    plotter_kwargs.pop("off_screen", None)
                     scene = pv.Plotter(off_screen=True, **plotter_kwargs)
             elif use_qt:
                 scene = pyvistaqt.BackgroundPlotter()
diff --git a/src/ansys/tools/visualization_interface/backends/pyvista/widgets/mesh_slider.py b/src/ansys/tools/visualization_interface/backends/pyvista/widgets/mesh_slider.py
@@ -52,10 +52,21 @@ def __init__(self, plotter_helper: "Plotter") -> None:
         self._button: vtkButtonWidget = self.plotter_helper._pl.scene.add_checkbox_button_widget(
             self.callback, position=(45, 60), size=30, border_size=3
         )
-        self._meshes = self.plotter_helper._pl.scene.meshes
         self._mb = None
         self._mesh_actor_list = []
 
+    @property
+    def _meshes(self):
+        """Return all the meshes which have dataset from the underlying plotter."""
+        # This method is patching #208
+        # until pyvista fix this upstream.
+        actors = self.plotter_helper._pl.scene.actors.values()
+        meshes = []
+        for actor in actors:
+            if hasattr(actor, 'mapper') and hasattr(actor.mapper, "dataset"):
+                meshes.append(actor.mapper.dataset)
+        return meshes
+
     def callback(self, state: bool) -> None:
         """Remove or add the mesh slider widget actor upon click.
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+build(deps): bump ansys-fluent-core from 0.26.1 to 0.27.0 in the general-dependencies group`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+build(deps): bump pytest from 8.3.3 to 8.3.4 in the test-dependencies group`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+build(deps): bump sphinx-autoapi from 3.3.3 to 3.4.0 in the doc-dependencies group`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+build(deps): bump pyvista/setup-headless-display-action from 2 to 3`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+build(deps): bump pyside6 from 6.8.0.2 to 6.8.1 in the general-dependencies group`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+build(deps): bump ansys-sphinx-theme from 1.2.2 to 1.2.3 in the doc-dependencies group`