Skip to content

FIX: test_configure_layout.py #6809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

FIX: test_configure_layout.py #6809

wants to merge 7 commits into from
+7 −6

Conversation

@hui-zhou-a
Copy link
Contributor

@hui-zhou-a hui-zhou-a commented Oct 24, 2025 •
edited
Loading

Description

The test is too heavy for Linux. Simplify the test by providing empty configure file.

EDB configuration is covered by pyedb tests, so there is no need to test its backend function in the extension test

Issue linked

#6788 #6828

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@hui-zhou-a hui-zhou-a requested a review from a team as a code owner October 24, 2025 00:28
@github-actions github-actions bot added the bug Something isn't working label Oct 24, 2025
@codecov
Copy link

codecov bot commented Oct 24, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.46%. Comparing base (51a6d85) to head (7b5f332).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6809      +/-   ##
==========================================
- Coverage   83.48%   83.46%   -0.02%     
==========================================
  Files         245      245              
  Lines       77503    77504       +1     
==========================================
- Hits        64706    64692      -14     
- Misses      12797    12812      +15
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

SMoraisAnsys
SMoraisAnsys reviewed Oct 24, 2025
View reviewed changes
This was linked to issues Oct 31, 2025
CI: Refactor code related to test_apply_config_to_edb or strengthen CI #6788
Open
Bug located in Configure layout extension #6828
Open
@SMoraisAnsys
Copy link
Collaborator

SMoraisAnsys commented Oct 31, 2025

Hi @hui-zhou-a, could you please extend your PR to handle #6788 ?
We have had to disable the flaky tests from the CI because it was impacting all of the PRs and required us to rerun the job multiple times (very often), cf #6839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SMoraisAnsys SMoraisAnsys SMoraisAnsys left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug located in Configure layout extension CI: Refactor code related to test_apply_config_to_edb or strengthen CI

4 participants

@hui-zhou-a @SMoraisAnsys @pyansys-ci-bot