FIX: emit properties cleanup #6835
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove some Savant specific keys Fix _is_component() logic Use EmitNode.name setter instead of a separate rename() function
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (51.12%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6835 +/- ##
===========================================
+ Coverage 44.50% 82.50% +38.00%
===========================================
Files 245 245
Lines 77613 77033 -580
===========================================
+ Hits 34544 63559 +29015
+ Misses 43069 13474 -29595 🚀 New features to boost your workflow:
|
Add Synopsys to ignore words
SMoraisAnsys
requested changes
Oct 31, 2025
Co-authored-by: Sébastien Morais <[email protected]>
add some utility functions for getting radio/band names fix enabled property to return bool instead of string
remove unused variable
fix line length
Improve coverage test Add some default arg values
add some more test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some Savant specific keys
Fix _is_component() logic
Use EmitNode.name setter instead of a separate rename() function
Description
Please provide a brief description of the changes made in this pull request.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist