Skip to content

Commit 9048472

Browse files
feat: Adding linting rules to Ruff config, updating fixed file
1 parent 2f984e9 commit 9048472

File tree

2 files changed

+20
-18
lines changed

2 files changed

+20
-18
lines changed

doc/source/how-to/code/pyansys_logging.py

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -95,11 +95,11 @@ def log_to_stdout(self, level=LOG_LEVEL):
9595
self.logger = add_stdout_handler(self.logger, level=level)
9696
self.std_out_handler = self.logger.std_out_handler
9797

98-
def setLevel(self, level="DEBUG"):
98+
def setlevel(self, level="DEBUG"):
9999
"""Change the log level of the object and the attached handlers."""
100-
self.logger.setLevel(level)
100+
self.logger.setlevel(level)
101101
for each_handler in self.logger.handlers:
102-
each_handler.setLevel(level)
102+
each_handler.setlevel(level)
103103
self.level = level
104104

105105

@@ -194,7 +194,7 @@ def __init__(
194194

195195
self.logger = logging.getLogger("pyproject_global") # Creating default main logger.
196196
self.logger.addFilter(InstanceFilter())
197-
self.logger.setLevel(level)
197+
self.logger.setlevel(level)
198198
self.logger.propagate = True
199199
self.level = self.logger.level # TODO: TO REMOVE
200200

@@ -243,11 +243,11 @@ def log_to_stdout(self, level=LOG_LEVEL):
243243

244244
self = add_stdout_handler(self, level=level)
245245

246-
def setLevel(self, level="DEBUG"):
246+
def setlevel(self, level="DEBUG"):
247247
"""Change the log level of the object and the attached handlers."""
248-
self.logger.setLevel(level)
248+
self.logger.setlevel(level)
249249
for each_handler in self.logger.handlers:
250-
each_handler.setLevel(level)
250+
each_handler.setlevel(level)
251251
self._level = level
252252

253253
def _make_child_logger(self, suffix, level):
@@ -276,17 +276,17 @@ def _make_child_logger(self, suffix, level):
276276
# loglevel if the specified log level is lower
277277
# than the one of the global.
278278
if each_handler.level > string_to_loglevel[level.upper()]:
279-
new_handler.setLevel(level)
279+
new_handler.setlevel(level)
280280

281281
logger.addHandler(new_handler)
282282

283283
if level:
284284
if isinstance(level, str):
285285
level = string_to_loglevel[level.upper()]
286-
logger.setLevel(level)
286+
logger.setlevel(level)
287287

288288
else:
289-
logger.setLevel(self.logger.level)
289+
logger.setlevel(self.logger.level)
290290

291291
logger.propagate = True
292292
return logger
@@ -395,7 +395,7 @@ def __del__(self):
395395
for handler in self.logger.handlers:
396396
handler.close()
397397
self.logger.removeHandler(handler)
398-
except Exception as e:
398+
except Exception:
399399
try:
400400
if self.logger is not None:
401401
self.logger.error("The logger was not deleted properly.")
@@ -426,7 +426,7 @@ def add_file_handler(logger, filename=FILE_NAME, level=LOG_LEVEL, write_headers=
426426
"""
427427

428428
file_handler = logging.FileHandler(filename)
429-
file_handler.setLevel(level)
429+
file_handler.setlevel(level)
430430
file_handler.setFormatter(logging.Formatter(FILE_MSG_FORMAT))
431431

432432
if isinstance(logger, Logger):
@@ -463,7 +463,7 @@ def add_stdout_handler(logger, level=LOG_LEVEL, write_headers=False):
463463
"""
464464

465465
std_out_handler = logging.StreamHandler(sys.stdout)
466-
std_out_handler.setLevel(level)
466+
std_out_handler.setlevel(level)
467467
std_out_handler.setFormatter(PyProjectFormatter(STDOUT_MSG_FORMAT))
468468

469469
if isinstance(logger, Logger):

ruff.toml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,18 @@ docstring-code-format = true
1313
[lint]
1414
select = [
1515
"E", # pycodestyle, see https://docs.astral.sh/ruff/rules/#pycodestyle-e-w
16-
"I", # isort, see https://docs.astral.sh/ruff/rules/#isort-i
17-
]
18-
ignore = [
19-
"D", # pydocstyle, see https://docs.astral.sh/ruff/rules/#pydocstyle-d
2016
"F", # pyflakes, see https://docs.astral.sh/ruff/rules/#pyflakes-f
17+
"I", # isort, see https://docs.astral.sh/ruff/rules/#isort-i
2118
"N", # pep8-naming, see https://docs.astral.sh/ruff/rules/#pep8-naming-n
22-
"PTH", # flake8-use-pathlib, https://docs.astral.sh/ruff/rules/#flake8-use-pathlib-pth
2319
"TD", # flake8-todos, https://docs.astral.sh/ruff/rules/#flake8-todos-td
2420
"W", # pycodestyle, see https://docs.astral.sh/ruff/rules/#pycodestyle-e-w
2521
]
22+
ignore = [
23+
"D", # pydocstyle, see https://docs.astral.sh/ruff/rules/#pydocstyle-d
24+
"PTH", # flake8-use-pathlib, https://docs.astral.sh/ruff/rules/#flake8-use-pathlib-pth
25+
"TD002", # Missing author in TODOs comment
26+
"TD003", # Missing issue link in TODOs comment
27+
]
2628

2729
[lint.pydocstyle]
2830
convention = "numpy"

0 commit comments

Comments
 (0)