added the rest of methods - may need to remove offset face curves

Author: jacobrkerstetter

src/ansys/geometry/core/_grpc/_services/_service.py

@@ -29,6 +29,7 @@
 from .base.bodies import GRPCBodyService
 from .base.commands import GRPCCommandsService
 from .base.coordinate_systems import GRPCCoordinateSystemService
+from .base.curves import GRPCCurvesService
 from .base.dbuapplication import GRPCDbuApplicationService
 from .base.designs import GRPCDesignsService
 from .base.driving_dimensions import GRPCDrivingDimensionsService
@@ -88,6 +89,7 @@ def __init__(self, channel: grpc.Channel, version: GeometryApiProtos | str | Non
         self._bodies = None
         self._commands = None
         self._coordinate_systems = None
+        self._curves = None
         self._dbu_application = None
         self._designs = None
         self._driving_dimensions = None
@@ -258,6 +260,32 @@ def coordinate_systems(self) -> GRPCCoordinateSystemService:
 
         return self._coordinate_systems
 
+    @property
+    def curves(self) -> GRPCCurvesService:
+        """
+        Get the curves service for the specified version.
+
+        Returns
+        -------
+        GRPCCurvesService
+            The curves service for the specified version.
+        """
+        if not self._curves:
+            # Import the appropriate curves service based on the version
+            from .v0.curves import GRPCCurvesServiceV0
+            from .v1.curves import GRPCCurvesServiceV1
+
+            if self.version == GeometryApiProtos.V0:
+                self._curves = GRPCCurvesServiceV0(self.channel)
+            elif self.version == GeometryApiProtos.V1:  # pragma: no cover
+                # V1 is not implemented yet
+                self._curves = GRPCCurvesServiceV1(self.channel)
+            else:  # pragma: no cover
+                # This should never happen as the version is set in the constructor
+                raise ValueError(f"Unsupported version: {self.version}")
+
+        return self._curves
+
     @property
     def designs(self) -> GRPCDesignsService:
         """

src/ansys/geometry/core/_grpc/_services/base/curves.py

@@ -0,0 +1,45 @@
+# Copyright (C) 2023 - 2025 ANSYS, Inc. and/or its affiliates.
+# SPDX-License-Identifier: MIT
+#
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in all
+# copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+# SOFTWARE.
+"""Module containing the curves service implementation (abstraction layer)."""
+
+from abc import ABC, abstractmethod
+
+import grpc
+
+
+class GRPCCurvesService(ABC):  # pragma: no cover
+    """Curves service for gRPC communication with the Geometry server.
+
+    Parameters
+    ----------
+    channel : grpc.Channel
+        The gRPC channel to the server.
+    """
+
+    def __init__(self, channel: grpc.Channel):
+        """Initialize the GRPCCurvesService class."""
+        pass
+
+    @abstractmethod
+    def offset_face_curves(self, **kwargs) -> dict:
+        """Offset face curves."""
+        pass

src/ansys/geometry/core/_grpc/_services/v0/curves.py

@@ -0,0 +1,88 @@
+# Copyright (C) 2023 - 2025 ANSYS, Inc. and/or its affiliates.
+# SPDX-License-Identifier: MIT
+#
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in all
+# copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+# SOFTWARE.
+"""Module containing the curves service implementation for v0."""
+
+import grpc
+
+from ansys.geometry.core.errors import protect_grpc
+
+from ..base.conversions import from_measurement_to_server_angle, from_measurement_to_server_length
+from ..base.curves import GRPCCurvesService
+from .conversions import from_line_to_grpc_line, from_trimmed_curve_to_grpc_trimmed_curve
+
+
+class GRPCCurvesServiceV0(GRPCCurvesService):  # pragma: no cover
+    """Curves service for gRPC communication with the Geometry server.
+
+    This class provides methods to interact with the Geometry server's
+    curves service. It is specifically designed for the v0 version of the
+    Geometry API.
+
+    Parameters
+    ----------
+    channel : grpc.Channel
+        The gRPC channel to the server.
+    """
+
+    @protect_grpc
+    def __init__(self, channel: grpc.Channel):  # noqa: D102
+        from ansys.api.geometry.v0.commands_pb2_grpc import CommandsStub
+
+        self.stub = CommandsStub(channel)
+
+    @protect_grpc
+    def offset_face_curves(self, **kwargs):  # noqa: D102
+        from ansys.api.dbu.v0.dbumodels_pb2 import EntityIdentifier
+        from ansys.api.geometry.v0.commands_pb2 import OffsetFaceCurvesRequest
+
+        # Create the request - assumes all inputs are valid and of the proper type
+        request = OffsetFaceCurvesRequest(
+            objects=[EntityIdentifier(id=id) for id in kwargs["curve_ids"]],
+            offset=from_measurement_to_server_length(kwargs["offset"]),
+        )
+        
+        # Call the gRPC service
+        result = self.stub.OffsetFaceCurves(request)
+
+        # Return the result - formatted as a dictionary
+        return {
+            "success": result.result.success,
+            "created_curves": [curve.id for curve in result.created_curves]
+        }
+
+    @protect_grpc
+    def revolve_edges(self, **kwargs):  # noqa: D102
+        from ansys.api.geometry.v0.commands_pb2 import RevolveCurvesRequest
+
+        # Create the request - assumes all inputs are valid and of the proper type
+        request = RevolveCurvesRequest(
+            curves=[from_trimmed_curve_to_grpc_trimmed_curve(curve) for curve in kwargs["curves"]],
+            axis=from_line_to_grpc_line(kwargs["axis"]),
+            angle=from_measurement_to_server_angle(kwargs["angle"]),
+            symmetric=kwargs["symmetric"],
+        )
+
+        # Call the gRPC service
+        _ = self.stub.RevolveCurves(request)
+
+        # Return the result - formatted as a dictionary
+        return {}

src/ansys/geometry/core/_grpc/_services/v1/curves.py

@@ -0,0 +1,56 @@
+# Copyright (C) 2023 - 2025 ANSYS, Inc. and/or its affiliates.
+# SPDX-License-Identifier: MIT
+#
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in all
+# copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+# SOFTWARE.
+"""Module containing the curves service implementation for v1."""
+
+import grpc
+
+from ansys.geometry.core.errors import protect_grpc
+
+from ..base.curves import GRPCCurvesService
+
+
+class GRPCCurvesServiceV1(GRPCCurvesService):  # pragma: no cover
+    """Curves service for gRPC communication with the Geometry server.
+
+    This class provides methods to interact with the Geometry server's
+    curves service. It is specifically designed for the v1 version of the
+    Geometry API.
+
+    Parameters
+    ----------
+    channel : grpc.Channel
+        The gRPC channel to the server.
+    """
+
+    @protect_grpc
+    def __init__(self, channel: grpc.Channel):  # noqa: D102
+        from ansys.api.geometry.v1.curves_pb2_grpc import CurvesStub
+
+        self.stub = CurvesStub(channel)
+
+    @protect_grpc
+    def offset_face_curves(self, **kwargs):  # noqa: D102
+        raise NotImplementedError
+    
+    @protect_grpc
+    def revolve_edges(self, **kwargs):  # noqa: D102
+        raise NotImplementedError

src/ansys/geometry/core/designer/geometry_commands.py

@@ -1792,4 +1792,74 @@ def offset_faces(
             distance=distance,
             direction=direction,
             extrude_type=extrude_type,
-        )
+        )
+
+    @min_backend_version(25, 2, 0)
+    def offset_face_curves(
+        self,
+        curves: Union["Curve", list["Curve"]],
+        offset: Distance | Quantity | Real,
+    ) -> bool:
+        """Offsets a given set of face curves by the specified distance.
+
+        Parameters
+        ----------
+        curves : Curve | list[Curve]
+            The curves to offset.
+        offset : Distance | Quantity | Real
+            The distance to offset the curves.
+        
+        Returns
+        -------
+        bool
+            ``True`` when successful, ``False`` when failed.
+        """
+        curves = curves if isinstance(curves, list) else [curves]
+        offset = offset if isinstance(offset, Distance) else Distance(offset)
+
+        _ = self._grpc_client._services.curves.offset_face_curves(
+            curves=[curve.id for curve in curves], # TODO
+            offset=offset
+        )
+
+    @min_backend_version(25, 2, 0)
+    def revolve_edges(
+        self,
+        edges: Union["Edge", list["Edge"]],
+        axis: Line,
+        angle: Angle | Quantity | Real,
+        symmetric: bool,
+    ) -> None:
+        """Revolve edges around an axis.
+
+        Parameters
+        ----------
+        edges : Edge | list[Edge]
+            Edge(s) to revolve.
+        axis : Line
+            Axis of revolution.
+        angle : Angle | Quantity | Real
+            Angular distance to revolve.
+        symmetric : bool
+            Revolve symmetrically if ``True``, one side if ``False``.
+
+        Warnings
+        --------
+        This method is only available starting on Ansys release 25R2.
+        """
+        from ansys.geometry.core.designer.edge import Edge
+
+        edges: list[Edge] = edges if isinstance(edges, list) else [edges]
+        check_type_all_elements_in_iterable(edges, Edge)
+
+        angle = angle if isinstance(angle, Angle) else Angle(angle)
+
+        _ = self._grpc_client._services.curves.revolve_edges(
+            curves=[edge.shape for edge in edges],
+            axis=axis,
+            angle=angle,
+            symmetric=symmetric,
+        )
+
+        design = get_design_from_edge(edges[0])
+        design._update_design_inplace()

tests/integration/test_geometry_commands.py

@@ -1431,4 +1431,26 @@ def test_offset_faces(modeler: Modeler):
     )
 
     assert box.volume.m == pytest.approx(Quantity(8.8, UNITS.m**3).m, rel=1e-6, abs=1e-8)
-    assert box2.volume.m == pytest.approx(Quantity(8.4, UNITS.m**3).m, rel=1e-6, abs=1e-8)
+    assert box2.volume.m == pytest.approx(Quantity(8.4, UNITS.m**3).m, rel=1e-6, abs=1e-8)
+    
+def test_revolve_edges(modeler: Modeler):
+    """Test revolving edges."""
+    design = modeler.create_design("revolve_edges")
+    box = design.extrude_sketch("box", Sketch().box(Point2D([0, 0]), 2, 2), 2)
+    
+    assert len(box.faces) == 6
+    assert box.volume.m == pytest.approx(Quantity(8, UNITS.m**3).m, rel=1e-6, abs=1e-8)
+
+    # Revolve one edge of the box
+    edge = box.faces[2].edges[0]
+    axis = Line(Point3D([0, 0, 0], UNITS.m), UNITVECTOR3D_Z)
+    modeler.geometry_commands.revolve_edges(edge, axis, Angle(np.pi / 2, UNITS.rad), True)
+
+    assert len(design.bodies) == 2
+    assert design.bodies[0].volume.m == pytest.approx(
+        Quantity(8, UNITS.m**3).m, rel=1e-6, abs=1e-8
+    )
+    assert design.bodies[1].is_surface
+    assert design.bodies[1].faces[0].area.m == pytest.approx(
+        Quantity(8.88576587632, UNITS.m**2).m, rel=1e-6, abs=1e-8
+    )