Merge branch 'main' into feat/track_boolean_operations

jacobrkerstetter · web-flow · commit 12b13c06badb · 2025-08-25T14:51:36.000-04:00
diff --git a/.github/workflows/backwards_compatibility.yml b/.github/workflows/backwards_compatibility.yml
@@ -107,7 +107,7 @@ jobs:
           pytest -v --backwards-compatibility=yes --backend-version=${{ matrix.backend-version }} -rf
 
       - name: Upload coverage to Codecov
-        uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
+        uses: codecov/codecov-action@fdcc8476540edceab3de004e990f80d881c6cc00 # v5.5.0
         env:
           CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
         with:
diff --git a/.github/workflows/ci_cd.yml b/.github/workflows/ci_cd.yml
@@ -295,7 +295,7 @@ jobs:
           retention-days: 7
 
       - name: Upload coverage to Codecov
-        uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
+        uses: codecov/codecov-action@fdcc8476540edceab3de004e990f80d881c6cc00 # v5.5.0
         if: matrix.docker-image == 'core-windows-latest'
         env:
           CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
@@ -441,7 +441,7 @@ jobs:
           randomize: true
 
       - name: Upload coverage to Codecov
-        uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
+        uses: codecov/codecov-action@fdcc8476540edceab3de004e990f80d881c6cc00 # v5.5.0
         if: matrix.docker-image == 'core-linux-latest'
         env:
           CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
@@ -22,13 +22,13 @@ jobs:
       uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
 
     - name: Initialize CodeQL
-      uses: github/codeql-action/init@96f518a34f7a870018057716cc4d7a5c014bd61c # v3.29.10
+      uses: github/codeql-action/init@3c3833e0f8c1c83d449a7478aa59c036a9165498 # v3.29.11
       with:
         languages: 'python'
         config-file: ./.github/codeql-config.yml
 
     - name: Autobuild
-      uses: github/codeql-action/autobuild@96f518a34f7a870018057716cc4d7a5c014bd61c # v3.29.10
+      uses: github/codeql-action/autobuild@3c3833e0f8c1c83d449a7478aa59c036a9165498 # v3.29.11
 
     #   If the Autobuild fails above, remove it and uncomment the following three lines.
     #   modify them (or add more) to build your code if your project, please refer to the EXAMPLE below for guidance.
@@ -38,6 +38,6 @@ jobs:
     #     ./location_of_script_within_repo/buildscript.sh
 
     - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@96f518a34f7a870018057716cc4d7a5c014bd61c # v3.29.10
+      uses: github/codeql-action/analyze@3c3833e0f8c1c83d449a7478aa59c036a9165498 # v3.29.11
       with:
         category: "/language:python"
diff --git a/doc/changelog.d/2180.added.md b/doc/changelog.d/2180.added.md
@@ -0,0 +1 @@
+Remove materials
diff --git a/doc/changelog.d/2186.maintenance.md b/doc/changelog.d/2186.maintenance.md
@@ -0,0 +1 @@
+Bump codecov/codecov-action from 5.4.3 to 5.5.0 in the actions group
diff --git a/doc/changelog.d/2188.fixed.md b/doc/changelog.d/2188.fixed.md
@@ -0,0 +1 @@
+Prevent tool and command classes instantiation outside of modeler object
diff --git a/doc/changelog.d/2190.fixed.md b/doc/changelog.d/2190.fixed.md
@@ -0,0 +1 @@
+Mathematical approximations leading to potential issues - allowing rounding
diff --git a/doc/changelog.d/2191.maintenance.md b/doc/changelog.d/2191.maintenance.md
@@ -0,0 +1 @@
+Bump github/codeql-action from 3.29.10 to 3.29.11 in the actions group
diff --git a/doc/changelog.d/2192.dependencies.md b/doc/changelog.d/2192.dependencies.md
@@ -0,0 +1 @@
+Bump requests from 2.32.4 to 2.32.5
diff --git a/pyproject.toml b/pyproject.toml
@@ -74,7 +74,7 @@ tests = [
     "pytest-pyvista==0.2.0",
     "pyvista[jupyter]==0.46.1",
     "pyyaml==6.0.2",
-    "requests==2.32.4",
+    "requests==2.32.5",
     "scipy==1.15.3",
     "semver==3.0.4",
     "six==1.17.0",
@@ -112,7 +112,7 @@ doc = [
     "pygltflib==1.16.5",
     "pyvista[jupyter]==0.46.1",
     "quarto-cli==1.7.33",
-    "requests==2.32.4",
+    "requests==2.32.5",
     "scipy==1.15.3",
     "semver==3.0.4",
     "six==1.17.0",
diff --git a/src/ansys/geometry/core/_grpc/_services/base/bodies.py b/src/ansys/geometry/core/_grpc/_services/base/bodies.py
@@ -149,6 +149,11 @@ def get_assigned_material(self, **kwargs) -> dict:
         """Get the assigned material of a body."""
         pass
 
+    @abstractmethod
+    def remove_assigned_material(self, **kwargs) -> dict:
+        """Remove the assigned material of a body."""
+        pass
+
     @abstractmethod
     def set_name(self, **kwargs) -> dict:
         """Set the name of a body."""
diff --git a/src/ansys/geometry/core/_grpc/_services/base/materials.py b/src/ansys/geometry/core/_grpc/_services/base/materials.py
@@ -43,3 +43,8 @@ def __init__(self, channel: grpc.Channel):
     def add_material(self, **kwargs) -> dict:
         """Add material to the service design."""
         pass
+
+    @abstractmethod
+    def remove_material(self, **kwargs) -> dict:
+        """Remove material from the service design."""
+        pass
diff --git a/src/ansys/geometry/core/_grpc/_services/v0/bodies.py b/src/ansys/geometry/core/_grpc/_services/v0/bodies.py
@@ -497,6 +497,19 @@ def get_assigned_material(self, **kwargs) -> dict:  # noqa: D102
         # Return the response - formatted as a dictionary
         return {"material": from_grpc_material_to_material(resp)}
 
+    @protect_grpc
+    def remove_assigned_material(self, **kwargs) -> dict:  # noqa: D102
+        from ansys.api.geometry.v0.bodies_pb2 import RemoveAssignedMaterialRequest
+
+        # Create the request - assumes all inputs are valid and of the proper type
+        request = RemoveAssignedMaterialRequest(ids=[build_grpc_id(id) for id in kwargs["ids"]])
+
+        # Call the gRPC service
+        resp = self.stub.RemoveAssignedMaterial(request=request)
+
+        # Return the response - formatted as a dictionary
+        return {"successfully_removed": [id for id in resp.successfully_removed]}
+
     @protect_grpc
     def set_name(self, **kwargs) -> dict:  # noqa: D102
         from ansys.api.geometry.v0.bodies_pb2 import SetNameRequest
diff --git a/src/ansys/geometry/core/_grpc/_services/v0/materials.py b/src/ansys/geometry/core/_grpc/_services/v0/materials.py
@@ -62,3 +62,18 @@ def add_material(self, **kwargs) -> dict:  # noqa: D102
 
         # Convert the response to a dictionary
         return {}
+
+    @protect_grpc
+    def remove_material(self, **kwargs) -> dict:  # noqa: D102
+        from ansys.api.geometry.v0.materials_pb2 import RemoveFromDocumentRequest
+
+        # Create the request - assumes all inputs are valid and of the proper type
+        request = RemoveFromDocumentRequest(
+            request_data=[from_material_to_grpc_material(mat) for mat in kwargs["materials"]]
+        )
+
+        # Call the gRPC service
+        _ = self.stub.RemoveFromDocument(request=request)
+
+        # Convert the response to a dictionary
+        return {}
diff --git a/src/ansys/geometry/core/_grpc/_services/v1/bodies.py b/src/ansys/geometry/core/_grpc/_services/v1/bodies.py
@@ -136,6 +136,10 @@ def set_assigned_material(self, **kwargs) -> dict:  # noqa: D102
     def get_assigned_material(self, **kwargs) -> dict:  # noqa: D102
         raise NotImplementedError
 
+    @protect_grpc
+    def remove_assigned_material(self, **kwargs):  # noqa: D102
+        raise NotImplementedError
+
     @protect_grpc
     def set_name(self, **kwargs) -> dict:  # noqa: D102
         raise NotImplementedError
diff --git a/src/ansys/geometry/core/_grpc/_services/v1/materials.py b/src/ansys/geometry/core/_grpc/_services/v1/materials.py
@@ -50,3 +50,7 @@ def __init__(self, channel: grpc.Channel):  # noqa: D102
     @protect_grpc
     def add_material(self, **kwargs) -> dict:  # noqa: D102
         raise NotImplementedError
+
+    @protect_grpc
+    def remove_material(self, **kwargs) -> dict:  # noqa: D102
+        raise NotImplementedError
diff --git a/src/ansys/geometry/core/designer/body.py b/src/ansys/geometry/core/designer/body.py
@@ -339,6 +339,11 @@ def get_assigned_material(self) -> Material:
         """
         return
 
+    @abstractmethod
+    def remove_assigned_material(self) -> None:
+        """Remove the material assigned to the body."""
+        return
+
     @abstractmethod
     def add_midsurface_thickness(self, thickness: Quantity) -> None:
         """Add a mid-surface thickness to a surface body.
@@ -1062,6 +1067,11 @@ def get_assigned_material(self) -> Material:  # noqa: D102
         response = self._grpc_client.services.bodies.get_assigned_material(id=self.id)
         return response.get("material")
 
+    @min_backend_version(26, 1, 0)
+    def remove_assigned_material(self) -> None:  # noqa: D102
+        self._grpc_client.log.debug(f"Removing assigned material for body {self.id}.")
+        self._grpc_client.services.bodies.remove_assigned_material(ids=[self.id])
+
     @protect_grpc
     @check_input_types
     def add_midsurface_thickness(self, thickness: Quantity) -> None:  # noqa: D102
@@ -1594,6 +1604,10 @@ def assign_material(self, material: Material) -> None:  # noqa: D102
     def get_assigned_material(self) -> Material:  # noqa: D102
         return self._template.get_assigned_material()
 
+    @ensure_design_is_active
+    def remove_assigned_material(self):  # noqa: D102
+        self._template.remove_assigned_material()
+
     @ensure_design_is_active
     def add_midsurface_thickness(self, thickness: Quantity) -> None:  # noqa: D102
         self._template.add_midsurface_thickness(thickness)
diff --git a/src/ansys/geometry/core/designer/design.py b/src/ansys/geometry/core/designer/design.py
@@ -227,6 +227,24 @@ def add_material(self, material: Material) -> None:
         self._materials.append(material)
         self._grpc_client.log.debug(f"Material {material.name} is successfully added to design.")
 
+    @min_backend_version(26, 1, 0)
+    @check_input_types
+    @ensure_design_is_active
+    def remove_material(self, material: Material | list[Material]) -> None:
+        """Remove a material from the design.
+
+        Parameters
+        ----------
+        material : Material | list[Material]
+            Material or list of materials to remove.
+        """
+        material = material if isinstance(material, list) else [material]
+
+        self._grpc_client.services.materials.remove_material(materials=material)
+        for mat in material:
+            self._materials.remove(mat)
+            self._grpc_client.log.debug(f"Material {mat.name} is successfully removed from design.")
+
     @check_input_types
     @ensure_design_is_active
     def save(self, file_location: Path | str, write_body_facets: bool = False) -> None:
diff --git a/src/ansys/geometry/core/designer/geometry_commands.py b/src/ansys/geometry/core/designer/geometry_commands.py
@@ -69,7 +69,7 @@
     TangentCondition,
 )
 from ansys.geometry.core.designer.selection import NamedSelection
-from ansys.geometry.core.errors import protect_grpc
+from ansys.geometry.core.errors import GeometryRuntimeError, protect_grpc
 from ansys.geometry.core.math.plane import Plane
 from ansys.geometry.core.math.point import Point3D
 from ansys.geometry.core.math.vector import UnitVector3D
@@ -135,11 +135,30 @@ class GeometryCommands:
     ----------
     grpc_client : GrpcClient
         gRPC client to use for the geometry commands.
+    _internal_use : bool, optional
+        Internal flag to prevent direct instantiation by users.
+        This parameter is for internal use only.
+
+    Raises
+    ------
+    GeometryRuntimeError
+        If the class is instantiated directly by users instead
+        of through the modeler.
+
+    Notes
+    -----
+    This class should not be instantiated directly. Use
+    ``modeler.geometry_commands`` instead.
     """
 
     @protect_grpc
-    def __init__(self, grpc_client: GrpcClient):
+    def __init__(self, grpc_client: GrpcClient, _internal_use: bool = False):
         """Initialize an instance of the ``GeometryCommands`` class."""
+        if not _internal_use:
+            raise GeometryRuntimeError(
+                "GeometryCommands should not be instantiated directly. "
+                "Use 'modeler.geometry_commands' to access geometry commands."
+            )
         self._grpc_client = grpc_client
         self._commands_stub = CommandsStub(self._grpc_client.channel)
 
diff --git a/src/ansys/geometry/core/math/misc.py b/src/ansys/geometry/core/math/misc.py
@@ -80,7 +80,9 @@ def get_two_circle_intersections(
         return None
     else:
         a = (r0**2 - r1**2 + d**2) / (2 * d)
-        h = np.sqrt(r0**2 - a**2)
+        # abs is used to ensure non-negative value - close to zero
+        # conditions might occur if circles are nearly tangent
+        h = np.sqrt(abs(r0**2 - a**2))
         x2 = x0 + a * (x1 - x0) / d
         y2 = y0 + a * (y1 - y0) / d
 
diff --git a/src/ansys/geometry/core/modeler.py b/src/ansys/geometry/core/modeler.py
@@ -117,11 +117,11 @@ def __init__(
         self._design: Optional["Design"] = None
 
         # Enabling tools/commands for all: repair and prepare tools, geometry commands
-        self._measurement_tools = MeasurementTools(self._grpc_client)
-        self._repair_tools = RepairTools(self._grpc_client, self)
-        self._prepare_tools = PrepareTools(self._grpc_client)
-        self._geometry_commands = GeometryCommands(self._grpc_client)
-        self._unsupported = UnsupportedCommands(self._grpc_client, self)
+        self._measurement_tools = MeasurementTools(self._grpc_client, _internal_use=True)
+        self._repair_tools = RepairTools(self._grpc_client, self, _internal_use=True)
+        self._prepare_tools = PrepareTools(self._grpc_client, _internal_use=True)
+        self._geometry_commands = GeometryCommands(self._grpc_client, _internal_use=True)
+        self._unsupported = UnsupportedCommands(self._grpc_client, self, _internal_use=True)
 
     @property
     def client(self) -> GrpcClient:
diff --git a/src/ansys/geometry/core/sketch/sketch.py b/src/ansys/geometry/core/sketch/sketch.py
@@ -516,6 +516,11 @@ def arc_from_start_end_and_radius(
         -------
         Sketch
             Revised sketch state ready for further sketch actions.
+
+        Warnings
+        --------
+        This method may not produce the exact same radius, depending on the input parameters.
+        This is due to the mathematical approximations involved in the arc creation.
         """
         arc = Arc.from_start_end_and_radius(
             start,
diff --git a/src/ansys/geometry/core/tools/measurement_tools.py b/src/ansys/geometry/core/tools/measurement_tools.py
@@ -60,10 +60,29 @@ class MeasurementTools:
     ----------
     grpc_client : GrpcClient
         gRPC client to use for the measurement tools.
+    _internal_use : bool, optional
+        Internal flag to prevent direct instantiation by users.
+        This parameter is for internal use only.
+
+    Raises
+    ------
+    GeometryRuntimeError
+        If the class is instantiated directly by users instead
+        of through the modeler.
+
+    Notes
+    -----
+    This class should not be instantiated directly. Use
+    ``modeler.measurement_tools`` instead.
     """
 
-    def __init__(self, grpc_client: GrpcClient):
+    def __init__(self, grpc_client: GrpcClient, _internal_use: bool = False):
         """Initialize measurement tools class."""
+        if not _internal_use:
+            raise GeometryRuntimeError(
+                "MeasurementTools should not be instantiated directly. "
+                "Use 'modeler.measurement_tools' to access measurement tools."
+            )
         self._grpc_client = grpc_client
 
     @min_backend_version(24, 2, 0)
diff --git a/src/ansys/geometry/core/tools/prepare_tools.py b/src/ansys/geometry/core/tools/prepare_tools.py
@@ -27,6 +27,7 @@
 
 from ansys.geometry.core.connection import GrpcClient
 from ansys.geometry.core.connection.backend import BackendType
+from ansys.geometry.core.errors import GeometryRuntimeError
 from ansys.geometry.core.logger import LOG
 from ansys.geometry.core.misc.auxiliary import (
     get_bodies_from_ids,
@@ -51,10 +52,28 @@ class PrepareTools:
     ----------
     grpc_client : GrpcClient
         Active supporting geometry service instance for design modeling.
+    _internal_use : bool, optional
+        Internal flag to prevent direct instantiation by users.
+        This parameter is for internal use only.
+
+    Raises
+    ------
+    GeometryRuntimeError
+        If the class is instantiated directly by users instead of through the modeler.
+
+    Notes
+    -----
+    This class should not be instantiated directly. Use
+    ``modeler.prepare_tools`` instead.
     """
 
-    def __init__(self, grpc_client: GrpcClient):
+    def __init__(self, grpc_client: GrpcClient, _internal_use: bool = False):
         """Initialize Prepare Tools class."""
+        if not _internal_use:
+            raise GeometryRuntimeError(
+                "PrepareTools should not be instantiated directly. "
+                "Use 'modeler.prepare_tools' to access prepare tools."
+            )
         self._grpc_client = grpc_client
 
     @min_backend_version(25, 1, 0)
diff --git a/src/ansys/geometry/core/tools/repair_tools.py b/src/ansys/geometry/core/tools/repair_tools.py
diff --git a/src/ansys/geometry/core/tools/unsupported.py b/src/ansys/geometry/core/tools/unsupported.py
diff --git a/tests/integration/test_design.py b/tests/integration/test_design.py
diff --git a/tests/integration/test_issues.py b/tests/integration/test_issues.py
diff --git a/tests/integration/test_material.py b/tests/integration/test_material.py
diff --git a/tests/integration/test_repair_tools.py b/tests/integration/test_repair_tools.py

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Bump codecov/codecov-action from 5.4.3 to 5.5.0 in the actions group`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Prevent tool and command classes instantiation outside of modeler object`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Mathematical approximations leading to potential issues - allowing rounding`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Bump github/codeql-action from 3.29.10 to 3.29.11 in the actions group`