Skip to content

Commit 14417c9

Browse files
committed
expand test coverage
1 parent bb867c1 commit 14417c9

File tree

2 files changed

+14
-3
lines changed

2 files changed

+14
-3
lines changed
43.2 KB
Binary file not shown.

tests/integration/test_repair_tools.py

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -207,10 +207,10 @@ def test_find_small_face_faces(modeler: Modeler):
207207
def test_fix_small_face(modeler: Modeler):
208208
"""Test to read geometry and find and fix it's small face problem areas."""
209209
design = modeler.open_file(FILES_DIR / "SmallFaces.scdocx")
210-
problem_areas = modeler.repair_tools.find_small_faces(design.bodies, 3e-8, None)
210+
problem_areas = modeler.repair_tools.find_small_faces(design.bodies, 2.84e-8, None)
211211
assert len(problem_areas) == 2
212-
problem_areas = modeler.repair_tools.find_small_faces(design.bodies, None, 0.00039878)
213-
assert len(problem_areas) == 109
212+
problem_areas = modeler.repair_tools.find_small_faces(design.bodies, None, 0.00036)
213+
assert len(problem_areas) == 9
214214
problem_areas = modeler.repair_tools.find_small_faces(design.bodies)
215215
assert len(problem_areas) == 4
216216
assert problem_areas[0].fix().success is True
@@ -389,6 +389,17 @@ def test_find_and_fix_missing_faces(modeler: Modeler):
389389
for comp in design.components:
390390
assert not comp.bodies[0].is_surface
391391

392+
def test_find_and_fix_missing_faces_angle_distance(modeler: Modeler):
393+
"""Test to read geometry, find and fix missing faces and validate that we now have solids."""
394+
design = modeler.open_file(FILES_DIR / "MissingFaces_AngleDistance.scdocx")
395+
assert len(design.bodies) == 1
396+
assert len(design.bodies[0].faces) == 11
397+
missing_faces = modeler.repair_tools.find_missing_faces(design.bodies,0.785398, 0.0005)
398+
assert len(missing_faces) == 4
399+
for face in missing_faces:
400+
face.fix()
401+
assert len(design.bodies) == 1
402+
assert len(design.bodies[0].faces) == 15
392403

393404
def test_find_and_fix_short_edges_problem_areas(modeler: Modeler):
394405
"""Test to read geometry, find and fix short edges and validate they are fixed removed."""

0 commit comments

Comments
 (0)