Skip to content

Commit 227be2f

Browse files
committed
Merge branch 'blitz' into feat/add_import_options_ns
2 parents ed2c19e + 371d89a commit 227be2f

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

67 files changed

+1773
-436
lines changed

.github/workflows/automerge_prs.yml

Lines changed: 0 additions & 52 deletions
This file was deleted.

.github/workflows/ci_cd.yml

Lines changed: 19 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ env:
1010
PACKAGE_NAME: 'ansys-geometry-core'
1111
DOCUMENTATION_CNAME: 'geometry.docs.pyansys.com'
1212
ANSRV_GEO_IMAGE: 'ghcr.io/ansys/geometry'
13-
ANSRV_GEO_IMAGE_DOCS_TAG: ghcr.io/ansys/geometry:windows-latest
13+
ANSRV_GEO_IMAGE_DOCS_TAG: ghcr.io/ansys/geometry:core-linux-latest
1414
ANSRV_GEO_PORT: 700
1515
ANSRV_GEO_LICENSE_SERVER: ${{ secrets.LICENSE_SERVER }}
1616
GEO_CONT_NAME: ans_geo
@@ -68,16 +68,11 @@ jobs:
6868
name: Check Docker manifests
6969
runs-on: ubuntu-latest
7070
outputs:
71-
skip_dms: ${{ steps.services.outputs.skip_dms }}
7271
skip_core_windows: ${{ steps.services.outputs.skip_core_windows }}
7372
skip_core_linux: ${{ steps.services.outputs.skip_core_linux }}
7473
strategy:
7574
matrix:
7675
include:
77-
- container-stable: "windows-latest"
78-
container-unstable: "windows-latest-unstable"
79-
service: "dms"
80-
service-name: "Windows DMS"
8176
- container-stable: "core-windows-latest"
8277
container-unstable: "core-windows-latest-unstable"
8378
service: "core_windows"
@@ -131,10 +126,6 @@ jobs:
131126
fail-fast: false
132127
matrix:
133128
include:
134-
- docker-image: "windows-latest"
135-
experimental: false
136-
- docker-image: "windows-latest-unstable"
137-
experimental: true
138129
- docker-image: "core-windows-latest"
139130
experimental: false
140131
- docker-image: "core-windows-latest-unstable"
@@ -144,11 +135,8 @@ jobs:
144135
- name: Calculate SKIP_UNSTABLE
145136
if: matrix.experimental
146137
run: |
147-
# Choose the manifests output to consider (for DMS or Core service)
148-
# based on the matrix value
149-
if ("${{ matrix.docker-image }}" -eq "windows-latest-unstable") {
150-
$ImagesAreEqual = ${{ needs.manifests.outputs.skip_dms }}
151-
} elseif ("${{ matrix.docker-image }}" -eq "core-windows-latest-unstable") {
138+
# Choose the manifests output to consider based on the matrix value
139+
if ("${{ matrix.docker-image }}" -eq "core-windows-latest-unstable") {
152140
$ImagesAreEqual = ${{ needs.manifests.outputs.skip_core_windows }}
153141
} else {
154142
Write-Output "Unknown docker image"
@@ -267,7 +255,7 @@ jobs:
267255

268256
- name: Upload coverage to Codecov
269257
uses: codecov/codecov-action@v5
270-
if: matrix.docker-image == 'windows-latest'
258+
if: matrix.docker-image == 'core-windows-latest'
271259
env:
272260
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
273261
with:
@@ -310,9 +298,11 @@ jobs:
310298
if: github.ref != 'refs/heads/blitz'
311299
run: |
312300
git fetch origin blitz
313-
git diff --name-only origin/blitz doc/source/ | grep -q .
314-
# Set the output variable to true if modifications are made to the docs folder
315-
echo "build_docs=$(test $? -eq 0 && echo true || echo false)" >> $GITHUB_ENV
301+
if [ -n "$(git diff --name-only origin/blitz doc/source/)" ]; then
302+
echo "build_docs=true" >> $GITHUB_ENV
303+
else
304+
echo "build_docs=false" >> $GITHUB_ENV
305+
fi
316306
317307
- name: Always run on the blitz branch
318308
if: github.ref == 'refs/heads/blitz'
@@ -322,19 +312,21 @@ jobs:
322312
id: docs-build-required
323313
run: echo "build_required=${{ env.build_docs }}" >> $GITHUB_OUTPUT
324314

315+
# =================================================================================================
316+
# ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ RUNNING ON SELF-HOSTED RUNNER ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
317+
# =================================================================================================
318+
325319
docs:
326320
name: Documentation
327321
needs: [is_docs_pr]
328-
runs-on: [self-hosted, Windows, pygeometry]
322+
runs-on: ubuntu-latest
329323
# Only run if docs build is required
330324
if: ${{ needs.is_docs_pr.outputs.build_required == 'true' }}
331325
env:
332326
PYVISTA_OFF_SCREEN: true
333327
steps:
334328
- name: Set up headless display
335329
uses: pyvista/setup-headless-display-action@v3
336-
with:
337-
pyvista: false
338330

339331
- name: Login to GitHub Container Registry
340332
uses: docker/login-action@v3
@@ -343,31 +335,19 @@ jobs:
343335
username: ${{ github.actor }}
344336
password: ${{ secrets.GITHUB_TOKEN }}
345337

346-
- name: Download Geometry service container (if needed)
347-
run: docker pull ${{ env.ANSRV_GEO_IMAGE_DOCS_TAG }}
348-
349-
- name: Check location of self-hosted runner and define license server accordingly
350-
if: runner.name == 'pygeometry-ci-2'
351-
run:
352-
echo "ANSRV_GEO_LICENSE_SERVER=${{ secrets.INTERNAL_LICENSE_SERVER }}" | Out-File -FilePath $env:GITHUB_ENV -Append
353-
354-
- name: Stop any running containers
338+
- name: Pull and launch geometry service
355339
run: |
356-
$dockerContainers = docker ps -a -q
357-
if (-not [string]::IsNullOrEmpty($dockerContainers)) {
358-
docker stop $dockerContainers
359-
docker rm $dockerContainers
360-
}
361-
362-
- name: Start Geometry service and verify start
363-
run: docker run --detach --name ${{ env.GEO_CONT_NAME }} -e LICENSE_SERVER=${{ env.ANSRV_GEO_LICENSE_SERVER }} -p ${{ env.ANSRV_GEO_PORT }}:50051 ${{ env.ANSRV_GEO_IMAGE_DOCS_TAG }}
340+
docker pull ${{ env.ANSRV_GEO_IMAGE_DOCS_TAG }}
341+
docker run --detach --name ${{ env.GEO_CONT_NAME }} -e LICENSE_SERVER=${{ env.ANSRV_GEO_LICENSE_SERVER }} -p ${{ env.ANSRV_GEO_PORT }}:50051 ${{ env.ANSRV_GEO_IMAGE_DOCS_TAG }}
364342
365343
- name: Run Ansys documentation building action
366344
uses: ansys/actions/doc-build@v8
367345
with:
368346
python-version: ${{ env.MAIN_PYTHON_VERSION }}
369347
add-pdf-html-docs-as-assets: true
370348
needs-quarto: true
349+
dependencies: 'pandoc'
350+
sphinxopts: '-j 1 -W --color'
371351

372352
- name: Stop the Geometry service
373353
if: always()
@@ -376,23 +356,6 @@ jobs:
376356
docker logs ${{ env.GEO_CONT_NAME }}
377357
docker rm ${{ env.GEO_CONT_NAME }}
378358
379-
- name: Stop any remaining containers
380-
if: always()
381-
run: |
382-
$dockerContainers = docker ps -a -q
383-
if (-not [string]::IsNullOrEmpty($dockerContainers)) {
384-
docker stop $dockerContainers
385-
docker rm $dockerContainers
386-
}
387-
388-
- name: Clean all Docker dangling images
389-
if: always()
390-
run: docker image prune -f
391-
392-
# =================================================================================================
393-
# ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ RUNNING ON SELF-HOSTED RUNNER ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
394-
# =================================================================================================
395-
396359
testing-linux:
397360
name: Testing and coverage (Linux)
398361
needs: [manifests]

.github/workflows/docker_ansyslab_windows.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ permissions:
1212
packages: read
1313

1414
env:
15-
WINDOWS_STABLE_GHCR: ghcr.io/ansys/geometry:windows-latest
16-
WINDOWS_STABLE_FUJI: azwepsifujiaksacr.azurecr.io/ansys/discovery/geometry:windows-latest
15+
WINDOWS_STABLE_GHCR: ghcr.io/ansys/geometry:core-windows-latest
16+
WINDOWS_STABLE_FUJI: azwepsifujiaksacr.azurecr.io/ansys/discovery/geometry:core-windows-latest
1717

1818
jobs:
1919
windows-ansyslab:

0 commit comments

Comments
 (0)