feat: verifying Linux service also accepts colors (#1451)

Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: 3 people

.github/workflows/ci_cd.yml

@@ -17,7 +17,7 @@ env:
   ANSRV_GEO_PORT: 700
   ANSRV_GEO_LICENSE_SERVER: ${{ secrets.LICENSE_SERVER }}
   GEO_CONT_NAME: ans_geo
-  RESET_IMAGE_CACHE: 3
+  RESET_IMAGE_CACHE: 4
   IS_WORKFLOW_RUNNING: True
   ARTIFACTORY_VERSION: v251
 

doc/changelog.d/1451.added.md

@@ -0,0 +1 @@
+verifying Linux service also accepts colors

src/ansys/geometry/core/designer/body.py

@@ -54,7 +54,6 @@
     ProjectCurvesRequest,
 )
 from ansys.api.geometry.v0.commands_pb2_grpc import CommandsStub
-from ansys.geometry.core.connection.backend import BackendType
 from ansys.geometry.core.connection.client import GrpcClient
 from ansys.geometry.core.connection.conversions import (
     frame_to_grpc_frame,
@@ -768,13 +767,7 @@ def color(self) -> str:  # noqa: D102
             # Assigning default value first
             self._color = Color.DEFAULT.value
 
-            # TODO: Remove this check when the Linux service backend supports color setting
-            # https://github.com/ansys/pyansys-geometry/issues/1383
-            if self._grpc_client.backend_type == BackendType.LINUX_SERVICE:
-                self._grpc_client.log.warning(
-                    "Colors are not supported in the Linux backend. Default value assigned..."
-                )
-            elif self._grpc_client.backend_version < (25, 1, 0):  # pragma: no cover
+            if self._grpc_client.backend_version < (25, 1, 0):  # pragma: no cover
                 # Server does not support color retrieval before version 25.1.0
                 self._grpc_client.log.warning(
                     "Server does not support color retrieval. Default value assigned..."
@@ -990,15 +983,6 @@ def set_color(self, color: str | tuple[float, float, float]) -> None:
         """Set the color of the body."""
         self._grpc_client.log.debug(f"Setting body color of {self.id} to {color}.")
 
-        # TODO: Remove this check when the Linux service backend supports color setting
-        # https://github.com/ansys/pyansys-geometry/issues/1383
-        if self._grpc_client.backend_type == BackendType.LINUX_SERVICE:
-            self._grpc_client.log.warning(
-                "Setting color is not supported in the Linux service backend."
-            )
-            self._grpc_client.log.warning("Ignoring request...")
-            return
-
         try:
             if isinstance(color, tuple):
                 # Ensure that all elements are within 0-1 or 0-255 range

tests/integration/test_design.py

@@ -2038,7 +2038,6 @@ def test_set_fill_style(modeler: Modeler):
 
 def test_set_body_color(modeler: Modeler):
     """Test the getting and setting of body color."""
-    skip_if_linux(modeler, test_set_body_color.__name__, "set_color")  # Skip test on Linux
 
     design = modeler.create_design("RVE2")
     unit = DEFAULT_UNITS.LENGTH

tests/integration/test_plotter.py

@@ -664,6 +664,7 @@ def test_visualization_polydata():
     assert box.visualization_polydata.n_open_edges == 4
 
 
+@skip_no_xserver
 def test_plot_design_point(modeler: Modeler, verify_image_cache):
     """Test the plotting of DesignPoint objects."""
     design = modeler.create_design("Multiplot")
@@ -690,7 +691,8 @@ def test_plot_design_point(modeler: Modeler, verify_image_cache):
     )
 
 
-def test_plot_revolve_sketch_normal(modeler: Modeler):
+@skip_no_xserver
+def test_plot_revolve_sketch_normal(modeler: Modeler, verify_image_cache):
     """Test plotting of a sketch revolved around an axis."""
     # Initialize the donut sketch design
     design = modeler.create_design("quarter-donut")
@@ -725,7 +727,8 @@ def test_plot_revolve_sketch_normal(modeler: Modeler):
     )
 
 
-def test_plot_revolve_sketch_negative_angle(modeler: Modeler):
+@skip_no_xserver
+def test_plot_revolve_sketch_negative_angle(modeler: Modeler, verify_image_cache):
     """Test plotting of a sketch revolved around an axis with a negative
     angle.
     """
@@ -762,7 +765,10 @@ def test_plot_revolve_sketch_negative_angle(modeler: Modeler):
     )
 
 
-def test_plot_server_colors_on_design(modeler: Modeler, use_service_colors: None):
+@skip_no_xserver
+def test_plot_server_colors_on_design(
+    modeler: Modeler, use_service_colors: None, verify_image_cache
+):
     """Test plotting of a design with server colors."""
     # The following design is created:
     #
@@ -797,7 +803,10 @@ def test_plot_server_colors_on_design(modeler: Modeler, use_service_colors: None
     design.plot(screenshot=Path(IMAGE_RESULTS_DIR, "plot_server_colors_on_design.png"))
 
 
-def test_plot_server_color_on_single_body(modeler: Modeler, use_service_colors: None):
+@skip_no_xserver
+def test_plot_server_color_on_single_body(
+    modeler: Modeler, use_service_colors: None, verify_image_cache
+):
     """Test plotting of a single body with server colors."""
     design = modeler.create_design("ServerColorsBody")
 
@@ -810,7 +819,10 @@ def test_plot_server_color_on_single_body(modeler: Modeler, use_service_colors:
     body.plot(screenshot=Path(IMAGE_RESULTS_DIR, "plot_server_color_on_single_body.png"))
 
 
-def test_plot_server_colors_on_design_using_input(modeler: Modeler, use_service_colors: None):
+@skip_no_xserver
+def test_plot_server_colors_on_design_using_input(
+    modeler: Modeler, use_service_colors: None, verify_image_cache
+):
     """Test plotting of a design with server colors (via argument)."""
     # The following design is created:
     #
@@ -848,7 +860,8 @@ def test_plot_server_colors_on_design_using_input(modeler: Modeler, use_service_
     )
 
 
-def test_plot_server_color_on_single_body_using_input(modeler: Modeler):
+@skip_no_xserver
+def test_plot_server_color_on_single_body_using_input(modeler: Modeler, verify_image_cache):
     """Test plotting of a single body with server colors (via argument)."""
     design = modeler.create_design("ServerColorsBodyUsingInput")