Skip to content

Commit 35178fc

Browse files
RobPasMueRobPasMue
committed
ci: zizmor fixes (auto)
1 parent 6546de8 commit 35178fc

File tree

5 files changed

+69
-43
lines changed

5 files changed

+69
-43
lines changed

‎.github/workflows/backwards_compatibility.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,8 @@ jobs:
4848
backend-version: "25.2"
4949
steps:
5050
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
51+
with:
52+
persist-credentials: false
5153

5254
- name: Set up Python
5355
uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6.0.0

‎.github/workflows/ci_cd.yml‎

Lines changed: 50 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,8 @@ jobs:
197197
198198
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
199199
if: env.SKIP_UNSTABLE == 'false'
200+
with:
201+
persist-credentials: false
200202

201203
- name: Set up Python
202204
if: env.SKIP_UNSTABLE == 'false'
@@ -342,8 +344,8 @@ jobs:
342344

343345
- name: Pull and launch geometry service
344346
run: |
345-
docker pull ${{ env.ANSRV_GEO_IMAGE_DOCS_TAG }}
346-
docker run --detach --name ${{ env.GEO_CONT_NAME }} -e LICENSE_SERVER=${{ env.ANSRV_GEO_LICENSE_SERVER }} -p ${{ env.ANSRV_GEO_PORT }}:50051 ${{ env.ANSRV_GEO_IMAGE_DOCS_TAG }} ${{ secrets.TRANSPORT_MODE_SELECTION }}
347+
docker pull ${ANSRV_GEO_IMAGE_DOCS_TAG}
348+
docker run --detach --name ${GEO_CONT_NAME} -e LICENSE_SERVER=${ANSRV_GEO_LICENSE_SERVER} -p ${ANSRV_GEO_PORT}:50051 ${ANSRV_GEO_IMAGE_DOCS_TAG} ${{ secrets.TRANSPORT_MODE_SELECTION }}
347349
348350
- name: Run Ansys documentation building action
349351
uses: ansys/actions/doc-build@123a1f17d71f117e0ba29c53d6a0f602e0d8d902 # v10.1.3
@@ -357,9 +359,9 @@ jobs:
357359
- name: Stop the Geometry service
358360
if: always()
359361
run: |
360-
docker stop ${{ env.GEO_CONT_NAME }}
361-
docker logs ${{ env.GEO_CONT_NAME }}
362-
docker rm ${{ env.GEO_CONT_NAME }}
362+
docker stop ${GEO_CONT_NAME}
363+
docker logs ${GEO_CONT_NAME}
364+
docker rm ${GEO_CONT_NAME}
363365
364366
testing-linux:
365367
name: Testing and coverage (Linux)
@@ -384,13 +386,13 @@ jobs:
384386
# Choose the manifests output to consider (for Core service)
385387
# based on the matrix value
386388
if [[ "${{ matrix.docker-image }}" == "core-linux-latest-unstable" ]]; then
387-
ImagesAreEqual=${{ needs.manifests.outputs.skip_core_linux }}
389+
ImagesAreEqual=${NEEDS_MANIFESTS_OUTPUTS_SKIP_CORE_LINUX}
388390
else
389391
echo "Unknown docker image"
390392
exit 1
391393
fi
392394
393-
A=$([[ "${{ vars.SKIP_UNSTABLE_CONTAINERS_TEMPORARILY }}" == "1" ]] && echo true || echo false)
395+
A=$([[ "${VARS_SKIP_UNSTABLE_CONTAINERS_TEMPORARILY}" == "1" ]] && echo true || echo false)
394396
B=$([[ "$ImagesAreEqual" == "1" ]] && echo true || echo false)
395397
396398
# Calculate the logical expression
@@ -399,6 +401,9 @@ jobs:
399401
# Export it as an environment variable with true/false value
400402
echo "SKIP_UNSTABLE=$Result" >> $GITHUB_ENV
401403
echo "SKIP_UNSTABLE will be: $Result"
404+
env:
405+
NEEDS_MANIFESTS_OUTPUTS_SKIP_CORE_LINUX: ${{ needs.manifests.outputs.skip_core_linux }}
406+
VARS_SKIP_UNSTABLE_CONTAINERS_TEMPORARILY: ${{ vars.SKIP_UNSTABLE_CONTAINERS_TEMPORARILY }}
402407

403408
- name: Set up headless display
404409
if: env.SKIP_UNSTABLE == 'false'
@@ -415,12 +420,14 @@ jobs:
415420
- name: Pull and launch geometry service
416421
if: env.SKIP_UNSTABLE == 'false'
417422
run: |
418-
docker pull ${{ env.ANSRV_GEO_IMAGE }}:${{ matrix.docker-image }}
419-
docker run --detach --name ${{ env.GEO_CONT_NAME }} -e LICENSE_SERVER=${{ env.ANSRV_GEO_LICENSE_SERVER }} -p ${{ env.ANSRV_GEO_PORT }}:50051 ${{ env.ANSRV_GEO_IMAGE }}:${{ matrix.docker-image }} ${{ secrets.TRANSPORT_MODE_SELECTION }}
423+
docker pull ${ANSRV_GEO_IMAGE}:${{ matrix.docker-image }}
424+
docker run --detach --name ${GEO_CONT_NAME} -e LICENSE_SERVER=${ANSRV_GEO_LICENSE_SERVER} -p ${ANSRV_GEO_PORT}:50051 ${ANSRV_GEO_IMAGE}:${{ matrix.docker-image }} ${{ secrets.TRANSPORT_MODE_SELECTION }}
420425
421426
- name: Checkout repository
422427
if: env.SKIP_UNSTABLE == 'false'
423428
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
429+
with:
430+
persist-credentials: false
424431

425432
- name: Restore images cache
426433
if: env.SKIP_UNSTABLE == 'false'
@@ -467,11 +474,11 @@ jobs:
467474
- name: Stop the Geometry service
468475
if: always()
469476
run: |
470-
if [[ ${{ env.SKIP_UNSTABLE }} == 'false' ]];
477+
if [[ ${SKIP_UNSTABLE} == 'false' ]];
471478
then
472-
docker stop ${{ env.GEO_CONT_NAME }}
473-
docker logs ${{ env.GEO_CONT_NAME }}
474-
docker rm ${{ env.GEO_CONT_NAME }}
479+
docker stop ${GEO_CONT_NAME}
480+
docker logs ${GEO_CONT_NAME}
481+
docker rm ${GEO_CONT_NAME}
475482
fi
476483
477484
testing-min-reqs:
@@ -497,6 +504,8 @@ jobs:
497504

498505
- name: Checkout repository
499506
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
507+
with:
508+
persist-credentials: false
500509

501510
- name: Setup Python ${{ matrix.python-version }}
502511
uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6.0.0
@@ -511,8 +520,8 @@ jobs:
511520
512521
- name: Start Geometry service and verify start
513522
run: |
514-
docker pull ${{ env.ANSRV_GEO_IMAGE_MINREQS }}
515-
docker run --detach --name ${{ env.GEO_CONT_NAME }} -e LICENSE_SERVER=${{ env.ANSRV_GEO_LICENSE_SERVER }} -p ${{ env.ANSRV_GEO_PORT }}:50051 ${{ env.ANSRV_GEO_IMAGE_MINREQS }} ${{ secrets.TRANSPORT_MODE_SELECTION }}
523+
docker pull ${ANSRV_GEO_IMAGE_MINREQS}
524+
docker run --detach --name ${GEO_CONT_NAME} -e LICENSE_SERVER=${ANSRV_GEO_LICENSE_SERVER} -p ${ANSRV_GEO_PORT}:50051 ${ANSRV_GEO_IMAGE_MINREQS} ${{ secrets.TRANSPORT_MODE_SELECTION }}
516525
python -c "from ansys.geometry.core.connection.validate import validate; validate()"
517526
518527
- name: Run pytest
@@ -522,9 +531,9 @@ jobs:
522531
- name: Stop the Geometry service
523532
if: always()
524533
run: |
525-
docker stop ${{ env.GEO_CONT_NAME }}
526-
docker logs ${{ env.GEO_CONT_NAME }}
527-
docker rm ${{ env.GEO_CONT_NAME }}
534+
docker stop ${GEO_CONT_NAME}
535+
docker logs ${GEO_CONT_NAME}
536+
docker rm ${GEO_CONT_NAME}
528537
529538
testing-min-reqs-tracker:
530539
name: Testing with minimum requirements with tracker
@@ -549,6 +558,8 @@ jobs:
549558

550559
- name: Checkout repository
551560
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
561+
with:
562+
persist-credentials: false
552563

553564
- name: Setup Python ${{ matrix.python-version }}
554565
uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6.0.0
@@ -563,8 +574,8 @@ jobs:
563574
564575
- name: Start Geometry service and verify start
565576
run: |
566-
docker pull ${{ env.ANSRV_GEO_IMAGE_MINREQS }}
567-
docker run --detach --name ${{ env.GEO_CONT_NAME }} -e LICENSE_SERVER=${{ env.ANSRV_GEO_LICENSE_SERVER }} -p ${{ env.ANSRV_GEO_PORT }}:50051 ${{ env.ANSRV_GEO_IMAGE_MINREQS }} ${{ secrets.TRANSPORT_MODE_SELECTION }}
577+
docker pull ${ANSRV_GEO_IMAGE_MINREQS}
578+
docker run --detach --name ${GEO_CONT_NAME} -e LICENSE_SERVER=${ANSRV_GEO_LICENSE_SERVER} -p ${ANSRV_GEO_PORT}:50051 ${ANSRV_GEO_IMAGE_MINREQS} ${{ secrets.TRANSPORT_MODE_SELECTION }}
568579
python -c "from ansys.geometry.core.connection.validate import validate; validate()"
569580
570581
- name: Run pytest
@@ -574,9 +585,9 @@ jobs:
574585
- name: Stop the Geometry service
575586
if: always()
576587
run: |
577-
docker stop ${{ env.GEO_CONT_NAME }}
578-
docker logs ${{ env.GEO_CONT_NAME }}
579-
docker rm ${{ env.GEO_CONT_NAME }}
588+
docker stop ${GEO_CONT_NAME}
589+
docker logs ${GEO_CONT_NAME}
590+
docker rm ${GEO_CONT_NAME}
580591
581592
testing-no-graphics:
582593
name: Testing with minimum requirements (no graphics)
@@ -598,6 +609,8 @@ jobs:
598609

599610
- name: Checkout repository
600611
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
612+
with:
613+
persist-credentials: false
601614

602615
- name: Setup Python ${{ matrix.python-version }}
603616
uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6.0.0
@@ -615,8 +628,8 @@ jobs:
615628
616629
- name: Start Geometry service and verify start
617630
run: |
618-
docker pull ${{ env.ANSRV_GEO_IMAGE_MINREQS }}
619-
docker run --detach --name ${{ env.GEO_CONT_NAME }} -e LICENSE_SERVER=${{ env.ANSRV_GEO_LICENSE_SERVER }} -p ${{ env.ANSRV_GEO_PORT }}:50051 ${{ env.ANSRV_GEO_IMAGE_MINREQS }} ${{ secrets.TRANSPORT_MODE_SELECTION }}
631+
docker pull ${ANSRV_GEO_IMAGE_MINREQS}
632+
docker run --detach --name ${GEO_CONT_NAME} -e LICENSE_SERVER=${ANSRV_GEO_LICENSE_SERVER} -p ${ANSRV_GEO_PORT}:50051 ${ANSRV_GEO_IMAGE_MINREQS} ${{ secrets.TRANSPORT_MODE_SELECTION }}
620633
python -c "from ansys.geometry.core.connection.validate import validate; validate()"
621634
622635
- name: Run pytest
@@ -626,9 +639,9 @@ jobs:
626639
- name: Stop the Geometry service
627640
if: always()
628641
run: |
629-
docker stop ${{ env.GEO_CONT_NAME }}
630-
docker logs ${{ env.GEO_CONT_NAME }}
631-
docker rm ${{ env.GEO_CONT_NAME }}
642+
docker stop ${GEO_CONT_NAME}
643+
docker logs ${GEO_CONT_NAME}
644+
docker rm ${GEO_CONT_NAME}
632645
633646
package:
634647
name: Package library
@@ -666,6 +679,7 @@ jobs:
666679
with:
667680
repository: 'ansys/pyansys-geometry-binaries'
668681
token: ${{ secrets.BINARIES_TOKEN }}
682+
persist-credentials: true
669683

670684
- name: Download binaries (if conditions met)
671685
if: env.REUSE_LAST_ARTIFACTS == 'false'
@@ -736,6 +750,8 @@ jobs:
736750
steps:
737751
- name: Checkout repository
738752
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
753+
with:
754+
persist-credentials: false
739755

740756
- name: Set up headless display
741757
uses: pyvista/setup-headless-display-action@7d84ae825e6d9297a8e99bdbbae20d1b919a0b19 # v4.2
@@ -833,6 +849,8 @@ jobs:
833849
steps:
834850
- name: Checkout repository
835851
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
852+
with:
853+
persist-credentials: false
836854

837855
- name: Set up Python
838856
uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6.0.0
@@ -860,7 +878,7 @@ jobs:
860878
861879
- name: Start Geometry service and verify start
862880
run: |
863-
docker run --detach --name ${{ env.GEO_CONT_NAME }} -e LICENSE_SERVER=${{ env.ANSRV_GEO_LICENSE_SERVER }} -p ${{ env.ANSRV_GEO_PORT }}:50051 ghcr.io/ansys/geometry:linux-tmp ${{ secrets.TRANSPORT_MODE_SELECTION }}
881+
docker run --detach --name ${GEO_CONT_NAME} -e LICENSE_SERVER=${ANSRV_GEO_LICENSE_SERVER} -p ${ANSRV_GEO_PORT}:50051 ghcr.io/ansys/geometry:linux-tmp ${{ secrets.TRANSPORT_MODE_SELECTION }}
864882
python -c "from ansys.geometry.core.connection.validate import validate; validate()"
865883
866884
- name: Restore images cache
@@ -896,9 +914,9 @@ jobs:
896914
- name: Stop the Geometry service
897915
if: always()
898916
run: |
899-
docker stop ${{ env.GEO_CONT_NAME }}
900-
docker logs ${{ env.GEO_CONT_NAME }}
901-
docker rm ${{ env.GEO_CONT_NAME }}
917+
docker stop ${GEO_CONT_NAME}
918+
docker logs ${GEO_CONT_NAME}
919+
docker rm ${GEO_CONT_NAME}
902920
903921
release:
904922
name: Release project to GitHub

‎.github/workflows/codeql.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ jobs:
2020
steps:
2121
- name: Checkout repository
2222
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
23+
with:
24+
persist-credentials: false
2325

2426
- name: Initialize CodeQL
2527
uses: github/codeql-action/init@3599b3baa15b485a2e49ef411a7a4bb2452e7f93 # v3.30.5

‎.github/workflows/label.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ jobs:
2424
pull-requests: write
2525
steps:
2626
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
27+
with:
28+
persist-credentials: false
2729
- uses: micnncim/action-label-syncer@3abd5ab72fda571e69fffd97bd4e0033dd5f495c # v1.3.0
2830
env:
2931
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

‎.github/workflows/nightly_docker_test.yml‎

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,8 @@ jobs:
9797
PYVISTA_OFF_SCREEN: true
9898
steps:
9999
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
100+
with:
101+
persist-credentials: false
100102

101103
- name: Set up Python
102104
uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6.0.0
@@ -215,8 +217,8 @@ jobs:
215217

216218
- name: Pull and launch geometry service
217219
run: |
218-
docker pull ${{ env.ANSRV_GEO_IMAGE_LINUX_CORE_TAG }}
219-
docker run --detach --name ${{ env.GEO_CONT_NAME }} -e LICENSE_SERVER=${{ env.ANSRV_GEO_LICENSE_SERVER }} -p ${{ env.ANSRV_GEO_PORT }}:50051 ${{ env.ANSRV_GEO_IMAGE_LINUX_CORE_TAG }} ${{ secrets.TRANSPORT_MODE_SELECTION }}
220+
docker pull ${ANSRV_GEO_IMAGE_LINUX_CORE_TAG}
221+
docker run --detach --name ${GEO_CONT_NAME} -e LICENSE_SERVER=${ANSRV_GEO_LICENSE_SERVER} -p ${ANSRV_GEO_PORT}:50051 ${ANSRV_GEO_IMAGE_LINUX_CORE_TAG} ${{ secrets.TRANSPORT_MODE_SELECTION }}
220222
221223
- name: Set up headless display
222224
uses: pyvista/setup-headless-display-action@7d84ae825e6d9297a8e99bdbbae20d1b919a0b19 # v4.2
@@ -231,9 +233,9 @@ jobs:
231233
- name: Stop the Geometry service
232234
if: always()
233235
run: |
234-
docker stop ${{ env.GEO_CONT_NAME }}
235-
docker logs ${{ env.GEO_CONT_NAME }}
236-
docker rm ${{ env.GEO_CONT_NAME }}
236+
docker stop ${GEO_CONT_NAME}
237+
docker logs ${GEO_CONT_NAME}
238+
docker rm ${GEO_CONT_NAME}
237239
238240
- name: Microsoft Teams Notification
239241
uses: skitionek/notify-microsoft-teams@11e40c38c3a629ae65a985b582eca4897b01e79e # v1.0.9
@@ -280,13 +282,13 @@ jobs:
280282
password: ${{ secrets.GITHUB_TOKEN }}
281283

282284
- name: Pull Windows latest unstable container
283-
run: docker pull ${{ env.WINDOWS_UNSTABLE }}
285+
run: docker pull $env:WINDOWS_UNSTABLE
284286

285287
- name: Tag container as latest (stable) for Github Container registry
286-
run: docker tag ${{ env.WINDOWS_UNSTABLE }} ${{ env.WINDOWS_STABLE_GHCR }}
288+
run: docker tag $env:WINDOWS_UNSTABLE $env:WINDOWS_STABLE_GHCR
287289

288290
- name: Publish latest stable container in ghcr.io
289-
run: docker push ${{ env.WINDOWS_STABLE_GHCR }}
291+
run: docker push $env:WINDOWS_STABLE_GHCR
290292

291293
promote-linux:
292294
needs: linux-tests
@@ -305,10 +307,10 @@ jobs:
305307
password: ${{ secrets.GITHUB_TOKEN }}
306308

307309
- name: Pull Linux latest unstable container
308-
run: docker pull ${{ env.LINUX_UNSTABLE }}
310+
run: docker pull ${LINUX_UNSTABLE}
309311

310312
- name: Tag container as latest (stable) for Github Container registry
311-
run: docker tag ${{ env.LINUX_UNSTABLE }} ${{ env.LINUX_STABLE_GHCR }}
313+
run: docker tag ${LINUX_UNSTABLE} ${LINUX_STABLE_GHCR}
312314

313315
- name: Publish latest stable container in ghcr.io
314-
run: docker push ${{ env.LINUX_STABLE_GHCR }}
316+
run: docker push ${LINUX_STABLE_GHCR}

0 commit comments

Comments
 (0)