resolving comments on PR

added version checking for new options
add logger warning for when the backend is older but the user supplies options

Author: jacobrkerstetter

src/ansys/geometry/core/_grpc/_services/base/repair_tools.py

@@ -42,7 +42,7 @@ class GRPCRepairToolsService(ABC):  # pragma: no cover
 
     def __init__(self, channel: grpc.Channel):
         """Initialize the gRPC repair tools service."""
-        pass  # pragma: no cover
+        pass
 
     @abstractmethod
     def find_split_edges(self, **kwargs) -> dict:
@@ -117,7 +117,7 @@ def find_and_fix_simplify(self, **kwargs) -> dict:
     @abstractmethod
     def find_and_fix_stitch_faces(self, **kwargs) -> dict:
         """Identify and stitch faces in the geometry."""
-        pass  # pragma: no cover
+        pass
 
     @abstractmethod
     def inspect_geometry(self, **kwargs) -> dict:

src/ansys/geometry/core/_grpc/_services/v0/repair_tools.py

@@ -173,12 +173,26 @@ def find_missing_faces(self, **kwargs) -> dict:  # noqa: D102
         from google.protobuf.wrappers_pb2 import DoubleValue
 
         from ansys.api.geometry.v0.repairtools_pb2 import FindMissingFacesRequest
+        from ansys.geometry.core.logger import LOG
 
         from ..base.conversions import (
             from_measurement_to_server_angle,
             from_measurement_to_server_length,
         )
 
+        # Check the backend version to set optional parameters
+        if kwargs["backend_version"] < (26, 1, 0) and (
+            kwargs["angle"] is not None or kwargs["distance"] is not None):
+            # If the backend version is less than 26.1.0, set angle and distance to None
+            kwargs["angle"] = None
+            kwargs["distance"] = None
+
+            # Log a warning
+            LOG.warning(
+                "The backend version is less than 26.1.0, so angle and distance parameters will be"
+                "ignored. Please update the backend to use these parameters."
+            )
+
         # Create the request - assumes all inputs are valid and of the proper type
         request = FindMissingFacesRequest(
             faces=kwargs["faces"],
@@ -209,12 +223,26 @@ def find_small_faces(self, **kwargs) -> dict:  # noqa: D102
         from google.protobuf.wrappers_pb2 import DoubleValue
 
         from ansys.api.geometry.v0.repairtools_pb2 import FindSmallFacesRequest
+        from ansys.geometry.core.logger import LOG
 
         from ..base.conversions import (
             from_measurement_to_server_area,
             from_measurement_to_server_length,
         )
 
+        # Check the backend version to set optional parameters
+        if kwargs["backend_version"] < (26, 1, 0) and (
+            kwargs["area"] is not None or kwargs["width"] is not None):
+            # If the backend version is less than 26.1.0, set area and width to None
+            kwargs["area"] = None
+            kwargs["width"] = None
+
+            # Log a warning
+            LOG.warning(
+                "The backend version is less than 26.1.0, so area and width parameters will be"
+                "ignored. Please update the backend to use these parameters."
+            )
+
         # Create the request - assumes all inputs are valid and of the proper type
         request = FindSmallFacesRequest(
             selection=kwargs["selection"],
@@ -245,9 +273,18 @@ def find_stitch_faces(self, **kwargs) -> dict:  # noqa: D102
         from google.protobuf.wrappers_pb2 import DoubleValue
 
         from ansys.api.geometry.v0.repairtools_pb2 import FindStitchFacesRequest
+        from ansys.geometry.core.logger import LOG
 
         from ..base.conversions import from_measurement_to_server_length
 
+        if kwargs["backend_version"] < (26, 1, 0) and kwargs["distance"] is not None:
+            # If the backend version is less than 26.1.0, set distance to None and log warning
+            kwargs["distance"] = None
+            LOG.warning(
+                "The backend version is less than 26.1.0, so distance parameter will be ignored. "
+            )
+
+
         # Create the request - assumes all inputs are valid and of the proper type
         request = FindStitchFacesRequest(
             faces=kwargs["faces"],

src/ansys/geometry/core/tools/repair_tools.py

@@ -259,8 +259,10 @@ def find_missing_faces(
             List of bodies that missing faces are investigated on.
         angle : Angle | ~pint.Quantity | Real, optional
             The minimum angle between faces. By default, None.
+            This option is only used if the backend version is 26.1 or higher.
         distance : Distance | ~pint.Quantity | Real, optional
             The minimum distance between faces. By default, None.
+            This option is only used if the backend version is 26.1 or higher.
 
         Returns
         -------
@@ -281,6 +283,7 @@ def find_missing_faces(
             faces=body_ids,
             angle=angle,
             distance=distance,
+            backend_version=self._grpc_client.backend_version,
         )
         parent_design = get_design_from_body(bodies[0])
 
@@ -310,8 +313,10 @@ def find_small_faces(
             List of bodies that small faces are investigated on.
         area : Area | ~pint.Quantity | Real, optional
             Maximum area of the faces. By default, None.
+            This option is only used if the backend version is 26.1 or higher.
         width : Distance | ~pint.Quantity | Real, optional
             Maximum width of the faces. By default, None.
+            This option is only used if the backend version is 26.1 or higher.
 
         Returns
         -------
@@ -332,6 +337,7 @@ def find_small_faces(
             selection=body_ids,
             area=area,
             width=width,
+            backend_version=self._grpc_client.backend_version,
         )
         parent_design = get_design_from_body(bodies[0])
 
@@ -360,6 +366,7 @@ def find_stitch_faces(
             List of bodies that stitchable faces are investigated on.
         max_distance : Distance | ~pint.Quantity | Real, optional
             Maximum distance between faces. By default, None.
+            This option is only used if the backend version is 26.1 or higher.
 
         Returns
         -------
@@ -379,6 +386,7 @@ def find_stitch_faces(
         response = self._grpc_client.services.repair_tools.find_stitch_faces(
             faces=body_ids,
             distance=max_distance,
+            backend_version=self._grpc_client.backend_version,
         )
         parent_design = get_design_from_body(bodies[0])
         return [