renaming

Author: umutsoysalansys

src/ansys/geometry/core/designer/design.py

@@ -79,7 +79,7 @@
 from ansys.geometry.core.misc.checks import ensure_design_is_active, min_backend_version
 from ansys.geometry.core.misc.measurements import DEFAULT_UNITS, Distance
 from ansys.geometry.core.modeler import Modeler
-from ansys.geometry.core.parameters import driving_dimensions
+from ansys.geometry.core.parameters.driving_dimensions import DrivingDimension as DrivingDimension
 from ansys.geometry.core.typing import RealSequence
 
 
@@ -118,7 +118,7 @@ class Design(Component):
     _materials: list[Material]
     _named_selections: dict[str, NamedSelection]
     _beam_profiles: dict[str, BeamProfile]
-    _driving_dimensions: list[driving_dimensions.DrivingDimension]
+    _driving_dimensions: list[DrivingDimension]
 
     @protect_grpc
     @check_input_types
@@ -132,7 +132,7 @@ def __init__(self, name: str, modeler: Modeler, read_existing_design: bool = Fal
         self._materials_stub = MaterialsStub(self._grpc_client.channel)
         self._named_selections_stub = NamedSelectionsStub(self._grpc_client.channel)
         self._parts_stub = PartsStub(self._grpc_client.channel)
-        self._paremeters_stub = DrivingDimensionsStub(self._grpc_client.channel)
+        self._parameters_stub = DrivingDimensionsStub(self._grpc_client.channel)
 
         # Initialize needed instance variables
         self._materials = []
@@ -175,7 +175,7 @@ def beam_profiles(self) -> list[BeamProfile]:
         return list(self._beam_profiles.values())
 
     @property
-    def driving_dimensions(self) -> list[driving_dimensions.DrivingDimension]:
+    def driving_dimensions(self) -> list[DrivingDimension]:
         """List of driving dimensions available for the design."""
         return self.get_all_driving_dimensions()
 
@@ -680,25 +680,19 @@ def get_all_driving_dimensions(self):
         List[DrivingDimension]
             List of driving dimensions for the design.
         """
-        response = self._paremeters_stub.GetAll(GetAllRequest())
-        print(response)
+        response = self._parameters_stub.GetAll(GetAllRequest())
         return [
-            driving_dimensions.DrivingDimension._from_proto(dimension)
-            for dimension in response.driving_dimensions
+            DrivingDimension._from_proto(dimension) for dimension in response.driving_dimensions
         ]
 
     @protect_grpc
     @check_input_types
     @min_backend_version(25, 1, 0)
-    def set_driving_dimensions(
-        self, driving_dimension: driving_dimensions.DrivingDimension
-    ) -> bool:
-        """Set driving dimensions for a body.
+    def set_driving_dimensions(self, dimension: DrivingDimension) -> bool:
+        """Update a driving dimension of the design.
 
         Parameters
         ----------
-        body : Body
-            Body to set driving dimensions.
         dimensions : List[DrivingDimension]
             List of driving dimensions to set.
 
@@ -707,9 +701,9 @@ def set_driving_dimensions(
         bool
             True if driving dimensions were set successfully.
         """
-        request = UpdateRequest(driving_dimension=driving_dimension._to_proto())
-        response = self._driving_dimensions_stub.Update(request)
-        return response.success
+        request = UpdateRequest(driving_dimension=DrivingDimension._to_proto(dimension))
+        dimension = self._parameters_stub.Update(request)
+        return dimension
 
     @protect_grpc
     @check_input_types

src/ansys/geometry/core/modeler.py

@@ -40,7 +40,6 @@
 from ansys.geometry.core.logger import LOG
 from ansys.geometry.core.misc.checks import check_type, min_backend_version
 from ansys.geometry.core.misc.options import ImportOptions
-from ansys.geometry.core.parameters import DrivingDimensions
 from ansys.geometry.core.tools.measurement_tools import MeasurementTools
 from ansys.geometry.core.tools.prepare_tools import PrepareTools
 from ansys.geometry.core.tools.repair_tools import RepairTools
@@ -125,13 +124,11 @@ def __init__(
             self._repair_tools = None
             self._prepare_tools = None
             self._measurement_tools = None
-            self._driving_dimensions = None
             LOG.warning("Linux backend does not support repair or prepare tools.")
         else:
             self._repair_tools = RepairTools(self._grpc_client)
             self._prepare_tools = PrepareTools(self._grpc_client)
             self._measurement_tools = MeasurementTools(self._grpc_client)
-            self._driving_dimensions = DrivingDimensions(self._grpc_client)
 
         # Maintaining references to all designs within the modeler workspace
         self._designs: dict[str, "Design"] = {}

src/ansys/geometry/core/parameters/__init__.py

@@ -21,4 +21,4 @@
 # SOFTWARE.
 """PyAnsys Geometry parameters subpackage."""
 
-from ansys.geometry.core.parameters.driving_dimensions import DrivingDimensions
+from ansys.geometry.core.parameters.driving_dimensions import DrivingDimension

src/ansys/geometry/core/parameters/driving_dimensions.py renamed to src/ansys/geometry/core/parameters/parameters.py

@@ -24,17 +24,10 @@
 from enum import Enum, unique
 
 from ansys.api.dbu.v0.dbumodels_pb2 import DrivingDimension as DrivingDimensionProto
-from ansys.api.dbu.v0.drivingdimensions_pb2 import UpdateRequest
-from ansys.api.dbu.v0.drivingdimensions_pb2_grpc import DrivingDimensionsStub
-from beartype import beartype as check_input_types
-
-from ansys.geometry.core.connection import GrpcClient
-from ansys.geometry.core.errors import protect_grpc
-from ansys.geometry.core.misc.checks import min_backend_version
 
 
 @unique
-class DrivingDimensionType(Enum):
+class ParameterType(Enum):
     """Provides values for driving dimension types supported."""
 
     DIMENSIONTYPE_UNKNOWN = 0
@@ -50,11 +43,11 @@ class DrivingDimensionType(Enum):
     DIMENSIONTYPE_UNITLESS = 10
 
 
-class DrivingDimension:
-    """Represents a driving dimension."""
+class Parameter:
+    """Represents a parameter."""
 
-    def __init__(self, id, name, dimension_type: DrivingDimensionType, dimension_value):
-        """Initialize Driving Dimension class."""
+    def __init__(self, id, name, dimension_type: ParameterType, dimension_value):
+        """Initialize Parameter class."""
         self.id = id
         self._name = name
         self.dimension_type = dimension_type
@@ -66,7 +59,7 @@ def _from_proto(cls, proto):
         return cls(
             id=proto.id,
             name=proto.name,
-            dimension_type=DrivingDimensionType(proto.dimension_type),
+            dimension_type=ParameterType(proto.dimension_type),
             dimension_value=proto.dimension_value,
         )
 
@@ -98,35 +91,3 @@ def _to_proto(self):
             dimension_type=self.dimension_type.value,
             dimension_value=self.dimension_value,
         )
-
-
-class DrivingDimensions:
-    """Represents Driving Dimensions."""
-
-    def __init__(self, grpc_client: GrpcClient):
-        """Initialize Driving Dimensions class."""
-        self._grpc_client = grpc_client
-        self._driving_dimensions_stub = DrivingDimensionsStub(self._grpc_client.channel)
-        self.id = None
-
-    @protect_grpc
-    @check_input_types
-    @min_backend_version(25, 1, 0)
-    def set_driving_dimensions(self, driving_dimension: DrivingDimension) -> bool:
-        """Set driving dimensions for a body.
-
-        Parameters
-        ----------
-        body : Body
-            Body to set driving dimensions.
-        dimensions : List[DrivingDimension]
-            List of driving dimensions to set.
-
-        Returns
-        -------
-        bool
-            True if driving dimensions were set successfully.
-        """
-        request = UpdateRequest(driving_dimension=driving_dimension._to_proto())
-        response = self._driving_dimensions_stub.Update(request)
-        return response.success