fix: translating sketch issues when using a custom default unit (#1808)

Co-authored-by: pyansys-ci-bot <[email protected]>

Author: RobPasMue

.github/workflows/ci_cd.yml

@@ -310,9 +310,11 @@ jobs:
         if: github.ref != 'refs/heads/blitz'
         run: |
           git fetch origin blitz
-          git diff --name-only origin/blitz doc/source/ | grep -q .
-          # Set the output variable to true if modifications are made to the docs folder
-          echo "build_docs=$(test $? -eq 0 && echo true || echo false)" >> $GITHUB_ENV
+          if [ -n "$(git diff --name-only origin/blitz doc/source/)" ]; then
+            echo "build_docs=true" >> $GITHUB_ENV
+          else
+            echo "build_docs=false" >> $GITHUB_ENV
+          fi
 
       - name: Always run on the blitz branch
         if: github.ref == 'refs/heads/blitz'

doc/changelog.d/1808.fixed.md

@@ -0,0 +1 @@
+translating sketch issues when using a custom default unit

src/ansys/geometry/core/sketch/sketch.py

@@ -28,7 +28,7 @@
 
 from ansys.geometry.core.math.constants import ZERO_POINT2D
 from ansys.geometry.core.math.plane import Plane
-from ansys.geometry.core.math.point import Point2D
+from ansys.geometry.core.math.point import Point2D, Point3D
 from ansys.geometry.core.math.vector import UnitVector3D, Vector2D, Vector3D
 from ansys.geometry.core.misc.checks import graphics_required
 from ansys.geometry.core.misc.measurements import DEFAULT_UNITS, Angle, Distance
@@ -121,16 +121,24 @@ def translate_sketch_plane(self, translation: Vector3D) -> "Sketch":
         Parameters
         ----------
         translation : Vector3D
-            Vector defining the translation. Meters is the expected unit.
+            Vector defining the translation. Default units are the expected
+            units, otherwise it will be inconsistent.
 
         Returns
         -------
         Sketch
             Revised sketch state ready for further sketch actions.
         """
-        self.plane = Plane(
-            self.plane.origin + translation, self.plane.direction_x, self.plane.direction_y
+        new_origin = Point3D(
+            [
+                self.plane.origin.x.m_as(DEFAULT_UNITS.LENGTH) + translation.x,
+                self.plane.origin.y.m_as(DEFAULT_UNITS.LENGTH) + translation.y,
+                self.plane.origin.z.m_as(DEFAULT_UNITS.LENGTH) + translation.z,
+            ]
         )
+        # Set the same unit system as the plane origin
+        new_origin.unit = self.plane.origin.unit
+        self.plane = Plane(new_origin, self.plane.direction_x, self.plane.direction_y)
         return self
 
     @check_input_types

tests/integration/test_issues.py

@@ -33,6 +33,7 @@
     Point2D,
     Point3D,
 )
+from ansys.geometry.core.math.vector import UnitVector3D
 from ansys.geometry.core.misc import DEFAULT_UNITS, UNITS, Angle, Distance
 from ansys.geometry.core.modeler import Modeler
 from ansys.geometry.core.sketch import Sketch
@@ -260,3 +261,31 @@ def test_issue_1724_intersect_failures(modeler: Modeler):
 
     # Verify that the volume of the cylinder is the same (the intersect is the same as the cylinder)
     assert np.isclose(design.bodies[0].volume.m, np.pi * radius**2 * (wz - 0.1))
+
+
+def test_issue_1807_translate_sketch_non_default_units():
+    """Test that translating a sketch with non-default units is handled properly.
+
+    For more info see
+    https://github.com/ansys/pyansys-geometry/issues/1807
+    """
+    try:
+        # Set the default units to mm
+        DEFAULT_UNITS.LENGTH = UNITS.mm
+
+        # Draw a box sketch
+        sketch = Sketch()
+        sketch.box(Point2D([0, 0]), 10, 10)
+
+        # Verify the sketch plane origin
+        assert sketch.plane.origin == Point3D([0, 0, 0])
+
+        # Translate the sketch
+        sketch.translate_sketch_plane_by_distance(UnitVector3D([0, 0, 1]), Distance(10, UNITS.mm))
+
+        # Verify the new sketch plane origin
+        assert sketch.plane.origin == Point3D([0, 0, 10], unit=UNITS.mm)
+
+    finally:
+        # Reset the default units to meters
+        DEFAULT_UNITS.LENGTH = UNITS.meter