resolving comments

Author: jacobrkerstetter

src/ansys/geometry/core/_grpc/_services/v1/conversions.py

@@ -1000,10 +1000,11 @@ def from_grpc_curve_to_curve(curve: GRPCCurveGeometry) -> "Curve":
         # curve will be a line
         pass
 
+    radius = curve.radius.value_in_geometry_units
     major_radius = curve.major_radius.value_in_geometry_units
     minor_radius = curve.minor_radius.value_in_geometry_units
-    if curve.radius.value_in_geometry_units != 0:
-        result = Circle(origin, curve.radius.value_in_geometry_units, reference, axis)
+    if radius != 0:
+        result = Circle(origin, radius, reference, axis)
     elif major_radius != 0 and minor_radius != 0:
         result = Ellipse(origin, major_radius, minor_radius, reference, axis)
     elif curve.nurbs_curve.nurbs_data.degree != 0:

src/ansys/geometry/core/_grpc/_services/v1/edges.py

@@ -58,7 +58,7 @@ def __init__(self, channel: grpc.Channel):  # noqa: D102
         from ansys.api.discovery.v1.operations.edit_pb2_grpc import EditStub
 
         self.stub = EdgeStub(channel)
-        self.EditStub = EditStub(channel)
+        self.edit_stub = EditStub(channel)
 
     @protect_grpc
     def get_edge(self, **kwargs) -> dict:  # noqa: D102
@@ -216,7 +216,7 @@ def extrude_edges(self, **kwargs) -> dict:  # noqa: D102
         )
 
         # Call the gRPC service and serialize the response
-        response = self.EditStub.ExtrudeEdges(request)
+        response = self.edit_stub.ExtrudeEdges(request)
         tracked_response = serialize_tracked_command_response(response.tracked_command_response)
 
         # Return the response - formatted as a dictionary
@@ -248,7 +248,7 @@ def extrude_edges_up_to(self, **kwargs) -> dict:  # noqa: D102
         )
 
         # Call the gRPC service and serialize the response
-        response = self.EditStub.ExtrudeFacesUpTo(request=request)
+        response = self.edit_stub.ExtrudeFacesUpTo(request=request)
         tracked_response = serialize_tracked_command_response(response.tracked_command_response)
 
         # Return the response - formatted as a dictionary
@@ -278,7 +278,7 @@ def move_imprint_edges(self, **kwargs) -> dict:  # noqa: D102
         )
 
         # Call the gRPC service
-        response = self.EditStub.MoveImprintEdges(request)
+        response = self.edit_stub.MoveImprintEdges(request)
 
         # Return the response - formatted as a dictionary
         return {
@@ -303,7 +303,7 @@ def offset_edges(self, **kwargs) -> dict:  # noqa: D102
         )
 
         # Call the gRPC service
-        response = self.EditStub.OffsetEdges(request)
+        response = self.edit_stub.OffsetEdges(request)
 
         # Return the response - formatted as a dictionary
         return {

src/ansys/geometry/core/_grpc/_services/v1/faces.py

@@ -65,7 +65,7 @@ def __init__(self, channel: grpc.Channel):  # noqa: D102
         from ansys.api.discovery.v1.operations.edit_pb2_grpc import EditStub
 
         self.stub = FaceStub(channel)
-        self.EditStub = EditStub(channel)
+        self.edit_stub = EditStub(channel)
 
     @protect_grpc
     def get_surface(self, **kwargs) -> dict:  # noqa: D102
@@ -347,7 +347,7 @@ def extrude_faces(self, **kwargs) -> dict:  # noqa: D102
         )
 
         # Call the gRPC service and serialize the response
-        response = self.EditStub.ExtrudeFaces(request=request)
+        response = self.edit_stub.ExtrudeFaces(request=request)
         tracked_response = serialize_tracked_command_response(response.tracked_command_response)
 
         # Return the response - formatted as a dictionary
@@ -383,7 +383,7 @@ def extrude_faces_up_to(self, **kwargs) -> dict:  # noqa: D102
         )
 
         # Call the gRPC service and serialize the response
-        response = self.EditStub.ExtrudeFacesUpTo(request=request)
+        response = self.edit_stub.ExtrudeFacesUpTo(request=request)
         tracked_response = serialize_tracked_command_response(response.tracked_command_response)
 
         # Return the response - formatted as a dictionary
@@ -415,7 +415,7 @@ def offset_faces_set_radius(self, **kwargs) -> dict:  # noqa: D102
         )
 
         # Call the gRPC service
-        response = self.EditStub.OffsetFacesSetRadius(request=request)
+        response = self.edit_stub.OffsetFacesSetRadius(request=request)
 
         # Return the response - formatted as a dictionary
         return {
@@ -442,7 +442,7 @@ def revolve_faces(self, **kwargs) -> dict:  # noqa: D102
         )
 
         # Call the gRPC service and serialize the response
-        response = self.EditStub.RevolveFaces(request=request)
+        response = self.edit_stub.RevolveFaces(request=request)
         tracked_response = serialize_tracked_command_response(response.tracked_command_response)
 
         # Return the response - formatted as a dictionary
@@ -474,7 +474,7 @@ def revolve_faces_up_to(self, **kwargs) -> dict:  # noqa: D102
         )
 
         # Call the gRPC service and serialize the response
-        response = self.EditStub.RevolveFacesUpTo(request=request)
+        response = self.edit_stub.RevolveFacesUpTo(request=request)
         tracked_response = serialize_tracked_command_response(response.tracked_command_response)
 
         # Return the response - formatted as a dictionary
@@ -510,7 +510,7 @@ def revolve_faces_by_helix(self, **kwargs) -> dict:  # noqa: D102
         )
 
         # Call the gRPC service and serialize the response
-        response = self.EditStub.RevolveFacesByHelix(request=request)
+        response = self.edit_stub.RevolveFacesByHelix(request=request)
         tracked_response = serialize_tracked_command_response(response.tracked_command_response)
 
         # Return the response - formatted as a dictionary
@@ -561,7 +561,7 @@ def thicken_faces(self, **kwargs) -> dict:  # noqa: D102
         )
 
         # Call the gRPC service
-        response = self.EditStub.ThickenFaces(request=request)
+        response = self.edit_stub.ThickenFaces(request=request)
 
         # Return the response - formatted as a dictionary
         return {
@@ -589,7 +589,7 @@ def draft_faces(self, **kwargs) -> dict:  # noqa: D102
         )
 
         # Call the gRPC server
-        response = self.EditStub.DraftFaces(request=request)
+        response = self.edit_stub.DraftFaces(request=request)
 
         # Return the drafted faces
         return {
@@ -630,7 +630,7 @@ def offset_faces(self, **kwargs) -> dict:  # noqa: D102
         )
 
         # Call the gRPC service and serialize the response
-        response = self.EditStub.OffsetFaces(request=request)
+        response = self.edit_stub.OffsetFaces(request=request)
         tracked_response = serialize_tracked_command_response(response.tracked_command_response)
 
         # Return the response - formatted as a dictionary
@@ -658,7 +658,7 @@ def setup_offset_relationship(self, **kwargs) -> dict:  # noqa: D102
         )
 
         # Call the gRPC service
-        response = self.EditStub.FaceOffset(request=request)
+        response = self.edit_stub.FaceOffset(request=request)
 
         # Return the response - formatted as a dictionary
         return {