Merge branch 'feat/pull_commands' of https://github.com/ansys/pyansys-geometry into feat/pull_commands

Author: jacobrkerstetter

doc/changelog.d/2241.added.md

@@ -0,0 +1 @@
+Pull commands pt. 1

src/ansys/geometry/core/_grpc/_services/base/curves.py

@@ -42,4 +42,4 @@ def __init__(self, channel: grpc.Channel):
     @abstractmethod
     def revolve_edges(self, **kwargs) -> dict:
         """Revolve edges around an axis to create a surface of revolution."""
-        pass
+        pass

src/ansys/geometry/core/_grpc/_services/v0/curves.py

@@ -25,7 +25,7 @@
 
 from ansys.geometry.core.errors import protect_grpc
 
-from ..base.conversions import from_measurement_to_server_angle, from_measurement_to_server_length
+from ..base.conversions import from_measurement_to_server_angle
 from ..base.curves import GRPCCurvesService
 from .conversions import from_line_to_grpc_line, from_trimmed_curve_to_grpc_trimmed_curve
 

src/ansys/geometry/core/_grpc/_services/v0/faces.py

@@ -528,12 +528,14 @@ def offset_faces(self, **kwargs) -> dict:  # noqa: D102
 
         # Create the request - assumes all inputs are valid and of the proper type
         request = OffsetFacesRequest(
-            request_data=[OffsetFacesRequestData(
-                faces=[EntityIdentifier(id=face_id) for face_id in kwargs["face_ids"]],
-                offset=from_measurement_to_server_length(kwargs["distance"]),
-                direction=from_unit_vector_to_grpc_direction(kwargs["direction"]),
-                extrude_type=kwargs["extrude_type"].value,
-            )]
+            request_data=[
+                OffsetFacesRequestData(
+                    faces=[EntityIdentifier(id=face_id) for face_id in kwargs["face_ids"]],
+                    offset=from_measurement_to_server_length(kwargs["distance"]),
+                    direction=from_unit_vector_to_grpc_direction(kwargs["direction"]),
+                    extrude_type=kwargs["extrude_type"].value,
+                )
+            ]
         )
 
         # Call the gRPC service
@@ -543,5 +545,6 @@ def offset_faces(self, **kwargs) -> dict:  # noqa: D102
         return {
             "results": [
                 [face.id for face in response_data.new_faces]
-            for response_data in response.response_data]
-        }
+                for response_data in response.response_data
+            ]
+        }

src/ansys/geometry/core/_grpc/_services/v1/curves.py

@@ -46,7 +46,7 @@ def __init__(self, channel: grpc.Channel):  # noqa: D102
         from ansys.api.geometry.v1.curves_pb2_grpc import CurvesStub
 
         self.stub = CurvesStub(channel)
-    
+
     @protect_grpc
     def revolve_edges(self, **kwargs) -> dict:  # noqa: D102
-        raise NotImplementedError
+        raise NotImplementedError

src/ansys/geometry/core/_grpc/_services/v1/faces.py

@@ -134,7 +134,7 @@ def draft_faces(self, **kwargs) -> dict:  # noqa: D102
     @protect_grpc
     def get_round_info(self, **kwargs):  # noqa: D102
         raise NotImplementedError
-    
+
     @protect_grpc
     def offset_faces(self, **kwargs):  # noqa: D102
         raise NotImplementedError

src/ansys/geometry/core/designer/geometry_commands.py

@@ -1834,4 +1834,4 @@ def revolve_edges(
         )
 
         design = get_design_from_edge(edges[0])
-        design._update_design_inplace()
+        design._update_design_inplace()

tests/integration/test_geometry_commands.py

@@ -1406,6 +1406,7 @@ def test_thicken_surface_body(modeler: Modeler):
         Quantity(0.4, UNITS.m**3).m, rel=1e-6, abs=1e-8
     )
 
+
 def test_offset_faces(modeler: Modeler):
     """Test offsetting faces."""
     design = modeler.create_design("offset_faces")
@@ -1432,12 +1433,13 @@ def test_offset_faces(modeler: Modeler):
 
     assert box.volume.m == pytest.approx(Quantity(8.8, UNITS.m**3).m, rel=1e-6, abs=1e-8)
     assert box2.volume.m == pytest.approx(Quantity(8.4, UNITS.m**3).m, rel=1e-6, abs=1e-8)
-    
+
+
 def test_revolve_edges(modeler: Modeler):
     """Test revolving edges."""
     design = modeler.create_design("revolve_edges")
     box = design.extrude_sketch("box", Sketch().box(Point2D([0, 0]), 2, 2), 2)
-    
+
     assert len(box.faces) == 6
     assert box.volume.m == pytest.approx(Quantity(8, UNITS.m**3).m, rel=1e-6, abs=1e-8)
 
@@ -1447,10 +1449,8 @@ def test_revolve_edges(modeler: Modeler):
     modeler.geometry_commands.revolve_edges(edge, axis, Angle(np.pi / 2, UNITS.rad), True)
 
     assert len(design.bodies) == 2
-    assert design.bodies[0].volume.m == pytest.approx(
-        Quantity(8, UNITS.m**3).m, rel=1e-6, abs=1e-8
-    )
+    assert design.bodies[0].volume.m == pytest.approx(Quantity(8, UNITS.m**3).m, rel=1e-6, abs=1e-8)
     assert design.bodies[1].is_surface
     assert design.bodies[1].faces[0].area.m == pytest.approx(
         Quantity(8.88576587632, UNITS.m**2).m, rel=1e-6, abs=1e-8
-    )
+    )