Merge branch 'main' into chore/v1_impl_cleanup

Author: RobPasMue

doc/changelog.d/2452.dependencies.md

@@ -0,0 +1 @@
+Build: bump numpydoc from 1.9.0 to 1.10.0 in the docs-deps group

doc/changelog.d/2454.maintenance.md

@@ -0,0 +1 @@
+Chore: v1 fix imprint curves

pyproject.toml

@@ -82,7 +82,7 @@ doc = [
   "nbconvert==7.16.6",
   "nbsphinx==0.9.8",
   "notebook==7.5.0",
-  "numpydoc==1.9.0",
+  "numpydoc==1.10.0",
   "pdf2image==1.17.0",
   "quarto-cli==1.8.25",
   "sphinx==8.2.3",

src/ansys/geometry/core/_grpc/_services/v1/bodies.py

@@ -1232,6 +1232,14 @@ def imprint_curves(self, **kwargs) -> dict:  # noqa: D102
             ImprintCurvesRequestData,
         )
 
+        # Convert sketch and trimmed curves to gRPC format
+        sketch = kwargs["sketch"]
+        curves = (
+            from_sketch_shapes_to_grpc_geometries(sketch.plane, sketch.edges, sketch.faces)
+            if sketch
+            else None
+        )
+
         # Convert trimmed curves to gRPC format
         trimmed_curves = []
         if kwargs.get("tc"):
@@ -1242,17 +1250,36 @@ def imprint_curves(self, **kwargs) -> dict:  # noqa: D102
             request_data=[
                 ImprintCurvesRequestData(
                     body_ids=build_grpc_id(kwargs["id"]),
+                    curves=curves,
                     face_ids=[build_grpc_id(id) for id in kwargs["face_ids"]],
+                    plane=from_plane_to_grpc_plane(sketch.plane) if sketch else None,
                     trimmed_curves=trimmed_curves,
                 )
             ]
         )
 
         # Call the gRPC service
-        _ = self.edit_stub.ImprintCurves(request=request)
+        response = self.edit_stub.ImprintCurves(request=request).response_data[0]
 
         # Return the response - formatted as a dictionary
-        return {}
+        return {
+            "edges": [
+                {
+                    "id": edge.id,
+                    "curve_type": edge.curve_type,
+                    "is_reversed": edge.is_reversed,
+                }
+                for edge in response.created_entities.edges
+            ],
+            "faces": [
+                {
+                    "id": face.id,
+                    "surface_type": face.surface_type,
+                    "is_reversed": face.is_reversed,
+                }
+                for face in response.created_entities.faces
+            ],
+        }
 
     @protect_grpc
     def project_curves(self, **kwargs) -> dict:  # noqa: D102