Merge branch 'build/pyvista-0.45' into fix/docstyle

Author: RobPasMue

.github/workflows/ci_cd.yml

@@ -9,7 +9,7 @@ on:
       - main
 
 env:
-  MAIN_PYTHON_VERSION: '3.12'
+  MAIN_PYTHON_VERSION: '3.13'
   PACKAGE_NAME: 'ansys-geometry-core'
   DOCUMENTATION_CNAME: 'geometry.docs.pyansys.com'
   ANSRV_GEO_IMAGE: 'ghcr.io/ansys/geometry'
@@ -20,6 +20,7 @@ env:
   RESET_IMAGE_CACHE: 5
   IS_WORKFLOW_RUNNING: True
   ARTIFACTORY_VERSION: v252
+  VTK_DEFAULT_OPENGL_WINDOW: "vtkOSOpenGLRenderWindow"
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
@@ -401,6 +402,12 @@ jobs:
           echo "SKIP_UNSTABLE=$Result" >> $GITHUB_ENV
           echo "SKIP_UNSTABLE will be: $Result"
 
+      - name: Set up headless display
+        if: env.SKIP_UNSTABLE == 'false'
+        uses: pyvista/setup-headless-display-action@52bda06d59c0fc422fc2512c9c670bf6b66616f8 # v3.2
+        with:
+          pyvista: false
+
       - name: Login in Github Container registry
         if: env.SKIP_UNSTABLE == 'false'
         uses: docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772 # v3.4.0
@@ -805,7 +812,6 @@ jobs:
           python-version: ${{ env.MAIN_PYTHON_VERSION }}
           pytest-extra-args: "--use-existing-service=yes"
           checkout: false
-          requires-xvfb: true
           randomize: true
 
       - name: "Compressing Linux Dockerfile"

.github/workflows/nightly_docker_test.yml

@@ -21,7 +21,7 @@ on:
       - v*
 
 env:
-  MAIN_PYTHON_VERSION: '3.12'
+  MAIN_PYTHON_VERSION: '3.13'
   ANSRV_GEO_IMAGE_WINDOWS_CORE_TAG: ghcr.io/ansys/geometry:core-windows-latest-unstable
   ANSRV_GEO_IMAGE_LINUX_CORE_TAG: ghcr.io/ansys/geometry:core-linux-latest-unstable
   ANSRV_GEO_PORT: 710

doc/changelog.d/1924.dependencies.md

@@ -0,0 +1 @@
+bump PyVista and VTK versions (support Python 3.13)

pyproject.toml

@@ -58,7 +58,7 @@ all = [
 tests = [
     "ansys-platform-instancemanagement==1.1.2",
     "ansys-tools-path==0.7.1",
-    "ansys-tools-visualization-interface==0.8.3",
+    "ansys-tools-visualization-interface==0.9.1",
     "beartype==0.20.2",
     "docker==7.1.0",
     "geomdl==5.3.1",
@@ -73,12 +73,12 @@ tests = [
     "pytest-cov==6.1.1",
     "pytest-pyvista==0.1.9",
     "pytest-xvfb==3.1.1",
-    "pyvista[jupyter]==0.44.2",
+    "pyvista[jupyter]==0.45.0",
     "requests==2.32.3",
     "scipy==1.15.2",
     "semver==3.0.4",
     "six==1.17.0",
-    "vtk==9.3.1",
+    "vtk==9.4.2",
 ]
 tests-minimal = [
     "pytest==8.3.5",
@@ -89,7 +89,7 @@ tests-minimal = [
 doc = [
     "ansys-sphinx-theme[autoapi]==1.4.2",
     "ansys-tools-path==0.7.1",
-    "ansys-tools-visualization-interface==0.8.3",
+    "ansys-tools-visualization-interface==0.9.1",
     "beartype==0.20.2",
     "docker==7.1.0",
     "geomdl==5.3.1",
@@ -110,7 +110,7 @@ doc = [
     "Pint==0.24.4",
     "protobuf==5.29.3",
     "pygltflib==1.16.3",
-    "pyvista[jupyter]==0.44.2",
+    "pyvista[jupyter]==0.45.0",
     "quarto-cli==1.6.42",
     "requests==2.32.3",
     "scipy==1.15.2",
@@ -121,7 +121,7 @@ doc = [
     "sphinx-copybutton==0.5.2",
     "sphinx-jinja==2.0.2",
     "trame-vtk==2.8.15",
-    "vtk==9.3.1",
+    "vtk==9.4.2",
 ]
 
 [project.urls]

src/ansys/geometry/core/sketch/ellipse.py

@@ -203,7 +203,7 @@ def visualization_polydata(self) -> "pv.PolyData":
         return pv.Ellipse(
             semi_major_axis=self.major_radius.m_as(DEFAULT_UNITS.LENGTH),
             semi_minor_axis=self.minor_radius.m_as(DEFAULT_UNITS.LENGTH),
-        ).transform(transformation_matrix)
+        ).transform(transformation_matrix, inplace=True)
 
     def plane_change(self, plane: Plane) -> None:
         """Redefine the plane containing ``SketchEllipse`` objects.

src/ansys/geometry/core/sketch/polygon.py

@@ -172,4 +172,4 @@ def visualization_polydata(self) -> "pv.PolyData":
         return pv.Polygon(
             radius=self.inner_radius.m_as(DEFAULT_UNITS.LENGTH),
             n_sides=self.n_sides,
-        ).transform(transformation_matrix)
+        ).transform(transformation_matrix, inplace=True)

src/ansys/geometry/core/sketch/sketch.py

@@ -964,7 +964,9 @@ def plot_selection(
         sketches_polydata_selection = []
         sketches_polydata_selection.extend(
             [
-                sketch_item.visualization_polydata.transform(self._plane.transformation_matrix)
+                sketch_item.visualization_polydata.transform(
+                    self._plane.transformation_matrix, inplace=True
+                )
                 for sketch_item in self._current_sketch_context
             ]
         )
@@ -998,7 +1000,7 @@ def sketch_polydata_faces(self) -> list["PolyData"]:
             List of the polydata configuration for faces in the sketch.
         """
         sketches_polydata_faces = [
-            face.visualization_polydata.transform(self._plane.transformation_matrix)
+            face.visualization_polydata.transform(self._plane.transformation_matrix, inplace=True)
             for face in self.faces
         ]
         return sketches_polydata_faces
@@ -1012,7 +1014,7 @@ def sketch_polydata_edges(self) -> list["PolyData"]:
             List of the polydata configuration for edges in the sketch.
         """
         sketches_polydata_edges = [
-            edge.visualization_polydata.transform(self._plane.transformation_matrix)
+            edge.visualization_polydata.transform(self._plane.transformation_matrix, inplace=True)
             for edge in self.edges
         ]
         return sketches_polydata_edges

tests/integration/test_plotter.py

@@ -578,25 +578,22 @@ def test_visualization_polydata():
         rel=1e-6,
         abs=1e-8,
     )
-    assert polygon.visualization_polydata.n_faces == 2
     assert polygon.visualization_polydata.n_cells == 2
     assert polygon.visualization_polydata.n_points == 5
     assert polygon.visualization_polydata.n_open_edges == 5
 
     # Test for arc visualization polydata
     arc = Arc(Point2D([10, 10]), Point2D([10, -10]), Point2D([10, 0]))
-    assert arc.visualization_polydata.center == ([5.0, 0.0, 0.0])
+    assert arc.visualization_polydata.center == pytest.approx([5.0, 0.0, 0.0])
     assert arc.visualization_polydata.bounds == pytest.approx([0.0, 10.0, -10.0, 10.0, 0.0, 0.0])
-    assert arc.visualization_polydata.n_faces == 2
     assert arc.visualization_polydata.n_cells == 2
     assert arc.visualization_polydata.n_points == 202
     assert arc.visualization_polydata.n_open_edges == 0
 
     # Test for segment visualization polydata
     segment = SketchSegment(Point2D([3, 2]), Point2D([2, 0]))
-    assert segment.visualization_polydata.center == ([2.5, 1.0, 0.0])
+    assert segment.visualization_polydata.center == pytest.approx([2.5, 1.0, 0.0])
     assert segment.visualization_polydata.bounds == pytest.approx([2.0, 3.0, 0.0, 2.0, 0.0, 0.0])
-    assert segment.visualization_polydata.n_faces == 1
     assert segment.visualization_polydata.n_cells == 1
     assert segment.visualization_polydata.n_points == 2
     assert segment.visualization_polydata.n_open_edges == 0
@@ -609,20 +606,18 @@ def test_visualization_polydata():
     )
     assert slot.visualization_polydata
     assert slot.visualization_polydata.bounds == pytest.approx([0.0, 4.0, 2.0, 4.0, 0.0, 0.0])
-    assert slot.visualization_polydata.center == ([2.0, 3.0, 0.0])
+    assert slot.visualization_polydata.center == pytest.approx([2.0, 3.0, 0.0])
     # Two arcs and segments creates the slot, thus it should have 6 faces
-    assert slot.visualization_polydata.n_faces == 6
     assert slot.visualization_polydata.n_cells == 6
     assert slot.visualization_polydata.n_points == 402
     assert slot.visualization_polydata.n_open_edges == 0
 
     # Test for triangle visualization polydata
     triangle = Triangle(Point2D([10, 10]), Point2D([2, 1]), Point2D([10, -10]))
-    assert triangle.visualization_polydata.center == ([6.0, 0.0, 0.0])
+    assert triangle.visualization_polydata.center == pytest.approx([6.0, 0.0, 0.0])
     assert triangle.visualization_polydata.bounds == pytest.approx(
         [2.0, 10.0, -10.0, 10.0, 0.0, 0.0]
     )
-    assert triangle.visualization_polydata.n_faces == 1
     assert triangle.visualization_polydata.n_cells == 1
     assert triangle.visualization_polydata.n_points == 3
     assert triangle.visualization_polydata.n_open_edges == 3
@@ -639,7 +634,6 @@ def test_visualization_polydata():
         rel=1e-6,
         abs=1e-8,
     )
-    assert trapezoid.visualization_polydata.n_faces == 1
     assert trapezoid.visualization_polydata.n_cells == 1
     assert trapezoid.visualization_polydata.n_points == 4
     assert trapezoid.visualization_polydata.n_open_edges == 4
@@ -648,18 +642,16 @@ def test_visualization_polydata():
     circle = SketchCircle(
         Point2D([10, -10], DEFAULT_UNITS.LENGTH), Quantity(1, DEFAULT_UNITS.LENGTH)
     )
-    assert circle.visualization_polydata.center == pytest.approx(([10.0, -10.0, 0.0]))
+    assert circle.visualization_polydata.center == pytest.approx([10.0, -10.0, 0.0])
     assert circle.visualization_polydata.bounds == pytest.approx([9.0, 11.0, -11.0, -9.0, 0.0, 0.0])
-    assert circle.visualization_polydata.n_faces == 1
     assert circle.visualization_polydata.n_cells == 1
     assert circle.visualization_polydata.n_points == 100
     assert circle.visualization_polydata.n_open_edges == 100
 
     # Test for ellipse visualization polydata
     ellipse = SketchEllipse(Point2D([0, 0], UNITS.m), Quantity(1, UNITS.m), Quantity(1, UNITS.m))
-    assert ellipse.visualization_polydata.center == pytest.approx(([0.0, 0.0, 0.0]))
+    assert ellipse.visualization_polydata.center == pytest.approx([0.0, 0.0, 0.0])
     assert ellipse.visualization_polydata.bounds == pytest.approx([-1.0, 1.0, -1.0, 1.0, 0.0, 0.0])
-    assert ellipse.visualization_polydata.n_faces == 1
     assert ellipse.visualization_polydata.n_cells == 1
     assert ellipse.visualization_polydata.n_points == 100
     assert ellipse.visualization_polydata.n_open_edges == 100
@@ -670,9 +662,8 @@ def test_visualization_polydata():
         Distance(4, unit=UNITS.meter),
         Distance(2, unit=UNITS.meter),
     )
-    assert box.visualization_polydata.center == ([3.0, 1.0, 0.0])
+    assert box.visualization_polydata.center == pytest.approx([3.0, 1.0, 0.0])
     assert box.visualization_polydata.bounds == pytest.approx([1.0, 5.0, 0.0, 2.0, 0.0, 0.0])
-    assert box.visualization_polydata.n_faces == 1
     assert box.visualization_polydata.n_cells == 1
     assert box.visualization_polydata.n_points == 4
     assert box.visualization_polydata.n_open_edges == 4

tests/integration/test_tessellation.py

@@ -49,7 +49,7 @@ def test_body_tessellate(modeler: Modeler):
     # Number of blocks will be the number of faces
     assert blocks_1.n_blocks == 6
     # Test the center of the bounding box
-    assert (blocks_1.center == ([2, 0, 0.5])).all()
+    assert blocks_1.center == pytest.approx([2, 0, 0.5])
     # Test the values of blocks which are the length 6 tuple of floats
     # containing min/max along each axis
     assert blocks_1.bounds == pytest.approx([0.0, 4.0, -2.0, 2.0, 0.0, 1.0])
@@ -145,7 +145,6 @@ def test_component_tessellate(modeler: Modeler):
     assert "PolyData" in str(mesh)
     if not BackendType.is_core_service(modeler.client.backend_type):
         assert mesh.n_cells == 3280
-        assert mesh.n_faces == 3280
         assert mesh.n_arrays == 0
         assert mesh.n_points == 3300
         assert mesh.bounds == pytest.approx(
@@ -155,7 +154,6 @@ def test_component_tessellate(modeler: Modeler):
         )
     else:
         assert mesh.n_cells == 3280
-        assert mesh.n_faces == 3280
         assert mesh.n_arrays == 0
         assert mesh.n_points == 3300
         assert mesh.bounds == pytest.approx(