Merge branch 'main' of https://github.com/ansys/pyansys-geometry into feat/design_tessellation_streaming

Author: jacobrkerstetter

.github/workflows/codeql.yml

@@ -26,13 +26,13 @@ jobs:
         persist-credentials: false
 
     - name: Initialize CodeQL
-      uses: github/codeql-action/init@64d10c13136e1c5bce3e5fbde8d4906eeaafc885 # v3.30.6
+      uses: github/codeql-action/init@e296a935590eb16afc0c0108289f68c87e2a89a5 # v4.30.7
       with:
         languages: 'python'
         config-file: ./.github/codeql-config.yml
 
     - name: Autobuild
-      uses: github/codeql-action/autobuild@64d10c13136e1c5bce3e5fbde8d4906eeaafc885 # v3.30.6
+      uses: github/codeql-action/autobuild@e296a935590eb16afc0c0108289f68c87e2a89a5 # v4.30.7
 
     #   If the Autobuild fails above, remove it and uncomment the following three lines.
     #   modify them (or add more) to build your code if your project, please refer to the EXAMPLE below for guidance.
@@ -42,6 +42,6 @@ jobs:
     #     ./location_of_script_within_repo/buildscript.sh
 
     - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@64d10c13136e1c5bce3e5fbde8d4906eeaafc885 # v3.30.6
+      uses: github/codeql-action/analyze@e296a935590eb16afc0c0108289f68c87e2a89a5 # v4.30.7
       with:
         category: "/language:python"

doc/changelog.d/2260.test.md

@@ -0,0 +1 @@
+Adding test coverage for nurbs, design, and geometry commands

doc/changelog.d/2288.maintenance.md

@@ -0,0 +1 @@
+Removing commands stub from body module

doc/changelog.d/2290.dependencies.md

@@ -0,0 +1 @@
+Bump ansys-api-geometry from 0.4.78 to 0.4.80

doc/changelog.d/2291.maintenance.md

@@ -0,0 +1 @@
+Bump github/codeql-action from 3.30.6 to 4.30.7 in the actions group

doc/changelog.d/2293.maintenance.md

@@ -0,0 +1 @@
+Prevent invalid kwargs from being passed to launcher methods

pyproject.toml

@@ -24,7 +24,7 @@ classifiers = [
 ]
 
 dependencies = [
-    "ansys-api-geometry==0.4.78",
+    "ansys-api-geometry==0.4.80",
     "ansys-tools-path>=0.3,<1",
     "beartype>=0.11.0,<0.22",
     "geomdl>=5,<6",

src/ansys/geometry/core/_grpc/_services/base/bodies.py

@@ -236,3 +236,38 @@ def create_body_from_loft_profiles_with_guides(self, **kwargs) -> dict:
     def combine_merge(self, **kwargs) -> dict:
         """Combine and merge bodies."""
         pass
+
+    @abstractmethod
+    def assign_midsurface_thickness(self, **kwargs) -> dict:
+        """Assign a thickness to a midsurface body."""
+        pass
+
+    @abstractmethod
+    def assign_midsurface_offset(self, **kwargs) -> dict:
+        """Assign a offset to a midsurface body."""
+        pass
+
+    @abstractmethod
+    def shell(self, **kwargs) -> dict:
+        """Shell a body."""
+        pass
+
+    @abstractmethod
+    def remove_faces(self, **kwargs) -> dict:
+        """Remove faces from a body."""
+        pass
+
+    @abstractmethod
+    def imprint_curves(self, **kwargs) -> dict:
+        """Imprint curves on a body."""
+        pass
+
+    @abstractmethod
+    def project_curves(self, **kwargs) -> dict:
+        """Project curves on a body."""
+        pass
+
+    @abstractmethod
+    def imprint_projected_curves(self, **kwargs) -> dict:
+        """Imprint projected curves on a body."""
+        pass

src/ansys/geometry/core/_grpc/_services/v0/bodies.py

@@ -905,3 +905,185 @@ def combine_merge(self, **kwargs) -> dict:  # noqa: D102
 
         # Return the response - formatted as a dictionary
         return {}
+
+    @protect_grpc
+    def assign_midsurface_thickness(self, **kwargs) -> dict:  # noqa: D102
+        from ansys.api.geometry.v0.commands_pb2 import AssignMidSurfaceThicknessRequest
+
+        # Create the request - assumes all inputs are valid and of the proper type
+        request = AssignMidSurfaceThicknessRequest(
+            bodies_or_faces=kwargs["ids"],
+            thickness=from_measurement_to_server_length(kwargs["thickness"]),
+        )
+
+        # Call the gRPC service
+        self.command_stub.AssignMidSurfaceThickness(request=request)
+
+        # Return the response - formatted as a dictionary
+        return {}
+
+    @protect_grpc
+    def assign_midsurface_offset(self, **kwargs) -> dict:  # noqa: D102
+        from ansys.api.geometry.v0.commands_pb2 import AssignMidSurfaceOffsetTypeRequest
+
+        # Create the request - assumes all inputs are valid and of the proper type
+        request = AssignMidSurfaceOffsetTypeRequest(
+            bodies_or_faces=kwargs["ids"],
+            offset_type=kwargs["offset_type"].value,
+        )
+
+        # Call the gRPC service
+        self.command_stub.AssignMidSurfaceOffsetType(request=request)
+
+        # Return the response - formatted as a dictionary
+        return {}
+
+    @protect_grpc
+    def shell(self, **kwargs) -> dict:  # noqa: D102
+        from ansys.api.geometry.v0.commands_pb2 import ShellRequest
+
+        # Create the request - assumes all inputs are valid and of the proper type
+        request = ShellRequest(
+            selection=build_grpc_id(kwargs["id"]),
+            offset=from_measurement_to_server_length(kwargs["offset"]),
+        )
+
+        # Call the gRPC service
+        response = self.command_stub.Shell(request=request)
+
+        # Return the response - formatted as a dictionary
+        return {
+            "success": response.success,
+        }
+
+    @protect_grpc
+    def remove_faces(self, **kwargs) -> dict:  # noqa: D102
+        from ansys.api.geometry.v0.commands_pb2 import RemoveFacesRequest
+
+        # Create the request - assumes all inputs are valid and of the proper type
+        request = RemoveFacesRequest(
+            selection=[build_grpc_id(id) for id in kwargs["face_ids"]],
+            offset=from_measurement_to_server_length(kwargs["offset"]),
+        )
+
+        # Call the gRPC service
+        response = self.command_stub.RemoveFaces(request=request)
+
+        # Return the response - formatted as a dictionary
+        return {
+            "success": response.success,
+        }
+
+    @protect_grpc
+    def imprint_curves(self, **kwargs) -> dict:  # noqa: D102
+        from ansys.api.geometry.v0.commands_pb2 import ImprintCurvesRequest
+
+        # Convert sketch and trimmed curves to gRPC format
+        sketch = kwargs["sketch"]
+        curves = None
+        if sketch:
+            curves = from_sketch_shapes_to_grpc_geometries(sketch.plane, sketch.edges, sketch.faces)
+
+        trimmed_curves = None
+        if kwargs["tc"]:
+            trimmed_curves = [from_trimmed_curve_to_grpc_trimmed_curve(tc) for tc in kwargs["tc"]]
+
+        # Create the request - assumes all inputs are valid and of the proper type
+        request = ImprintCurvesRequest(
+            body=kwargs["id"],
+            curves=curves,
+            faces=kwargs["face_ids"],
+            plane=from_plane_to_grpc_plane(sketch.plane) if sketch else None,
+            trimmed_curves=trimmed_curves,
+        )
+
+        # Call the gRPC service
+        response = self.command_stub.ImprintCurves(request=request)
+
+        # Return the response - formatted as a dictionary
+        return {
+            "edges": [
+                {
+                    "id": edge.id,
+                    "curve_type": edge.curve_type,
+                    "is_reversed": edge.is_reversed,
+                }
+                for edge in response.edges
+            ],
+            "faces": [
+                {
+                    "id": face.id,
+                    "surface_type": face.surface_type,
+                    "is_reversed": face.is_reversed,
+                }
+                for face in response.faces
+            ],
+        }
+
+    @protect_grpc
+    def project_curves(self, **kwargs) -> dict:  # noqa: D102
+        from ansys.api.geometry.v0.commands_pb2 import ProjectCurvesRequest
+
+        # Convert sketch and trimmed curves to gRPC format
+        sketch = kwargs["sketch"]
+        curves = from_sketch_shapes_to_grpc_geometries(
+            sketch.plane, sketch.edges, sketch.faces, kwargs["only_one_curve"]
+        )
+
+        # Create the request - assumes all inputs are valid and of the proper type
+        request = ProjectCurvesRequest(
+            body=kwargs["id"],
+            curves=curves,
+            direction=from_unit_vector_to_grpc_direction(kwargs["direction"]),
+            closest_face=kwargs["closest_face"],
+            plane=from_plane_to_grpc_plane(sketch.plane),
+        )
+
+        # Call the gRPC service
+        response = self.command_stub.ProjectCurves(request=request)
+
+        # Return the response - formatted as a dictionary
+        return {
+            "faces": [
+                {
+                    "id": face.id,
+                    "surface_type": face.surface_type,
+                    "is_reversed": face.is_reversed,
+                }
+                for face in response.faces
+            ],
+        }
+
+    @protect_grpc
+    def imprint_projected_curves(self, **kwargs) -> dict:  # noqa: D102
+        from ansys.api.geometry.v0.commands_pb2 import ProjectCurvesRequest
+
+        # Convert sketch and trimmed curves to gRPC format
+        sketch = kwargs["sketch"]
+        curves = from_sketch_shapes_to_grpc_geometries(
+            sketch.plane, sketch.edges, sketch.faces, kwargs["only_one_curve"]
+        )
+
+        # Create the request - assumes all inputs are valid and of the proper type
+        request = ProjectCurvesRequest(
+            body=kwargs["id"],
+            curves=curves,
+            direction=from_unit_vector_to_grpc_direction(kwargs["direction"]),
+            closest_face=kwargs["closest_face"],
+            plane=from_plane_to_grpc_plane(sketch.plane),
+        )
+
+        # Call the gRPC service
+        response = self.command_stub.ImprintProjectedCurves(request=request)
+
+        # Return the response - formatted as a dictionary
+        return {
+            "faces": [
+                {
+                    "id": face.id,
+                    "surface_type": face.surface_type,
+                    "is_reversed": face.is_reversed,
+                }
+                for face in response.faces
+            ],
+        }

src/ansys/geometry/core/_grpc/_services/v1/bodies.py

@@ -207,3 +207,31 @@ def create_body_from_loft_profiles_with_guides(self, **kwargs) -> dict:  # noqa:
     @protect_grpc
     def combine_merge(self, **kwargs) -> dict:  # noqa: D102
         raise NotImplementedError
+
+    @protect_grpc
+    def assign_midsurface_thickness(self, **kwargs) -> dict:  # noqa: D102
+        raise NotImplementedError
+
+    @protect_grpc
+    def assign_midsurface_offset(self, **kwargs) -> dict:  # noqa: D102
+        raise NotImplementedError
+
+    @protect_grpc
+    def shell(self, **kwargs) -> dict:  # noqa: D102
+        raise NotImplementedError
+
+    @protect_grpc
+    def remove_faces(self, **kwargs) -> dict:  # noqa: D102
+        raise NotImplementedError
+
+    @protect_grpc
+    def imprint_curves(self, **kwargs) -> dict:  # noqa: D102
+        raise NotImplementedError
+
+    @protect_grpc
+    def project_curves(self, **kwargs) -> dict:  # noqa: D102
+        raise NotImplementedError
+
+    @protect_grpc
+    def imprint_projected_curves(self, **kwargs) -> dict:  # noqa: D102
+        raise NotImplementedError