beams fixes from comments on PR

Author: jacobrkerstetter

src/ansys/geometry/core/_grpc/_services/v0/beams.py

@@ -26,6 +26,7 @@
 from ansys.geometry.core.errors import protect_grpc
 
 from ..base.beams import GRPCBeamsService
+from .conversions import from_point3d_to_grpc_point
 
 
 class GRPCBeamsServiceV0(GRPCBeamsService):
@@ -50,37 +51,55 @@ def __init__(self, channel: grpc.Channel):  # noqa: D102
     @protect_grpc
     def create_beam_segments(self, **kwargs) -> dict:  # noqa: D102
         from ansys.api.geometry.v0.commands_pb2 import CreateBeamSegmentsRequest
+        from ansys.api.geometry.v0.models_pb2 import Line
+
+        # Create the gRPC Line objects
+        lines = []
+        for segment in kwargs["segments"]:
+            lines.append(
+                Line(start=from_point3d_to_grpc_point(segment[0]), 
+                     end=from_point3d_to_grpc_point(segment[1]))
+            )
 
         # Create the request - assumes all inputs are valid and of the proper type
         request = CreateBeamSegmentsRequest(
             profile=kwargs["profile_id"],
             parent=kwargs["parent_id"],
-            lines=kwargs["lines"],
+            lines=lines,
         )
 
         # Call the gRPC service
         resp = self.stub.CreateBeamSegments(request)
 
-        # Return the response as a dictionary
+        # Return the response - formatted as a dictionary
         return {
             "beam_ids": resp.ids,
         }
 
     @protect_grpc
     def create_descriptive_beam_segments(self, **kwargs) -> dict:  # noqa: D102
         from ansys.api.geometry.v0.commands_pb2 import CreateBeamSegmentsRequest
+        from ansys.api.geometry.v0.models_pb2 import Line
+
+        # Create the gRPC Line objects
+        lines = []
+        for segment in kwargs["segments"]:
+            lines.append(
+                Line(start=from_point3d_to_grpc_point(segment[0]), 
+                     end=from_point3d_to_grpc_point(segment[1]))
+            )
 
         # Create the request - assumes all inputs are valid and of the proper type
         request = CreateBeamSegmentsRequest(
             profile=kwargs["profile_id"],
             parent=kwargs["parent_id"],
-            lines=kwargs["lines"],
+            lines=lines,
         )
 
         # Call the gRPC service
         resp = self.stub.CreateDescriptiveBeamSegments(request)
 
-        # Return the response as a dictionary
+        # Return the response - formatted as a dictionary
         return {
             "created_beams": resp.created_beams,
         }
@@ -94,3 +113,6 @@ def delete_beam(self, **kwargs) -> dict:  # noqa: D102
 
         # Call the gRPC service
         _ = self.stub.DeleteBeam(request)
+
+        # Return the response - formatted as a dictionary
+        return {}

src/ansys/geometry/core/_grpc/_services/v1/beams.py

@@ -32,7 +32,7 @@ class GRPCBeamsServiceV1(GRPCBeamsService):
     """Beams service for gRPC communication with the Geometry server.
 
     This class provides methods to interact with the Geometry server's
-    beams service. It is specifically designed for the v0 version of the
+    beams service. It is specifically designed for the v1 version of the
     Geometry API.
 
     Parameters

src/ansys/geometry/core/designer/component.py

@@ -1212,15 +1212,9 @@ def __create_beams_legacy(
         -----
         This is a legacy method, which is used in versions up to Ansys 25.1.1 products.
         """
-        lines = []
-        for segment in segments:
-            lines.append(
-                Line(start=point3d_to_grpc_point(segment[0]), end=point3d_to_grpc_point(segment[1]))
-            )
-
         self._grpc_client.log.debug(f"Creating beams on {self.id}...")
         response = self._grpc_client.services.beams.create_beam_segments(
-            parent_id=self.id, profile_id=profile.id, lines=lines
+            parent_id=self.id, profile_id=profile.id, segments=segments
         )
         self._grpc_client.log.debug("Beams successfully created.")
 
@@ -1257,19 +1251,12 @@ def __create_beams(
         list[Beam]
             A list of the created Beams.
         """
-        lines = []
-        for segment in segments:
-            lines.append(
-                Line(start=point3d_to_grpc_point(segment[0]), end=point3d_to_grpc_point(segment[1]))
-            )
-
         self._grpc_client.log.debug(f"Creating beams on {self.id}...")
         response = self._grpc_client.services.beams.create_descriptive_beam_segments(
-            parent_id=self.id, profile_id=profile.id, lines=lines
+            parent_id=self.id, profile_id=profile.id, segments=segments
         )
         self._grpc_client.log.debug("Beams successfully created.")
 
-        print(response)
         beams = []
         for beam in response.get("created_beams", []):
             cross_section = BeamCrossSectionInfo(