more face/edge commands

Author: jacobrkerstetter

src/ansys/geometry/core/_grpc/_services/base/edges.py

@@ -87,4 +87,14 @@ def extrude_edges(self, **kwargs) -> dict:
     @abstractmethod
     def extrude_edges_up_to(self, **kwargs) -> dict:
         """Extrude edges up to a face."""
+        pass
+
+    @abstractmethod
+    def move_imprint_edges(self, **kwargs) -> dict:
+        """Move imprint edges."""
+        pass
+
+    @abstractmethod
+    def offset_edges(self, **kwargs) -> dict:
+        """Offset edges."""
         pass

src/ansys/geometry/core/_grpc/_services/base/faces.py

@@ -142,4 +142,9 @@ def thicken_faces(self, **kwargs) -> dict:
     @abstractmethod
     def draft_faces(self, **kwargs) -> dict:
         """Draft a selection of faces."""
+        pass
+
+    @abstractmethod
+    def get_round_info(self, **kwargs) -> dict:
+        """Get round information for a selection of faces."""
         pass

src/ansys/geometry/core/_grpc/_services/v0/edges.py

@@ -235,4 +235,41 @@ def extrude_edges_up_to(self, **kwargs):  # noqa: D102
         return {
             "created_bodies": [body.id for body in resp.created_bodies],
             "success": resp.success,
+        }
+    
+    @protect_grpc
+    def move_imprint_edges(self, **kwargs) -> dict:  # noqa: D102
+        from ansys.api.geometry.v0.commands_pb2 import MoveImprintEdgesRequest
+
+        # Create the request - assumes all inputs are valid and of the proper type
+        request = MoveImprintEdgesRequest(
+            edges=[build_grpc_id(edge_id) for edge_id in kwargs["edge_ids"]],
+            direction=from_unit_vector_to_grpc_direction(kwargs["direction"]),
+            distance=from_measurement_to_server_length(kwargs["distance"]),
+        )
+
+        # Call the gRPC service
+        resp = self.commands_stub.MoveImprintEdges(request)
+
+        # Return the response - formatted as a dictionary
+        return {
+            "success": resp.result.success,
+        }
+    
+    @protect_grpc
+    def offset_edges(self, **kwargs) -> dict:  # noqa: D102
+        from ansys.api.geometry.v0.commands_pb2 import OffsetEdgesRequest
+
+        # Create the request - assumes all inputs are valid and of the proper type
+        request = OffsetEdgesRequest(
+            edges=[build_grpc_id(edge_id) for edge_id in kwargs["edge_ids"]],
+            value=from_measurement_to_server_length(kwargs["offset"]),
+        )
+
+        # Call the gRPC service
+        resp = self.commands_stub.OffsetEdges(request)
+
+        # Return the response - formatted as a dictionary
+        return {
+            "success": resp.success,
         }

src/ansys/geometry/core/_grpc/_services/v0/faces.py

@@ -498,4 +498,23 @@ def draft_faces(self, **kwargs) -> dict:  # noqa: D102
         # Return the drafted faces
         return {
             "created_faces": [face.id for face in response.created_faces],
+        }
+    
+    @protect_grpc
+    def get_round_info(self, **kwargs):  # noqa: D102
+        from ansys.api.dbu.v0.dbumodels_pb2 import EntityIdentifier
+        from ansys.api.geometry.v0.commands_pb2 import RoundInfoRequest
+
+        # Create the request - assumes all inputs are valid and of the proper type
+        request = RoundInfoRequest(
+            face_id=[EntityIdentifier(id=kwargs["face_id"])],
+        )
+
+        # Call the gRPC service
+        response = self.commands_stub.GetRoundInfo(request=request)
+
+        # Return the response - formatted as a dictionary
+        return {
+            "along_u": response.along_u,
+            "radius": response.radius,
         }

src/ansys/geometry/core/_grpc/_services/v1/edges.py

@@ -85,4 +85,12 @@ def extrude_edges(self, **kwargs) -> dict:  # noqa: D102
 
     @protect_grpc
     def extrude_edges_up_to(self, **kwargs) -> dict:  # noqa: D102
+        return NotImplementedError
+    
+    @protect_grpc
+    def move_imprint_edges(self, **kwargs) -> dict:  # noqa: D102
+        return NotImplementedError
+    
+    @protect_grpc
+    def offset_edges(self, **kwargs) -> dict:  # noqa: D102
         return NotImplementedError

src/ansys/geometry/core/_grpc/_services/v1/faces.py

@@ -129,4 +129,8 @@ def thicken_faces(self, **kwargs) -> dict:  # noqa: D102
 
     @protect_grpc
     def draft_faces(self, **kwargs) -> dict:  # noqa: D102
+        raise NotImplementedError
+    
+    @protect_grpc
+    def get_round_info(self, **kwargs):  # noqa: D102
         raise NotImplementedError

src/ansys/geometry/core/designer/geometry_commands.py

@@ -26,10 +26,7 @@
 
 from ansys.api.geometry.v0.commands_pb2 import (
     CreateAlignTangentOrientGearConditionRequest,
-    MoveImprintEdgesRequest,
-    OffsetEdgesRequest,
     RenameObjectRequest,
-    RoundInfoRequest,
     SplitBodyRequest,
 )
 from ansys.api.geometry.v0.commands_pb2_grpc import CommandsStub
@@ -39,7 +36,6 @@
 from ansys.geometry.core.connection.client import GrpcClient
 from ansys.geometry.core.connection.conversions import (
     plane_to_grpc_plane,
-    unit_vector_to_grpc_direction,
 )
 from ansys.geometry.core.designer.component import Component
 from ansys.geometry.core.designer.mating_conditions import (
@@ -65,7 +61,7 @@
     check_type_all_elements_in_iterable,
     min_backend_version,
 )
-from ansys.geometry.core.misc.measurements import DEFAULT_UNITS, Angle, Distance
+from ansys.geometry.core.misc.measurements import Angle, Distance
 from ansys.geometry.core.shapes.curves.line import Line
 from ansys.geometry.core.typing import Real
 
@@ -945,8 +941,14 @@ def create_fill_pattern(
         margin = margin if isinstance(margin, Distance) else Distance(margin)
         x_spacing = x_spacing if isinstance(x_spacing, Distance) else Distance(x_spacing)
         y_spacing = y_spacing if isinstance(y_spacing, Distance) else Distance(y_spacing)
-        row_x_offset = row_x_offset if isinstance(row_x_offset, Distance) else Distance(row_x_offset)
-        row_y_offset = row_y_offset if isinstance(row_y_offset, Distance) else Distance(row_y_offset)
+        row_x_offset = (
+            row_x_offset if isinstance(row_x_offset, Distance)
+            else Distance(row_x_offset)
+        )
+        row_y_offset = (
+            row_y_offset if isinstance(row_y_offset, Distance)
+            else Distance(row_y_offset)
+        )
         column_x_offset = (
             column_x_offset if isinstance(column_x_offset, Distance)
             else Distance(column_x_offset)
@@ -1343,9 +1345,11 @@ def get_round_info(self, face: "Face") -> tuple[bool, Real]:
         --------
         This method is only available starting on Ansys release 25R2.
         """
-        result = self._commands_stub.GetRoundInfo(RoundInfoRequest(face=face._grpc_id))
+        result = self._grpc_client._services.faces.get_round_info(
+            face_id = face.id
+        )
 
-        return (result.along_u, result.radius)
+        return (result.get("along_u"), result.get("radius"))
 
     @protect_grpc
     @check_input_types
@@ -1677,30 +1681,23 @@ def move_imprint_edges(
             The edges to move.
         direction : UnitVector3D
             The direction to move the edges.
-        distance : Distance
+        distance : Distance | Quantity | Real
             The distance to move the edges.
 
         Returns
         -------
         bool
             Returns True if the edges were moved successfully, False otherwise.
         """
-        # Convert the distance object
         distance = distance if isinstance(distance, Distance) else Distance(distance)
-        move_magnitude = distance.value.m_as(DEFAULT_UNITS.SERVER_LENGTH)
 
-        # Create the request object
-        request = MoveImprintEdgesRequest(
-            edges=[edge._grpc_id for edge in edges],
-            direction=unit_vector_to_grpc_direction(direction),
-            distance=move_magnitude,
+        response = self._grpc_client._services.edges.move_imprint_edges(
+            edge_ids=[edge.id for edge in edges],
+            direction=direction,
+            distance=distance,
         )
 
-        # Call the gRPC service
-        response = self._commands_stub.MoveImprintEdges(request)
-
-        # Return success flag
-        return response.result.success
+        return response.get("success")
 
     @protect_grpc
     @min_backend_version(26, 1, 0)
@@ -1711,29 +1708,22 @@ def offset_edges(self, edges: list["Edge"], offset: Distance | Quantity | Real)
         ----------
         edges : list[Edge]
             The edges to offset.
-        offset : Distance
+        offset : Distance | Quantity | Real
             The distance to offset the edges.
 
         Returns
         -------
         bool
             Returns True if the edges were offset successfully, False otherwise.
         """
-        # Convert the distance object
         offset = offset if isinstance(offset, Distance) else Distance(offset)
-        offset_magnitude = offset.value.m_as(DEFAULT_UNITS.SERVER_LENGTH)
 
-        # Create the request object
-        request = OffsetEdgesRequest(
-            edges=[edge._grpc_id for edge in edges],
-            value=offset_magnitude,
+        response = self._grpc_client._services.edges.offset_edges(
+            edge_ids=[edge.id for edge in edges],
+            offset=offset,
         )
 
-        # Call the gRPC service
-        response = self._commands_stub.OffsetEdges(request)
-
-        # Return success flag
-        return response.success
+        return response.get("success")
 
     @protect_grpc
     @min_backend_version(26, 1, 0)