Skip to content

Conversation

@RobPasMue
Copy link
Member

@RobPasMue RobPasMue commented Jun 12, 2024

Description

Related to #1192. Verifying on CI/CD the behavior.

Issue linked

Closes #1192

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Jun 12, 2024
@github-actions github-actions bot added the bug Something isn't working label Jun 12, 2024
@RobPasMue RobPasMue added testing Anything related to tests labels Jul 2, 2024
@github-actions github-actions bot removed the testing Anything related to tests label Jul 2, 2024
@RobPasMue RobPasMue marked this pull request as ready for review January 30, 2025 08:55
@RobPasMue RobPasMue requested a review from a team as a code owner January 30, 2025 08:55
@RobPasMue
Copy link
Member Author

Looks like it is finally working!

@codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.03%. Comparing base (c9d691f) to head (cb2acba).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1258   +/-   ##
=======================================
  Coverage   91.03%   91.03%           
=======================================
  Files          91       91           
  Lines        7995     7995           
=======================================
  Hits         7278     7278           
  Misses        717      717           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue merged commit 41ac3ee into main Jan 30, 2025
63 of 75 checks passed
@RobPasMue RobPasMue deleted the fix/temp-body-created-on-intersect branch January 30, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Temp body created when trying to perform an intersection on bodies which do not intersect.

4 participants