Skip to content

Commit 2513e2b

Browse files
PipKatmhoeijmpyansys-ci-botjorgepiloto
authored
docs: overall review (#1043)
Co-authored-by: Martijn <[email protected]> Co-authored-by: pyansys-ci-bot <[email protected]> Co-authored-by: Jorge Martinez <[email protected]> Co-authored-by: Jorge Martínez <[email protected]>
1 parent 5fdb733 commit 2513e2b

File tree

74 files changed

+2250
-2233
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

74 files changed

+2250
-2233
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
standardize type hints for pre, post and utils subpackages
1+
standardize type hints for ``pre``, ``post``, and ``utils`` subpackages

doc/source/changelog/1032.fixed.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
remove wheelhosue from doc/source/_static dir
1+
remove wheelhouse from doc/source/_static dir
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
bump version to 0.12dev0
1+
bump version to 0.12.dev0
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
overall review

doc/source/contribute/developer.rst

Lines changed: 66 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
Contributing as a developer
2-
###########################
1+
Contribute as a developer
2+
#########################
33

44
.. grid:: 1 2 3 3
55

@@ -8,14 +8,14 @@ Contributing as a developer
88
:link: fork-the-repository
99
:link-type: ref
1010

11-
Learn how to fork the project and get your own copy.
11+
Fork the project to create a copy.
1212

1313
.. grid-item-card:: :fa:`download` Clone the repository
1414
:padding: 2 2 2 2
1515
:link: clone-the-repository
1616
:link-type: ref
1717

18-
Download your own copy in your local machine.
18+
Clone the repository to download the copy to your local machine.
1919

2020
.. grid-item-card:: :fa:`download` Install for developers
2121
:padding: 2 2 2 2
@@ -29,21 +29,22 @@ Contributing as a developer
2929
:link: run-tests
3030
:link-type: ref
3131

32-
Verify your changes by testing the project.
32+
Verify your changes to the project by running tests.
3333

3434
.. grid-item-card:: :fa:`computer` Code style compliance
3535
:padding: 2 2 2 2
3636
:link: code-style
3737
:link-type: ref
3838

39-
Adhere to code style
39+
Adhere to code style.
4040

4141
.. grid-item-card:: :fa:`arrows-spin` Run the CI/CD pipelines
4242
:padding: 2 2 2 2
4343
:link: run-pipelines
4444
:link-type: ref
4545

46-
Understand the different CI/CD pipelines.
46+
Understand the different CI/CD pipelines that are executed
47+
automatically.
4748

4849

4950
.. _fork-the-repository:
@@ -52,13 +53,13 @@ Fork the repository
5253
===================
5354

5455
Forking the repository is the first step to contributing to the project. This
55-
allows you to have your own copy of the project so you can make changes without
56+
allows you to have your own copy of the project so that you can make changes without
5657
affecting the main project. Once you have made your changes, you can submit a
57-
pull-request to the main project to have your changes reviewed and merged.
58+
pull request to the main project to have your changes reviewed and merged.
5859

5960
.. button-link:: https://github.com/ansys/pyansys-heart/fork
6061
:color: primary
61-
:align: center
62+
:align: left
6263

6364
:fa:`code-fork` Fork this project
6465

@@ -71,44 +72,42 @@ pull-request to the main project to have your changes reviewed and merged.
7172
Clone the repository
7273
====================
7374

74-
Clone the latest version of PyAnsys Heart in development mode by running this code:
75+
Clone the repository in development mode:
7576

7677
.. code-block:: bash
7778
7879
git clone https://github.com/pyansys/pyansys-heart
7980
8081
.. note::
8182

82-
If you are not an Ansys employee, you need to :ref:`fork the repository <fork-the-repository>` and
83-
replace ``ansys`` with your GitHub user name in the ``git clone``
84-
command.
83+
If you are not an Ansys employee, you must :ref:`fork the repository <fork-the-repository>` and
84+
replace ``ansys`` with your GitHub user name in the ``git clone`` command.
8585

8686
.. _install-for-developers:
8787

8888
Install for developers
8989
======================
9090

91-
Installing PyAnsys Heart in development mode allows you to perform changes to the code
92-
and see the changes reflected in your environment without having to reinstall
91+
Installing PyAnsys Heart in development mode lets you change the code
92+
and see these changes reflected in your environment without having to reinstall
9393
the library every time you make a change.
9494

95-
Virtual environment
96-
-------------------
95+
Set up a virtual environment
96+
----------------------------
9797

98-
Start by navigating to the project's root directory by running:
98+
#. Navigate to the project's root directory :
9999

100100
.. code-block::
101101
102-
cd pyansys-heart
102+
cd pyansys-heart
103103
104-
Then, create a new virtual environment named ``.venv`` to isolate your system's
105-
Python environment by running:
104+
#. Create a virtual environment named ``.venv`` to isolate your Python environment:
106105

107106
.. code-block:: text
108107
109108
python -m venv .venv
110109
111-
Finally, activate this environment by running:
110+
#. Activate the virtual environment:
112111

113112
.. tab-set::
114113

@@ -134,77 +133,77 @@ Finally, activate this environment by running:
134133
135134
source .venv/bin/activate
136135
137-
Development mode
138-
----------------
136+
Install in development mode
137+
---------------------------
139138

140-
Now, install PyAnsys Heart in editable mode by running:
139+
#. Install PyAnsys Heart in editable mode:
141140

142-
.. code-block:: text
143-
144-
python -m pip install --editable .
141+
.. code-block:: text
145142
146-
Verify the installation by checking the version of the library:
143+
python -m pip install --editable .
147144
145+
#. Verify the installation by checking the version of the library:
148146

149147
.. code-block:: python
150148
151149
from ansys.heart import __version__
152150
153-
154151
print(f"PyAnsys Heart version is {__version__}")
155152
156153
.. jinja::
157154

158155
.. code-block:: text
159156
160-
>>> PyAnsys Heart version is {{ PYANSYS_HEART_VERSION }}
157+
>>> PyAnsys Heart version is {{ PYANSYS_HEART_VERSION }}.
161158
162-
Install tox
159+
Install Tox
163160
-----------
164161

165-
Once the project is installed, you can install `tox`_. This is a cross-platform
162+
Once the project is installed, you can install `Tox`_. This is a cross-platform
166163
automation tool. The main advantage of Tox is that it eases routine tasks like project
167164
testing, documentation generation, and wheel building in separate and isolated Python
168-
virtual environments. To install Tox, run:
165+
virtual environments.
169166

170-
.. code-block:: text
167+
#. Install Tox:
168+
169+
.. code-block:: text
171170
172-
python -m pip install tox
171+
python -m pip install tox
173172
174-
Finally, verify the installation by listing all the different environments
173+
#. Verify the installation by listing all the different environments
175174
(automation rules) for PyAnsys Heart:
176175

177-
.. code-block:: text
176+
.. code-block:: text
178177
179-
python -m tox list
178+
python -m tox list
180179
181-
.. jinja:: toxenvs
180+
.. jinja:: toxenvs
182181

183-
.. dropdown:: Default Tox environments
184-
:animate: fade-in
185-
:icon: three-bars
182+
.. dropdown:: Default Tox environments
183+
:animate: fade-in
184+
:icon: three-bars
186185

187-
.. list-table::
188-
:header-rows: 1
189-
:widths: auto
186+
.. list-table::
187+
:header-rows: 1
188+
:widths: auto
190189

191-
* - Environment
192-
- Description
193-
{% for environment in envs %}
194-
{% set name, description = environment.split("->") %}
195-
* - {{ name }}
196-
- {{ description }}
197-
{% endfor %}
190+
* - Environment
191+
- Description
192+
{% for environment in envs %}
193+
{% set name, description = environment.split("->") %}
194+
* - {{ name }}
195+
- {{ description }}
196+
{% endfor %}
198197

199198
.. _run-tests:
200199

201200
Run the tests
202201
=============
203202

204203
Once you have made your changes, you can run the tests to verify that your
205-
modifications did not break the project. PyAnsys Heart tests support different markers
206-
to allow testing with/without coverage (and against specific python versions).
207-
These markers are associated with dedicated `Tox`_ environments.
204+
changes did not break the project. PyAnsys Heart tests support different markers
205+
to allow testing with or without coverage (and against specific Python versions).
206+
These markers are associated with dedicated Tox environments.
208207

209208
.. jinja:: toxenvs
210209

@@ -228,9 +227,9 @@ These markers are associated with dedicated `Tox`_ environments.
228227

229228
.. Note::
230229

231-
The preceding test commands run all tests, including those that require Fluent (which take longer). For more
232-
selective testing, ``-- -vv -m "not requires_fluent or (not extract_models)"`` or ``-- -vv -m "requires_fluent"`` can be
233-
appended to tox testing commands.
230+
The preceding test code runs all tests, including those that require Fluent (which take longer). For more
231+
selective testing, append ``-- -vv -m "not requires_fluent or (not extract_models)"`` or ``-- -vv -m "requires_fluent"``
232+
to Tox testing commands:
234233

235234
.. code:: bash
236235
@@ -244,12 +243,12 @@ These markers are associated with dedicated `Tox`_ environments.
244243
Check code style
245244
================
246245

247-
PyAnsys Heart follows the PEP8 standard as outlined in
246+
PyAnsys Heart follows the PEP 8 standard as described in
248247
`PEP 8 <https://dev.docs.pyansys.com/coding-style/pep8.html>`_ in
249-
the *PyAnsys Developer's Guide* and implements style checking using
248+
the *PyAnsys developer's guide* and implements style checking using
250249
`pre-commit <https://pre-commit.com/>`_.
251250

252-
To ensure your code meets minimum code styling standards, run the following tox environment:
251+
To ensure your code meets minimum code styling standards, run the following Tox environment:
253252

254253
.. jinja:: toxenvs
255254

@@ -293,10 +292,10 @@ Run CI/CD pipelines
293292

294293
PyAnsys Heart has a set of CI/CD pipelines that are executed automatically when certain
295294
events are detected in the repository. Some of these events include opening a
296-
pull-request, labelling a pull-request, and tagging a commit.
295+
pull request, labeling a pull-request, and tagging a commit.
297296

298-
You can label a pull-request to skip certain jobs in the pipeline. Supported
299-
labels are listed in the `PyAnsys Heart labels`_ page.
297+
You can label a pull request to skip certain jobs in the pipeline. Supported
298+
labels are listed on the `PyAnsys Heart labels`_ page.
300299

301300
.. list-table::
302301
:widths: auto
@@ -305,4 +304,4 @@ labels are listed in the `PyAnsys Heart labels`_ page.
305304
* - Label
306305
- Description
307306
* - ``test:skip``
308-
- Skip the model generation tests
307+
- Skip the model generation tests

0 commit comments

Comments
 (0)