refactor: remove unused and outdated method (#1035)

Co-authored-by: pyansys-ci-bot <[email protected]>

Author: mhoeijm

doc/source/changelog/1035.miscellaneous.md

@@ -0,0 +1 @@
+remove unused and outdated method

src/ansys/health/heart/settings/settings.py

@@ -20,7 +20,7 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
-"""Module that defines some classes for settings."""
+"""Module that defines classes that hold settings relevant for PyAnsys-Heart."""
 
 import copy
 from dataclasses import asdict, dataclass, field
@@ -1071,112 +1071,6 @@ def _modify_from_global_settings(self):
         self.num_cpus = int(os.getenv("PYANSYS_HEART_NUM_CPU", self.num_cpus))
         return
 
-    # TODO: @mhoeijm update to ensure compatibility with new LS-DYNA/Ansys versions
-    def _set_env_variables(self):
-        r"""Try to set environment variables for MPI run using Ansys installation root directories.
-
-        Notes
-        -----
-        This is based on lsdynaintelvar.bat and lsdynamsvar.bat in
-        ANSYS Inc\v231\ansys\bin\winx64\lsprepost48\LS-Run 1.0
-        and requires you to install the MPI libraries with the Ansys installer.
-        """
-        # get latest installed Ansys version
-        env_variables = list(os.environ.keys())
-        ansys_env_roots = sorted([k for k in env_variables if "AWP_ROOT" in k])
-        ansys_env_roots.reverse()
-
-        if self.platform == "windows":
-            platform = "winx64"
-        elif self.platform == "linux":
-            platform = "linx64"
-
-        if self.dynatype in "intelmpi":
-            intel_cmp_rev = "2019.5.281"
-            intel_mkl_rev = "2020.0.166"
-            intel_mpi_rev = "2018.3.210"
-
-            if os.getenv("MPI_ROOT"):
-                LOGGER.warning(
-                    "MPI_ROOT already defined. Not trying to automatically set MPI env variables."
-                )
-                return
-
-            for root in ansys_env_roots:
-                mpi_root = os.path.join(
-                    os.getenv(root),
-                    "commonfiles",
-                    "MPI",
-                    "Intel",
-                    intel_mpi_rev,
-                    platform,
-                )
-                mpi_path = os.path.join(mpi_root, "bin")
-                mkl_path = os.path.join(os.getenv(root), "tp", "IntelMKL", intel_mkl_rev, platform)
-                cmp_path = os.path.join(
-                    os.getenv(root), "tp", "IntelCompiler", intel_cmp_rev, platform
-                )
-                for p in [mpi_root, mpi_path, mkl_path, cmp_path]:
-                    if not os.path.isdir(p):
-                        LOGGER.debug("Failed to set env variables with %s " % root)
-                        continue
-
-                LOGGER.info("Setting MPI environment variable MPI_ROOT to %s" % mpi_root)
-                LOGGER.info("Adding %s to PATH" % [mpi_path, mkl_path, cmp_path])
-
-                os.environ["MPI_ROOT"] = mpi_root
-                os.environ["PATH"] = (
-                    ";".join([mpi_path, mkl_path, cmp_path]) + ";" + os.environ["PATH"]
-                )
-                os.environ["I_MPI_AUTH_METHOD"] = "delegate"
-                os.environ["KMP_AFFINITY"] = "verbose"
-                break
-
-        elif self.dynatype == "msmpi" and self.platform == "windows":
-            intel_cmp_rev = "2019.5.281"
-            intel_mkl_rev = "2020.0.166"
-            ms_mpi_rev = "10.1.12498.18"
-
-            if os.getenv("MPI_ROOT"):
-                LOGGER.warning(
-                    "MPI_ROOT already defined. Not trying to automatically set MPI env variables."
-                )
-                return
-
-            for root in ansys_env_roots:
-                mpi_root = os.path.join(
-                    os.getenv(root),
-                    "commonfiles",
-                    "MPI",
-                    "Microsoft",
-                    ms_mpi_rev,
-                    platform,
-                )
-                mpi_path = os.path.join(mpi_root, "bin")
-                mkl_path = os.path.join(os.getenv(root), "tp", "IntelMKL", intel_mkl_rev, platform)
-                cmp_path = os.path.join(
-                    os.getenv(root), "tp", "IntelCompiler", intel_cmp_rev, platform
-                )
-                for p in [mpi_root, mpi_path, mkl_path, cmp_path]:
-                    if not os.path.isdir(p):
-                        LOGGER.debug("Failed to set env variables with %s " % root)
-                        continue
-
-                LOGGER.info("Setting MPI environment variable MPI_ROOT to %s" % mpi_root)
-                LOGGER.info("Adding %s to PATH" % [mpi_path, mkl_path, cmp_path])
-
-                os.environ["MPI_ROOT"] = mpi_root
-                os.environ["PATH"] = (
-                    ";".join([mpi_path, mkl_path, cmp_path]) + ";" + os.environ["PATH"]
-                )
-                break
-
-        elif self.dynatype == "platformmpi":
-            LOGGER.error("Automatically setting env variables for platform mpi not implemented yet")
-            return
-
-        return
-
     def __repr__(self):
         """Represent self as string."""
         return yaml.dump(vars(self), allow_unicode=True, default_flow_style=False)

tests/heart/settings/test_dyna_settings.py

@@ -284,32 +284,6 @@ def test_get_dyna_commands_004(dynatype, platform):
     assert commands == expected
 
 
-@pytest.mark.parametrize(
-    "dynatype,expect_mpi_root", (["intelmpi", True], ["msmpi", True], ["platformmpi", False])
-)
-@pytest.mark.xfail(is_gh_action, reason="No Ansys installation expected on Github runner.")
-def test_set_env_variables(dynatype, expect_mpi_root):
-    """Test setting environment variables."""
-
-    import os
-
-    if os.getenv("MPI_ROOT"):
-        del os.environ["MPI_ROOT"]
-
-    settings = DynaSettings(
-        lsdyna_path="my-dyna-path.exe",
-        dynatype=dynatype,
-        num_cpus=2,
-        platform="windows",
-    )
-    settings._set_env_variables()
-
-    if expect_mpi_root:
-        assert os.getenv("MPI_ROOT")
-
-    pass
-
-
 def test_modify_settings_from_env_variables(monkeypatch):
     """Test to ensure proper override from environment variables."""
     settings = DynaSettings(lsdyna_path="my-dyna-path.exe", dynatype="intelmpi", num_cpus=2)