Skip to content

Commit a8ae52f

Browse files
KarimElHouarimhoeijmpyansys-ci-bot
authored
fix: modify beam mesh doc strings (#1030)
Co-authored-by: Martijn <[email protected]> Co-authored-by: pyansys-ci-bot <[email protected]>
1 parent ee3e6a9 commit a8ae52f

File tree

3 files changed

+11
-8
lines changed

3 files changed

+11
-8
lines changed

doc/source/changelog/1030.fixed.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
modify beam mesh doc strings

src/ansys/health/heart/objects.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1066,16 +1066,14 @@ class _ConductionType(Enum):
10661066

10671067

10681068
class _BeamsMesh(Mesh):
1069-
"""Mesh class: inherits from pyvista UnstructuredGrid.
1069+
"""Mesh class: inherits from Mesh.
10701070
10711071
Notes
10721072
-----
1073-
This class inherits from pyvista.UnstructuredGrid and adds additional
1074-
attributes and convenience methods for enhanced functionality. E.g. we use _volume_id,
1075-
_surface_id and _line_id cell arrays to keep track of "labeled" selections of
1076-
cells. _volume_id is used to group 3D volume cells together.
1077-
Any non 3D volume cell is labeled as numpy.nan. Similarly 2D and 1D cells are tracked
1078-
through _surface_id and _line_id respectively.
1073+
This class inherits from Mesh and adds additional
1074+
attributes and convenience methods for enhanced functionality. Lines of the same component are
1075+
tracked as _line_id, connections to the volume mesh are tracked using the pointdata field
1076+
_is-connected.
10791077
"""
10801078

10811079
def __init__(self, *args):
@@ -1168,6 +1166,8 @@ def add_lines(self, lines: pv.PolyData, id: int = None, name: str = None):
11681166
PolyData representation of the lines to add
11691167
id : int
11701168
ID of the surface to be added. This id will be tracked as "_line-id"
1169+
name: str
1170+
Name of the lines to add
11711171
"""
11721172
if not id:
11731173
return None

src/ansys/health/heart/pre/conduction_beam.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,9 @@ def compute_his_conduction(self, beam_length: float = 1.5) -> tuple[_BeamsMesh,
227227
)
228228
new_nodes = self.m.mesh.points[nodes]
229229
new_nodes = _refine_line(new_nodes, beam_length=beam_length)
230-
new_nodes[0] = self.m.conduction_system.get_lines_by_name("SAN_to_AVN").points[-1]
230+
new_nodes[0] = self.m.conduction_system.get_lines_by_name(
231+
_ConductionType.SAN_AVN.value
232+
).points[-1]
231233
beamnet = pv.lines_from_points(new_nodes)
232234
id = self.m.conduction_system.get_unique_lines_id()
233235
self.m.conduction_system.add_lines(lines=beamnet, id=id, name=_ConductionType.HIS.value)

0 commit comments

Comments
 (0)