Skip to content

Commit 2bd9762

Browse files
committed
doc: modified two source files
1 parent cd41c46 commit 2bd9762

File tree

2 files changed

+49
-43
lines changed

2 files changed

+49
-43
lines changed

src/ansys/dpf/core/custom_operator.py

Lines changed: 30 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
import abc
3232
import ctypes
3333
import os
34-
import pathlib
34+
from pathlib import Path
3535
import re
3636
import shutil
3737
import tempfile
@@ -85,23 +85,23 @@ def update_virtual_environment_for_custom_operators(
8585
raise NotImplementedError(
8686
"Updating the dpf-site.zip of a DPF Server is only available when InProcess."
8787
)
88-
current_dpf_site_zip_path = os.path.join(server.ansys_path, "dpf", "python", "dpf-site.zip")
88+
current_dpf_site_zip_path = Path(server.ansys_path) / "dpf" / "python" / "dpf-site.zip"
8989
# Get the path to where we store the original dpf-site.zip
90-
original_dpf_site_zip_path = os.path.join(
91-
server.ansys_path, "dpf", "python", "original", "dpf-site.zip"
90+
original_dpf_site_zip_path = (
91+
Path(server.ansys_path) / "dpf" / "python" / "original" / "dpf-site.zip"
9292
)
9393
# Restore the original dpf-site.zip
9494
if restore_original:
95-
if os.path.exists(original_dpf_site_zip_path):
95+
if original_dpf_site_zip_path.exists():
9696
shutil.move(src=original_dpf_site_zip_path, dst=current_dpf_site_zip_path)
97-
os.rmdir(os.path.dirname(original_dpf_site_zip_path))
97+
original_dpf_site_zip_path.parent.rmdir()
9898
else:
9999
warnings.warn("No original dpf-site.zip found. Current is most likely the original.")
100100
else:
101101
# Store original dpf-site.zip for this DPF Server if no original is stored
102-
if not os.path.exists(os.path.dirname(original_dpf_site_zip_path)):
103-
os.mkdir(os.path.dirname(original_dpf_site_zip_path))
104-
if not os.path.exists(original_dpf_site_zip_path):
102+
if not original_dpf_site_zip_path.parent.exists():
103+
original_dpf_site_zip_path.parent.mkdir()
104+
if not original_dpf_site_zip_path.exists():
105105
shutil.move(src=current_dpf_site_zip_path, dst=original_dpf_site_zip_path)
106106
# Get the current paths to site_packages
107107
import site
@@ -111,59 +111,60 @@ def update_virtual_environment_for_custom_operators(
111111
# Get the first one targeting an actual site-packages folder
112112
for path_to_site_packages in paths_to_current_site_packages:
113113
if path_to_site_packages[-13:] == "site-packages":
114-
current_site_packages_path = pathlib.Path(path_to_site_packages)
114+
current_site_packages_path = Path(path_to_site_packages)
115115
break
116116
if current_site_packages_path is None:
117117
warnings.warn("Could not find a currently loaded site-packages folder to update from.")
118118
return
119119
# If an ansys.dpf.core.path file exists, then the installation is editable
120-
search_path = pathlib.Path(current_site_packages_path)
120+
search_path = current_site_packages_path
121121
potential_editable = list(search_path.rglob("__editable__.ansys_dpf_core-*.pth"))
122122
if potential_editable:
123123
path_file = potential_editable[0]
124124
else: # Keep for older setuptools versions
125-
path_file = os.path.join(current_site_packages_path, "ansys.dpf.core.pth")
126-
if os.path.exists(path_file):
125+
path_file = current_site_packages_path / "ansys.dpf.core.pth"
126+
if path_file.exists():
127127
# Treat editable installation of ansys-dpf-core
128-
with open(path_file, "r") as f:
128+
with path_file.open("r") as f:
129129
current_site_packages_path = f.readline().strip()
130130
with tempfile.TemporaryDirectory() as tmpdir:
131-
os.mkdir(os.path.join(tmpdir, "ansys_dpf_core"))
132-
ansys_dir = os.path.join(tmpdir, "ansys_dpf_core")
133-
os.mkdir(os.path.join(ansys_dir, "ansys"))
134-
os.mkdir(os.path.join(ansys_dir, "ansys", "dpf"))
135-
os.mkdir(os.path.join(ansys_dir, "ansys", "grpc"))
131+
tmpdir = Path(tmpdir)
132+
ansys_dir = tmpdir / "ansys_dpf_core"
133+
ansys_dir.mkdir()
134+
ansys_dir.joinpath("ansys").mkdir()
135+
ansys_dir.joinpath("ansys", "dpf").mkdir()
136+
ansys_dir.joinpath("ansys", "grpc").mkdir()
136137
shutil.copytree(
137-
src=os.path.join(current_site_packages_path, "ansys", "dpf", "core"),
138-
dst=os.path.join(ansys_dir, "ansys", "dpf", "core"),
138+
src=current_site_packages_path / "ansys" / "dpf" / "core",
139+
dst=ansys_dir / "ansys" / "dpf" / "core",
139140
ignore=lambda directory, contents: ["__pycache__", "result_files"],
140141
)
141142
shutil.copytree(
142-
src=os.path.join(current_site_packages_path, "ansys", "dpf", "gate"),
143-
dst=os.path.join(ansys_dir, "ansys", "dpf", "gate"),
143+
src=current_site_packages_path / "ansys" / "dpf" / "gate",
144+
dst=ansys_dir / "ansys" / "dpf" / "gate",
144145
ignore=lambda directory, contents: ["__pycache__"],
145146
)
146147
shutil.copytree(
147-
src=os.path.join(current_site_packages_path, "ansys", "grpc", "dpf"),
148-
dst=os.path.join(ansys_dir, "ansys", "grpc", "dpf"),
148+
src=current_site_packages_path / "ansys" / "grpc" / "dpf",
149+
dst=ansys_dir / "ansys" / "grpc" / "dpf",
149150
ignore=lambda directory, contents: ["__pycache__"],
150151
)
151152
# Find the .dist_info folder
152153
pattern = re.compile(r"^ansys_dpf_core\S*")
153-
for p in pathlib.Path(current_site_packages_path).iterdir():
154+
for p in current_site_packages_path.iterdir():
154155
if p.is_dir():
155156
# print(p.stem)
156157
if re.search(pattern, p.stem):
157158
dist_info_path = p
158159
break
159160
shutil.copytree(
160161
src=dist_info_path,
161-
dst=os.path.join(ansys_dir, dist_info_path.name),
162+
dst=ansys_dir / dist_info_path.name,
162163
)
163164
# Zip the files as dpf-site.zip
164-
base_name = os.path.join(tmpdir, "ansys_dpf_core_zip")
165+
base_name = tmpdir / "ansys_dpf_core_zip"
165166
base_dir = "."
166-
root_dir = os.path.join(tmpdir, "ansys_dpf_core") # OK
167+
root_dir = tmpdir / "ansys_dpf_core" # OK
167168
shutil.make_archive(
168169
base_name=base_name, root_dir=root_dir, base_dir=base_dir, format="zip"
169170
)

src/ansys/dpf/core/data_sources.py

Lines changed: 19 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
"""
2929

3030
import os
31+
from pathlib import Path
3132
import warnings
3233
import traceback
3334
from typing import Union
@@ -142,7 +143,7 @@ def set_result_file_path(self, filepath, key=""):
142143
['/tmp/file.rst']
143144
144145
"""
145-
extension = os.path.splitext(filepath)[1]
146+
extension = Path(filepath).suffix
146147
# Handle .res files from CFX
147148
if key == "" and extension == ".res":
148149
key = "cas"
@@ -162,7 +163,7 @@ def set_result_file_path(self, filepath, key=""):
162163
def guess_result_key(filepath: str) -> str:
163164
"""Guess result key for files without a file extension."""
164165
result_keys = ["d3plot", "binout"]
165-
base_name = os.path.basename(filepath)
166+
base_name = Path(filepath).name
166167
# Handle files without extension
167168
for result_key in result_keys:
168169
if result_key in base_name:
@@ -172,14 +173,13 @@ def guess_result_key(filepath: str) -> str:
172173
@staticmethod
173174
def guess_second_key(filepath: str) -> str:
174175
"""For files with an h5 or cff extension, look for another extension."""
176+
177+
# These files usually end with .cas.h5 or .dat.h5
175178
accepted = ["cas", "dat"]
176-
without_ext = os.path.splitext(filepath)[0]
177-
new_split = os.path.splitext(without_ext)
179+
new_split = Path(filepath).suffixes
178180
new_key = ""
179-
if len(new_split) > 1:
180-
key = new_split[1][1:]
181-
if key in accepted:
182-
new_key = key
181+
if new_split[0] in accepted:
182+
new_key = new_split[0]
183183
return new_key
184184

185185
def set_domain_result_file_path(
@@ -241,9 +241,12 @@ def add_file_path(self, filepath, key="", is_domain: bool = False, domain_id=0):
241241
242242
"""
243243
# The filename needs to be a fully qualified file name
244-
if not os.path.dirname(filepath):
244+
# if not os.path.dirname(filepath)
245+
246+
filepath = Path(filepath)
247+
if not filepath.parent.name:
245248
# append local path
246-
filepath = os.path.join(os.getcwd(), os.path.basename(filepath))
249+
filepath = Path.cwd() / filepath.name
247250
if is_domain:
248251
if key == "":
249252
raise NotImplementedError("A key must be given when using is_domain=True.")
@@ -280,9 +283,10 @@ def add_domain_file_path(self, filepath, key, domain_id):
280283
281284
"""
282285
# The filename needs to be a fully qualified file name
283-
if not os.path.dirname(filepath):
286+
filepath = Path(filepath)
287+
if not filepath.parent.name:
284288
# append local path
285-
filepath = os.path.join(os.getcwd(), os.path.basename(filepath))
289+
filepath = Path.cwd() / filepath.name
286290
self._api.data_sources_add_domain_file_path_with_key_utf8(
287291
self, str(filepath), key, domain_id
288292
)
@@ -307,9 +311,10 @@ def add_file_path_for_specified_result(self, filepath, key="", result_key=""):
307311
The default is ``""``, in which case the key is found directly.
308312
"""
309313
# The filename needs to be a fully qualified file name
310-
if not os.path.dirname(filepath):
314+
filepath = Path(filepath)
315+
if not filepath.parent.name:
311316
# append local path
312-
filepath = os.path.join(os.getcwd(), os.path.basename(filepath))
317+
filepath = Path.cwd() / filepath.name
313318

314319
self._api.data_sources_add_file_path_for_specified_result_utf8(
315320
self, str(filepath), key, result_key

0 commit comments

Comments
 (0)