Merge branch 'master' into rcanton/test_get_header

Author: rafacanton

.github/workflows/ci.yml

@@ -2,7 +2,7 @@ name: CI
 
 on:
   pull_request:
-    types: [opened, synchronize, reopened, ready_for_review]
+    types: [opened, synchronize, reopened, ready_for_review, closed]
     branches-ignore:
       - '*no-ci*'
   push:
@@ -31,6 +31,7 @@ env:
 jobs:
   debug:
     runs-on: ubuntu-latest
+    if: github.event.action != 'closed'
     steps:
     - name: Show the Github context for the triggered event
       run: echo "$GITHUB_CONTEXT"
@@ -39,6 +40,7 @@ jobs:
 
   pick_server_suffix:
     runs-on: ubuntu-latest
+    if: github.event.action != 'closed'
     outputs:
       suffix: ${{ steps.step1.outputs.suffix }}
     steps:
@@ -69,6 +71,7 @@ jobs:
   style:
     name: "Style Check"
     runs-on: ubuntu-latest
+    if: github.event.action != 'closed'
     steps:
       - uses: ansys/actions/code-style@v8
         with:
@@ -77,6 +80,7 @@ jobs:
   build_linux1:
     name: "Build linux1 wheel"
     runs-on: ubuntu-latest
+    if: github.event.action != 'closed'
     steps:
       - uses: actions/checkout@v4
 
@@ -107,6 +111,7 @@ jobs:
       matrix:
         test-any: ['false', 'true']
     uses: ./.github/workflows/tests.yml
+    if: github.event.action != 'closed'
     needs: pick_server_suffix
     with:
       ANSYS_VERSION: ${{ inputs.ansys_version || vars.ANSYS_VERSION_DEFAULT }}
@@ -121,6 +126,7 @@ jobs:
   docker_tests:
     name: "Build and Test on Docker"
     uses: ./.github/workflows/test_docker.yml
+    if: github.event.action != 'closed'
     needs: pick_server_suffix
     with:
       ANSYS_VERSION: ${{ inputs.ansys_version || vars.ANSYS_VERSION_DEFAULT }}
@@ -130,6 +136,7 @@ jobs:
   docker_examples:
     name: "Run examples on Docker"
     uses: ./.github/workflows/examples_docker.yml
+    if: github.event.action != 'closed'
     needs: pick_server_suffix
     with:
       ANSYS_VERSION: ${{ inputs.ansys_version || vars.ANSYS_VERSION_DEFAULT }}
@@ -138,7 +145,7 @@ jobs:
     secrets: inherit
 
   docs:
-    if: startsWith(github.head_ref, 'master') || github.event.action == 'ready_for_review' || !github.event.pull_request.draft
+    if: github.event.action != 'closed' && (startsWith(github.head_ref, 'master') || github.event.action == 'ready_for_review' || !github.event.pull_request.draft)
     uses: ./.github/workflows/docs.yml
     needs: pick_server_suffix
     with:
@@ -148,9 +155,25 @@ jobs:
       python_version: "3.11"
     secrets: inherit
 
+  doc-deploy-pr:
+    name: "Deploy PR documentation"
+    runs-on: ubuntu-latest
+    needs: docs
+    if: always() && (needs.docs.result == 'success' || needs.docs.result == 'skipped')
+    steps:
+      - uses: ansys/actions/doc-deploy-pr@v10
+        with:
+          cname: ${{ env.DOCUMENTATION_CNAME }}
+          token: ${{ secrets.GITHUB_TOKEN }}
+          doc-artifact-name: HTML-doc-ansys-dpf-core.zip
+          decompress-artifact: true
+          bot-user: ${{ secrets.PYANSYS_CI_BOT_USERNAME }}
+          bot-email: ${{ secrets.PYANSYS_CI_BOT_EMAIL }}
+          maximum-pr-doc-deployments: 10
+
   upload-development-docs:
     runs-on: ubuntu-latest
-    if: ${{ github.ref == 'refs/heads/master' && github.event_name == 'push' }}
+    if: ${{ github.event.action != 'closed' && (github.ref == 'refs/heads/master' && github.event_name == 'push') }}
     needs: [docs]
     steps:
       - name: "Upload development documentation"
@@ -164,7 +187,7 @@ jobs:
           bot-email: ${{ secrets.PYANSYS_CI_BOT_EMAIL }}
 
   examples:
-    if: startsWith(github.head_ref, 'master') || github.event.action == 'ready_for_review' || !github.event.pull_request.draft
+    if: github.event.action != 'closed' && (startsWith(github.head_ref, 'master') || github.event.action == 'ready_for_review' || !github.event.pull_request.draft)
     uses: ./.github/workflows/examples.yml
     needs: pick_server_suffix
     with:
@@ -175,7 +198,7 @@ jobs:
 
   pydpf-post:
     name: "PyDPF-Post"
-    if: startsWith(github.head_ref, 'master') || github.event.action == 'ready_for_review' || !github.event.pull_request.draft
+    if: github.event.action != 'closed' && (startsWith(github.head_ref, 'master') || github.event.action == 'ready_for_review' || !github.event.pull_request.draft)
     uses: ./.github/workflows/pydpf-post.yml
     needs: pick_server_suffix
     with:
@@ -187,7 +210,7 @@ jobs:
 
   tests-retro:
     name: "Test DPF ${{ matrix.dpf.version }} compatibility"
-    if: startsWith(github.head_ref, 'master') || github.event.action == 'ready_for_review' || !github.event.pull_request.draft
+    if: github.event.action != 'closed' && (startsWith(github.head_ref, 'master') || github.event.action == 'ready_for_review' || !github.event.pull_request.draft)
     strategy:
       fail-fast: false
       matrix:

src/ansys/dpf/core/dpf_operator.py

@@ -816,7 +816,9 @@ def eval(self, pin=None):
                 if output._pin == pin:
                     return output()
 
-    def _find_outputs_corresponding_pins(self, type_names, inpt, pin, corresponding_pins):
+    def _find_outputs_corresponding_pins(
+        self, type_names, inpt, pin, corresponding_pins, input_type_name
+    ):
         from ansys.dpf.core.results import Result
 
         for python_name in type_names:
@@ -827,7 +829,7 @@ def _find_outputs_corresponding_pins(self, type_names, inpt, pin, corresponding_
                 python_name = "bool"
 
             # Type match
-            if type(inpt).__name__ == python_name:
+            if input_type_name == python_name:
                 corresponding_pins.append(pin)
             # if the inpt has multiple potential outputs, find which ones can match
             elif isinstance(inpt, (_Outputs, Operator, Result)):

src/ansys/dpf/core/inputs.py

@@ -106,6 +106,8 @@ def connect(self, inpt):
             inpt = inpt.value
 
         input_type_name = type(inpt).__name__
+        if input_type_name == "list":
+            input_type_name = f"list[{type(inpt[0]).__name__}]"
         if not (input_type_name in self._python_expected_types or ["Outputs", "Output", "Any"]):
             for types in self._python_expected_types:
                 print(types, end=" ")
@@ -114,7 +116,7 @@ def connect(self, inpt):
 
         corresponding_pins = []
         self._operator()._find_outputs_corresponding_pins(
-            self._python_expected_types, inpt, self._pin, corresponding_pins
+            self._python_expected_types, inpt, self._pin, corresponding_pins, input_type_name
         )
         if len(corresponding_pins) > 1:
             err_str = "Pin connection is ambiguous, specify the input to connect to with:\n"
@@ -132,7 +134,7 @@ def connect(self, inpt):
 
         if len(corresponding_pins) == 0:
             err_str = (
-                f"The input operator for the {self._spec.name} pin must be "
+                f"The input for the {self._spec.name} pin is of type {input_type_name} but must be "
                 "one of the following types:\n"
             )
             err_str += "\n".join([f"- {py_type}" for py_type in self._python_expected_types])
@@ -260,12 +262,15 @@ def connect(self, inpt):
             inpt = inpt.value
 
         input_type_name = type(inpt).__name__
+        if input_type_name == "list":
+            input_type_name = f"list[{type(inpt[0]).__name__}]"
         for input_pin in self._inputs:
             self._operator()._find_outputs_corresponding_pins(
                 input_pin._python_expected_types,
                 inpt,
                 input_pin._pin,
                 corresponding_pins,
+                input_type_name,
             )
         if len(corresponding_pins) > 1:
             err_str = "Pin connection is ambiguous, specify the input to connect to with:\n"

src/ansys/dpf/core/mapping_types.py

@@ -71,5 +71,8 @@ def __missing__(self, key):
 map_types_to_python = _smart_dict_snake()
 for k, v in map_types_to_cpp.items():
     map_types_to_python[v] = k
-map_types_to_python["vector<double>"] = "list"
+map_types_to_python["vector<bool>"] = "list[bool]"
+map_types_to_python["vector<int32>"] = "list[int]"
+map_types_to_python["vector<double>"] = "list[float]"
+map_types_to_python["vector<string>"] = "list[str]"
 map_types_to_python["b"] = "bool"