Skip to content

Commit 9d9c3e0

Browse files
committed
Revert "Fix server shutdown (#1514)"
This reverts commit 52a7632.
1 parent 36f6a9f commit 9d9c3e0

File tree

2 files changed

+23
-22
lines changed

2 files changed

+23
-22
lines changed

src/ansys/dpf/core/server_types.py

Lines changed: 23 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,6 @@ def __init__(self):
382382
self._session_instance = None
383383
self._base_service_instance = None
384384
self._context = None
385-
self._info_instance = None
386385
self._docker_config = server_factory.RunningDockerConfig()
387386

388387
def set_as_global(self, as_global=True):
@@ -432,10 +431,9 @@ def info(self):
432431
``"server_port"``, ``"server_process_id"``, ``"server_version"`` , ``"os"``
433432
and ``"path"`` keys.
434433
"""
435-
if not self._info_instance:
436-
self._info_instance = self._base_service.server_info
437-
self._info_instance["path"] = self.ansys_path
438-
return self._info_instance
434+
server_info = self._base_service.server_info
435+
server_info["path"] = self.ansys_path
436+
return server_info
439437

440438
def _del_session(self):
441439
if self._session_instance:
@@ -784,7 +782,6 @@ def _create_shutdown_funcs(self):
784782

785783
def shutdown(self):
786784
if self.live:
787-
_ = self.info # initializing the info variable (giving access to ip and port): this can be required if start_local_server is called afterwards
788785
if self._remote_instance:
789786
self._remote_instance.delete()
790787
try:
@@ -830,7 +827,10 @@ def ip(self):
830827
-------
831828
ip : str
832829
"""
833-
return self.info["server_ip"]
830+
try:
831+
return self.info["server_ip"]
832+
except:
833+
return ""
834834

835835
@property
836836
def port(self):
@@ -840,7 +840,10 @@ def port(self):
840840
-------
841841
port : int
842842
"""
843-
return self.info["server_port"]
843+
try:
844+
return self.info["server_port"]
845+
except:
846+
return 0
844847

845848
@property
846849
def external_ip(self):
@@ -1031,6 +1034,8 @@ def __init__(
10311034

10321035
self.live = False
10331036
super().__init__()
1037+
1038+
self._info_instance = None
10341039
self._own_process = launch_server
10351040
self._local_server = False
10361041
self._stubs = {}
@@ -1129,7 +1134,10 @@ def ip(self):
11291134
-------
11301135
ip : str
11311136
"""
1132-
return self.info["server_ip"]
1137+
try:
1138+
return self.info["server_ip"]
1139+
except:
1140+
return ""
11331141

11341142
@property
11351143
def port(self):
@@ -1139,7 +1147,10 @@ def port(self):
11391147
-------
11401148
port : int
11411149
"""
1142-
return self.info["server_port"]
1150+
try:
1151+
return self.info["server_port"]
1152+
except:
1153+
return 0
11431154

11441155
@property
11451156
def external_ip(self):
@@ -1210,15 +1221,14 @@ def local_server(self, val):
12101221

12111222
def shutdown(self):
12121223
if self._own_process and self.live:
1213-
_ = self.info # initializing the info variable (giving access to ip and port): this can be required if start_local_server is called afterwards
1214-
if self._remote_instance:
1215-
self._remote_instance.delete()
12161224
try:
12171225
if hasattr(self, "_preparing_shutdown_func"):
12181226
self._preparing_shutdown_func[0](self._preparing_shutdown_func[1])
12191227
except Exception as e:
12201228
warnings.warn("couldn't prepare shutdown: " + str(e.args))
12211229

1230+
if self._remote_instance:
1231+
self._remote_instance.delete()
12221232
else:
12231233
try:
12241234
if hasattr(self, "_shutdown_func"):

tests/test_server.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -103,15 +103,6 @@ def test_shutdown_all_session_servers(self, server_config):
103103
shutdown_all_session_servers()
104104
assert not has_local_server()
105105

106-
def test_start_shutdown_start(self, server_config):
107-
set_server_configuration(server_config)
108-
# print(dpf.core.SERVER_CONFIGURATION)
109-
server = start_local_server(timeout=20)
110-
server.shutdown()
111-
server = start_local_server(timeout=20)
112-
assert has_local_server()
113-
shutdown_all_session_servers()
114-
115106

116107
@pytest.mark.parametrize("server_config", server_configs)
117108
class TestServer:

0 commit comments

Comments
 (0)