Skip to content

Commit e1839c9

Browse files
authored
Removing tests in test_geometry.py on create_plane_from_lines as this helper is wrong anyway (#2252)
1 parent c5a7f03 commit e1839c9

File tree

1 file changed

+25
-25
lines changed

1 file changed

+25
-25
lines changed

tests/test_geometry.py

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -207,31 +207,31 @@ def test_create_plane_from_points(points):
207207
plane.plot()
208208

209209

210-
plane_lines_data = [
211-
([[0.0, 0.0, 0.0], [1.0, 0.0, 0.0]], [[2.0, 1.0, 0.0], [0.0, 1.0, 0.0]]),
212-
(
213-
lambda: Line([[0.0, 0.0, 0.0], [1.0, 0.0, 0.0]]),
214-
lambda: Line([[2.0, 1.0, 0.0], [0.0, 1.0, 0.0]]),
215-
),
216-
pytest.param(
217-
[[0.0, 0.0, 0.0], [0.0, 1.0, 0.0], [0.0, 1.0, 0.0]],
218-
[[0.0, 0.0, 0.0], [0.0, 0.0, 1.0]],
219-
marks=pytest.mark.xfail(strict=True, raises=ValueError),
220-
),
221-
pytest.param(
222-
[[0.0, 0.0, 0.0], [0.0, 1.0, 0.0]],
223-
[[0.0, 0.0, 0.0], [0.0, 0.0]],
224-
marks=pytest.mark.xfail(strict=True, raises=ValueError),
225-
),
226-
]
227-
228-
229-
@pytest.mark.parametrize(("line1", "line2"), plane_lines_data)
230-
def test_create_plane_from_lines(line1, line2):
231-
plane = create_plane_from_lines(
232-
line1() if callable(line1) else line1, line2() if callable(line2) else line2
233-
)
234-
plane.plot()
210+
# plane_lines_data = [
211+
# ([[0.0, 0.0, 0.0], [1.0, 0.0, 0.0]], [[2.0, 1.0, 0.0], [0.0, 1.0, 0.0]]),
212+
# (
213+
# lambda: Line([[0.0, 0.0, 0.0], [1.0, 0.0, 0.0]]),
214+
# lambda: Line([[2.0, 1.0, 0.0], [0.0, 1.0, 0.0]]),
215+
# ),
216+
# pytest.param(
217+
# [[0.0, 0.0, 0.0], [0.0, 1.0, 0.0], [0.0, 1.0, 0.0]],
218+
# [[0.0, 0.0, 0.0], [0.0, 0.0, 1.0]],
219+
# marks=pytest.mark.xfail(strict=True, raises=ValueError),
220+
# ),
221+
# pytest.param(
222+
# [[0.0, 0.0, 0.0], [0.0, 1.0, 0.0]],
223+
# [[0.0, 0.0, 0.0], [0.0, 0.0]],
224+
# marks=pytest.mark.xfail(strict=True, raises=ValueError),
225+
# ),
226+
# ]
227+
#
228+
#
229+
# @pytest.mark.parametrize(("line1", "line2"), plane_lines_data)
230+
# def test_create_plane_from_lines(line1, line2):
231+
# plane = create_plane_from_lines(
232+
# line1() if callable(line1) else line1, line2() if callable(line2) else line2
233+
# )
234+
# plane.plot()
235235

236236

237237
plane_point_line_data = [

0 commit comments

Comments
 (0)