dpf issues DepreciationWarnings against itself

[andrew-d4]

Before submitting the issue

• I have checked for Compatibility issues
• I have searched among the existing issues
• I am using a Python virtual environment

Description of the bug

This isn't a bug but it is annoying.

When running tests on code that uses dpf, I am getting multiple DepreciationWarnings which are issued by the following line:

Lib\site-packages\ansys\dpf\core\inputs.py:240: DeprecationWarning: Use explicit output-to-input connections.

If I look at the stack trace when these warnings are generated they are caused by dpf code calling the .connect method.

The first 2 examples I found were:
dpf.core.model.Metadata.mesh_provider when running the line mesh_provider.inputs.connect(self._stream_provider.outputs)

dpf.core.model.Metadata._cache_streams_provider when running the line self._stream_provider.inputs.connect(self._data_sources)

Steps To Reproduce

Run pytest on some code that access the functions above.

Which Operating System causes the issue?

Windows

Which DPF/Ansys version are you using?

Ansys 2024 R2

Which Python version causes the issue?

3.11

Installed packages

ansys-api-mapdl==0.5.2
ansys-api-platform-instancemanagement==1.1.3
ansys-dpf-core==0.13.8
ansys-mapdl-core==0.68.4
ansys-mapdl-reader==0.54.2
ansys-math-core==0.1.5
ansys-platform-instancemanagement==1.1.2
ansys-tools-path==0.7.1

[PProfizi]

Hello @andrew-d4,

Thanks for raising this, it is indeed a bug if we still have some lines using that connection logic.
I will look into refactoring them.