Fix environment PATH pollution by CGrpc servers #1590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: paul.profizi <[email protected]>
…ry.get_server_type_from_config Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
PProfizi
changed the title
cbellot000
reviewed
May 27, 2024
src/ansys/dpf/core/server_factory.py
Outdated
| if ansys_path is not None: | ||
| sub_folders = os.path.join(ansys_path, _get_path_in_install()) | ||
| os.environ["PATH"] += sub_folders | ||
| # if ansys_path is None: |
Contributor
Author
There was a problem hiding this comment.
This has been added when we switched to ansys.dpf.gate. Apparently adding the path to GrpcClient.dll. Not required today.
Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1590 +/- ##
==========================================
+ Coverage 80.12% 85.34% +5.22%
==========================================
Files 82 82
Lines 9671 9670 -1
==========================================
+ Hits 7749 8253 +504
+ Misses 1922 1417 -505 |
Signed-off-by: paul.profizi <[email protected]>
cbellot000
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1579